admin/ledgerr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(#40): tint status and navigation bars to match active theme and flip icon appearance #46

Merged
admin merged 1 commits from feat/40-status-and-navigation-bar-colors-dont-follow-current-theme into main 2026-06-28 14:54:59 +00:00
Conversation 0 Commits 1 Files Changed 1
+15 -6
admin commented 2026-06-28 14:53:43 +00:00
Owner
Copy Link
Copy Source

Summary

  • Wire the existing StatusBarColor / NavigationBarColor helpers at the top of AppTheme with colorScheme.background so every screen inherits the tint.
  • Update both helpers to also flip isAppearanceLightStatusBars / isAppearanceLightNavigationBars based on color.luminance() > 0.5f, so the OS-drawn glyphs stay legible in both light and dark mode.

Test plan

  • ./gradlew :app:compileDebugKotlin is green (only pre-existing warnings in unrelated files).
  • Manual: open Ledgerr with system Dark mode on, confirm status and nav bars take the dark background tint and the clock / battery / gesture pill icons are light.
  • Manual: switch Settings → Theme → Light, confirm bars switch to the light tint and icons flip back to dark.
  • Manual: switch Settings → Theme → Dark with system Light, confirm bars stay dark and icons stay light (theme follows app pref, not system).

Closes #40

## Summary - Wire the existing `StatusBarColor` / `NavigationBarColor` helpers at the top of `AppTheme` with `colorScheme.background` so every screen inherits the tint. - Update both helpers to also flip `isAppearanceLightStatusBars` / `isAppearanceLightNavigationBars` based on `color.luminance() > 0.5f`, so the OS-drawn glyphs stay legible in both light and dark mode. ## Test plan - [x] `./gradlew :app:compileDebugKotlin` is green (only pre-existing warnings in unrelated files). - [ ] Manual: open Ledgerr with system Dark mode on, confirm status and nav bars take the dark `background` tint and the clock / battery / gesture pill icons are light. - [ ] Manual: switch Settings → Theme → Light, confirm bars switch to the light tint and icons flip back to dark. - [ ] Manual: switch Settings → Theme → Dark with system Light, confirm bars stay dark and icons stay light (theme follows app pref, not system). Closes #40
admin added 1 commit 2026-06-28 14:53:43 +00:00
fix(#40): tint status and navigation bars to match active theme and flip icon appearance ec941e9e04
admin merged commit 7dc95a8191 into main 2026-06-28 14:54:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/ledgerr#46
Delete Branch "feat/40-status-and-navigation-bar-colors-dont-follow-current-theme"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?