Revert Jdk 11 update

.github/FUNDING.yml

@@ -1 +1,2 @@
+github: inorichi
 ko_fi: inorichi

.github/ISSUE_TEMPLATE.md

@@ -2,15 +2,9 @@
 
 I acknowledge that:
 
-- I have updated:
+- I have updated to the latest version of the app (stable is v1.5.0)
-  - To the latest version of the app (stable is v1.7.0)
+- I have updated all extensions
-  - All extensions
-- I have tried the troubleshooting guide: https://tachiyomi.org/help/guides/troubleshooting-problems/
 - If this is an issue with an extension, that I should be opening an issue in https://github.com/tachiyomiorg/tachiyomi-extensions
-- I have searched the existing issues and this is new ticket **NOT** a duplicate or related to another open issue
-- I will fill out the title and the information in this template
-
-Note that the issue will be automatically closed if you do not fill out the title or requested information.
 
 **DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT**
 
@@ -30,5 +24,3 @@ Note that the issue will be automatically closed if you do not fill out the titl
 
 ## Other details
 Additional details and attachments.
-
-If you're experiencing crashes, share the crash logs from More → Settings → Advanced → Dump crash logs.

.github/ISSUE_TEMPLATE/bug_report.md

@@ -9,15 +9,9 @@ labels: "bug"
 
 I acknowledge that:
 
-- I have updated:
+- I have updated to the latest version of the app (stable is v1.5.0)
-  - To the latest version of the app (stable is v1.7.0)
+- I have updated all extensions
-  - All extensions
-- I have tried the troubleshooting guide: https://tachiyomi.org/help/guides/troubleshooting-problems/
 - If this is an issue with an extension, that I should be opening an issue in https://github.com/tachiyomiorg/tachiyomi-extensions
-- I have searched the existing issues and this is new ticket **NOT** a duplicate or related to another open issue
-- I will fill out the title and the information in this template
-
-Note that the issue will be automatically closed if you do not fill out the title or requested information.
 
 **DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT**
 
@@ -40,5 +34,3 @@ This happened instead.
 
 ## Other details
 Additional details and attachments.
-
-If you're experiencing crashes, share the crash logs from More → Settings → Advanced → Dump crash logs.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -9,14 +9,9 @@ labels: "feature"
 
 I acknowledge that:
 
-- I have updated:
+- I have updated to the latest version of the app (stable is v1.5.0)
-  - To the latest version of the app (stable is v1.7.0)
+- I have updated all extensions
-  - All extensions
 - If this is an issue with an extension, that I should be opening an issue in https://github.com/tachiyomiorg/tachiyomi-extensions
-- I have searched the existing issues and this is new ticket **NOT** a duplicate or related to another open issue
-- I will fill out the title and the information in this template
-
-Note that the issue will be automatically closed if you do not fill out the title or requested information.
 
 **DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT**
 

.github/workflows/issue_closer.yml

@@ -7,30 +7,31 @@ jobs:
   autoclose:
     runs-on: ubuntu-latest
     steps:
-      - name: Autoclose issues
+    - name: Autoclose when created in wrong repo
-        uses: arkon/issue-closer-action@v3.4
+      uses: arkon/issue-closer-action@v1.1
-        with:
+      with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
-          rules: |
+        type: title
-            [
+        regex: ".*THIS ISSUE IS IN THE WRONG REPO.*"
-              {
+        message: "@${issue.user.login} this issue was automatically closed because it was not opened in the correct repo, as the template mentioned."
-                "type": "title",
+    - name: Autoclose when no short description provided
-                "regex": ".*THIS ISSUE IS IN THE WRONG REPO.*",
+      uses: arkon/issue-closer-action@v1.1
-                "message": "It was not opened in the correct repo, as the template mentioned."
+      with:
-              },
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
-              {
+        type: title
-                "type": "title",
+        regex: ".*<Write short description here>*"
-                "regex": ".*<Write short description here>*",
+        message: "@${issue.user.login} this issue was automatically closed because you did not fill out the description in the title."
-                "message": "The description in the title was not filled out."
+    - name: Autoclose when body acknowledgement section not removed
-              },
+      uses: arkon/issue-closer-action@v1.1
-              {
+      with:
-                "type": "body",
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
-                "regex": ".*DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT.*",
+        type: body
-                "message": "The acknowledgment section was not removed."
+        regex: ".*DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT.*"
-              },
+        message: "@${issue.user.login} this issue was automatically closed because the acknowledgment section was not removed."
-              {
+    - name: Autoclose when body requested information not filled out
-                "type": "body",
+      uses: arkon/issue-closer-action@v1.1
-                "regex": ".*\\* (Tachiyomi version|Android version|Device): \\?.*",
+      with:
-                "message": "Requested information in the template was not filled out."
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
-              }
+        type: body
-            ]
+        regex: ".*\\* (Tachiyomi version|Android version|Device): \\?.*"
+        message: "@${issue.user.login} this issue was automatically closed because the requested information was not filled out."

.github/workflows/issue_moderator.yml

@@ -1,14 +0,0 @@
-name: Issue moderator
-
-on:
-  issue_comment:
-    types: [created]
-
-jobs:
-  moderate:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Moderate issues
-        uses: tachiyomiorg/issue-moderator-action@v1.0
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/lock.yml

@@ -1,19 +0,0 @@
-name: Lock threads
-
-on:
-  # Daily
-  schedule:
-    - cron: '0 * * * *'
-  # Manual trigger
-  workflow_dispatch:
-    inputs:
-
-jobs:
-  lock:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: dessant/lock-threads@v2
-        with:
-          github-token: ${{ github.token }}
-          issue-lock-inactive-days: '2'
-          pr-lock-inactive-days: '2'

CODE_OF_CONDUCT.md

@@ -1,76 +0,0 @@
-# Code of Conduct
-
-## Our Pledge
-
-In the interest of fostering an open and welcoming environment, we as
-contributors and maintainers pledge to making participation in our project and
-our community a harassment-free experience for everyone, regardless of age, body
-size, disability, ethnicity, sex characteristics, gender identity and expression,
-level of experience, education, socio-economic status, nationality, personal
-appearance, race, religion, or sexual identity and orientation.
-
-## Our Standards
-
-Examples of behavior that contributes to creating a positive environment
-include:
-
-* Using welcoming and inclusive language
-* Being respectful of differing viewpoints and experiences
-* Gracefully accepting constructive criticism
-* Focusing on what is best for the community
-* Showing empathy towards other community members
-
-Examples of unacceptable behavior by participants include:
-
-* The use of sexualized language or imagery and unwelcome sexual attention or
- advances
-* Trolling, insulting/derogatory comments, and personal or political attacks
-* Public or private harassment
-* Publishing others' private information, such as a physical or electronic
- address, without explicit permission
-* Other conduct which could reasonably be considered inappropriate in a
- professional setting
-
-## Our Responsibilities
-
-Project maintainers are responsible for clarifying the standards of acceptable
-behavior and are expected to take appropriate and fair corrective action in
-response to any instances of unacceptable behavior.
-
-Project maintainers have the right and responsibility to remove, edit, or
-reject comments, commits, code, wiki edits, issues, and other contributions
-that are not aligned to this Code of Conduct, or to ban temporarily or
-permanently any contributor for other behaviors that they deem inappropriate,
-threatening, offensive, or harmful.
-
-## Scope
-
-This Code of Conduct applies both within project spaces and in public spaces
-when an individual is representing the project or its community. Examples of
-representing a project or community include using an official project e-mail
-address, posting via an official social media account, or acting as an appointed
-representative at an online or offline event. Representation of a project may be
-further defined and clarified by project maintainers.
-
-## Enforcement
-
-Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting the project team at the Tachiyomi [Discord server](https://discord.gg/tachiyomi). All
-complaints will be reviewed and investigated and will result in a response that
-is deemed necessary and appropriate to the circumstances. The project team is
-obligated to maintain confidentiality with regard to the reporter of an incident.
-Further details of specific enforcement policies may be posted separately.
-
-Project maintainers who do not follow or enforce the Code of Conduct in good
-faith may face temporary or permanent repercussions as determined by other
-members of the project's leadership.
-
-## Attribution
-
-This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
-available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
-
-[homepage]: https://www.contributor-covenant.org
-
-For answers to common questions about this code of conduct, see
-https://www.contributor-covenant.org/faq

README.md

@@ -1,17 +1,17 @@
 | Preview Builds | Release Builds | Tachiyomi Support Server |
 |-------|----------|----------|
-| [![Preview](https://github.com/jobobby04/TachiyomiSYPreview/workflows/Remote%20Dispatch%20Build%20App/badge.svg)](https://github.com/jobobby04/TachiyomiSYPreview/releases) | [![stable release](https://img.shields.io/github/release/jobobby04/tachiyomisy.svg?maxAge=3600&label=download)](https://github.com/jobobby04/tachiyomisy/releases/latest) | [![Discord](https://img.shields.io/discord/349436576037732353.svg?label=discord&labelColor=7289da&color=2c2f33&style=flat)](https://discord.gg/tachiyomi) |
+| [![Preview](https://github.com/jobobby04/TachiyomiSYPreview/workflows/Remote%20Dispatch%20Build%20App/badge.svg)](https://github.com/jobobby04/TachiyomiSYPreview/releases) | [![stable release](https://img.shields.io/github/release/jobobby04/tachiyomisy.svg?maxAge=3600&label=download)](https://github.com/jobobby04/tachiyomisy/releases/latest) | [![Discord](https://img.shields.io/discord/349436576037732353.svg)](https://discord.gg/tachiyomi) |
 
 
 # ![app icon](./.github/readme-images/app-icon.png)TachiyomiSY
-Tachiyomi is a free and open source manga reader for Android 6.0 and above. This version of Tachiyomi, TachiyomiSY was based off TachiyomiAZ. This version is meant to push forward in the ways of usability and features. TachiyomiSY tries to push forward where it can, but staying in a place where it can easily grab updates and features from the main app, it tries to make new features, or take features from other forks like J2K and Neko.
+Tachiyomi is a free and open source manga reader for Android 5.0 and above. This version of Tachiyomi, TachiyomiSY was based off TachiyomiAZ. This version is meant to push forward in the ways of usability and features. TachiyomiSY tries to push forward where it can, but staying in a place where it can easily grab updates and features from the main app, it tries to make new features, or take features from other forks like J2K and Neko.
 
 ![screenshots of app](./.github/readme-images/screens.png)
 
 ## Features
 
 Features of Tachiyomi(original) include:
-* Online reading from [a variety of sources](https://github.com/tachiyomiorg/tachiyomi-extensions)
+* Online reading from sources such as MangaDex, MangaSee, Mangakakalot, [and more](https://github.com/tachiyomiorg/tachiyomi-extensions)
 * Local reading of downloaded manga
 * A configurable reader with multiple viewers, reading directions and other settings.
 * [MyAnimeList](https://myanimelist.net/), [AniList](https://anilist.co/), [Kitsu](https://kitsu.io/), [Shikimori](https://shikimori.one), and [Bangumi](https://bgm.tv/) support
@@ -109,12 +109,7 @@ Source requests should be created at https://github.com/tachiyomiorg/tachiyomi-e
 
 <details><summary>Contributing</summary>
 
-See [CONTRIBUTING.md](./CONTRIBUTING.md).
+See [CONTRIBUTING.md](https://github.com/tachiyomiorg/tachiyomi/blob/master/CONTRIBUTING.md).
-</details>
-
-<details><summary>Code of Conduct</summary>
-
-See [CODE_OF_CONDUCT.md](./CODE_OF_CONDUCT.md).
 </details>
 
 ## FAQ

app/build.gradle.kts

@@ -8,11 +8,11 @@ plugins {
     id("com.android.application")
     id("com.mikepenz.aboutlibraries.plugin")
     kotlin("android")
+    kotlin("kapt")
     kotlin("plugin.parcelize")
     kotlin("plugin.serialization")
     id("com.github.zellius.shortcut-helper")
     // Realm (EH)
-    kotlin("kapt")
     id("realm-android")
 }
 
@@ -34,8 +34,8 @@ android {
         minSdkVersion(AndroidConfig.minSdk)
         targetSdkVersion(AndroidConfig.targetSdk)
         testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
-        versionCode = 19
+        versionCode = 13
-        versionName = "1.7.0"
+        versionName = "1.5.0"
 
         buildConfigField("String", "COMMIT_COUNT", "\"${getCommitCount()}\"")
         buildConfigField("String", "COMMIT_SHA", "\"${getGitSha()}\"")
@@ -62,12 +62,14 @@ android {
             applicationIdSuffix = ".rt"
             //isMinifyEnabled = true
             //isShrinkResources = true
-            setProguardFiles(listOf(getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro"))
+            isZipAlignEnabled = true
+            setProguardFiles(listOf(getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"))
         }
         named("release") {
             isMinifyEnabled = true
             isShrinkResources = true
-            setProguardFiles(listOf(getDefaultProguardFile("proguard-android-optimize.txt"), "proguard-rules.pro"))
+            isZipAlignEnabled = true
+            setProguardFiles(listOf(getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"))
         }
     }
 
@@ -93,7 +95,6 @@ android {
         exclude("META-INF/LICENSE")
         exclude("META-INF/LICENSE.txt")
         exclude("META-INF/NOTICE")
-        exclude("META-INF/*.kotlin_module")
 
         // Compatibility for two RxJava versions (EXH)
         exclude("META-INF/rxjava.properties")
@@ -122,34 +123,34 @@ android {
 dependencies {
 
     // Source models and interfaces from Tachiyomi 1.x
-    implementation("org.tachiyomi:source-api:1.1")
+    implementation("tachiyomi.sourceapi:source-api:1.1")
 
     // AndroidX libraries
-    implementation("androidx.annotation:annotation:1.3.0-alpha01")
+    implementation("androidx.annotation:annotation:1.2.0-beta01")
-    implementation("androidx.appcompat:appcompat:1.4.0-alpha01")
+    implementation("androidx.appcompat:appcompat:1.3.0-beta01")
-    implementation("androidx.biometric:biometric-ktx:1.2.0-alpha03")
+    implementation("androidx.biometric:biometric-ktx:1.2.0-alpha02")
     implementation("androidx.browser:browser:1.3.0")
     implementation("androidx.cardview:cardview:1.0.0")
-    implementation("androidx.constraintlayout:constraintlayout:2.1.0-beta02")
+    implementation("androidx.constraintlayout:constraintlayout:2.1.0-alpha2")
     implementation("androidx.coordinatorlayout:coordinatorlayout:1.1.0")
-    implementation("androidx.core:core-ktx:1.6.0-beta01")
+    implementation("androidx.core:core-ktx:1.5.0-beta01")
     implementation("androidx.multidex:multidex:2.0.1")
     implementation("androidx.preference:preference-ktx:1.1.1")
-    implementation("androidx.recyclerview:recyclerview:1.2.0")
+    implementation("androidx.recyclerview:recyclerview:1.2.0-beta01")
     implementation("androidx.swiperefreshlayout:swiperefreshlayout:1.2.0-alpha01")
 
-    val lifecycleVersion = "2.4.0-alpha01"
+    val lifecycleVersion = "2.3.0-rc01"
     implementation("androidx.lifecycle:lifecycle-common-java8:$lifecycleVersion")
     implementation("androidx.lifecycle:lifecycle-process:$lifecycleVersion")
     implementation("androidx.lifecycle:lifecycle-runtime-ktx:$lifecycleVersion")
 
     // Job scheduling
-    implementation("androidx.work:work-runtime-ktx:2.7.0-alpha03")
+    implementation("androidx.work:work-runtime-ktx:2.5.0")
 
     // UI library
-    implementation("com.google.android.material:material:1.4.0-beta01")
+    implementation("com.google.android.material:material:1.3.0")
 
-    "standardImplementation"("com.google.firebase:firebase-core:19.0.0")
+    "standardImplementation"("com.google.firebase:firebase-core:18.0.2")
 
     // ReactiveX
     implementation("io.reactivex:rxandroid:1.2.1")
@@ -158,7 +159,7 @@ dependencies {
     implementation("com.github.pwittchen:reactivenetwork:0.13.0")
 
     // Network client
-    val okhttpVersion = "4.9.1"
+    val okhttpVersion = "4.10.0-RC1"
     implementation("com.squareup.okhttp3:okhttp:$okhttpVersion")
     implementation("com.squareup.okhttp3:logging-interceptor:$okhttpVersion")
     implementation("com.squareup.okhttp3:okhttp-dnsoverhttps:$okhttpVersion")
@@ -168,7 +169,7 @@ dependencies {
     implementation("org.conscrypt:conscrypt-android:2.5.1")
 
     // JSON
-    val kotlinSerializationVersion = "1.1.0"
+    val kotlinSerializationVersion = "1.0.1"
     implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:$kotlinSerializationVersion")
     implementation("org.jetbrains.kotlinx:kotlinx-serialization-protobuf:$kotlinSerializationVersion")
     implementation("com.google.code.gson:gson:2.8.6")
@@ -179,7 +180,7 @@ dependencies {
 
     // Disk
     implementation("com.jakewharton:disklrucache:2.0.2")
-    implementation("com.github.tachiyomiorg:unifile:17bec43")
+    implementation("com.github.inorichi:unifile:e9ee588")
     implementation("com.github.junrar:junrar:7.4.0")
 
     // HTML parser
@@ -189,10 +190,10 @@ dependencies {
     implementation("androidx.sqlite:sqlite-ktx:2.1.0")
     implementation("com.github.inorichi.storio:storio-common:8be19de@aar")
     implementation("com.github.inorichi.storio:storio-sqlite:8be19de@aar")
-    implementation("com.github.requery:sqlite-android:3.35.5")
+    implementation("io.requery:sqlite-android:3.33.0")
 
     // Preferences
-    implementation("com.github.tfcporciuncula.flow-preferences:flow-preferences:1.4.0")
+    implementation("com.github.tfcporciuncula.flow-preferences:flow-preferences:1.3.3")
 
     // Model View Presenter
     val nucleusVersion = "3.0.0"
@@ -203,14 +204,14 @@ dependencies {
     implementation("com.github.inorichi.injekt:injekt-core:65b0440")
 
     // Image library
-    val coilVersion = "1.2.0"
+    val glideVersion = "4.11.0"
-    implementation("io.coil-kt:coil:$coilVersion")
+    implementation("com.github.bumptech.glide:glide:$glideVersion")
-    implementation("io.coil-kt:coil-gif:$coilVersion")
+    implementation("com.github.bumptech.glide:okhttp3-integration:$glideVersion")
+    kapt("com.github.bumptech.glide:compiler:$glideVersion")
 
-    implementation("com.github.tachiyomiorg:subsampling-scale-image-view:846abe0") {
+    implementation("com.github.tachiyomiorg:subsampling-scale-image-view:6caf219")
-        exclude(module = "image-decoder")
+    // TODO: switch to new decoder for stable releases
-    }
+    // implementation("com.github.tachiyomiorg:subsampling-scale-image-view:ca26317")
-    implementation("com.github.tachiyomiorg:image-decoder:7a44c9b")
 
     // Logging
     implementation("com.jakewharton.timber:timber:4.7.1")
@@ -222,13 +223,13 @@ dependencies {
     implementation("com.github.gpanther:java-nat-sort:natural-comparator-1.1")
 
     // UI
+    implementation("com.dmitrymalkovich.android:material-design-dimens:1.4")
     implementation("com.github.dmytrodanylyk.android-process-button:library:1.0.4")
     implementation("eu.davidea:flexible-adapter:5.1.0")
     implementation("eu.davidea:flexible-adapter-ui:1.0.0")
     implementation("com.nightlynexus.viewstatepageradapter:viewstatepageradapter:1.1.0")
     implementation("com.github.chrisbanes:PhotoView:2.3.0")
-    implementation("com.github.tachiyomiorg:DirectionalViewPager:1.0.0")
+    implementation("com.github.tachiyomiorg:DirectionalViewPager:7d0617d")
-    implementation("dev.chrisbanes.insetter:insetter:0.6.0")
 
     // 3.2.0+ introduces weird UI blinking or cut off issues on some devices
     val materialDialogsVersion = "3.1.1"
@@ -241,10 +242,10 @@ dependencies {
     implementation("com.bluelinelabs:conductor-support:2.1.5") {
         exclude(group = "com.android.support")
     }
-    implementation("com.github.tachiyomiorg:conductor-support-preference:2.0.1")
+    implementation("com.github.tachiyomiorg:conductor-support-preference:1.1.1")
 
     // FlowBinding
-    val flowbindingVersion = "1.0.0"
+    val flowbindingVersion = "0.12.0"
     implementation("io.github.reactivecircus.flowbinding:flowbinding-android:$flowbindingVersion")
     implementation("io.github.reactivecircus.flowbinding:flowbinding-appcompat:$flowbindingVersion")
     implementation("io.github.reactivecircus.flowbinding:flowbinding-recyclerview:$flowbindingVersion")
@@ -255,7 +256,7 @@ dependencies {
     implementation("com.mikepenz:aboutlibraries:${BuildPluginsVersion.ABOUTLIB_PLUGIN}")
 
     // Tests
-    testImplementation("junit:junit:4.13.2")
+    testImplementation("junit:junit:4.13.1")
     testImplementation("org.assertj:assertj-core:3.16.1")
     testImplementation("org.mockito:mockito-core:1.10.19")
 
@@ -266,12 +267,12 @@ dependencies {
 
     implementation(kotlin("reflect", version = BuildPluginsVersion.KOTLIN))
 
-    val coroutinesVersion = "1.5.0"
+    val coroutinesVersion = "1.4.2"
     implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:$coroutinesVersion")
     implementation("org.jetbrains.kotlinx:kotlinx-coroutines-android:$coroutinesVersion")
 
     // For detecting memory leaks; see https://square.github.io/leakcanary/
-    // debugImplementation("com.squareup.leakcanary:leakcanary-android:2.7")
+    // debugImplementation("com.squareup.leakcanary:leakcanary-android:2.6")
 
     // SY -->
     // [EXH] Android 7 SSL Workaround
@@ -284,11 +285,11 @@ dependencies {
     implementation ("info.debatty:java-string-similarity:2.0.0")
 
     // Firebase (EH)
-    implementation("com.google.firebase:firebase-analytics-ktx:19.0.0")
+    implementation("com.google.firebase:firebase-analytics-ktx:18.0.0")
-    implementation("com.google.firebase:firebase-crashlytics-ktx:18.0.0")
+    implementation("com.google.firebase:firebase-crashlytics-ktx:17.3.0")
 
     // Better logging (EH)
-    implementation("com.elvishew:xlog:1.9.0")
+    implementation("com.elvishew:xlog:1.7.1")
 
     // Debug utils (EH)
     val debugOverlayVersion = "1.1.3"
@@ -298,7 +299,15 @@ dependencies {
     testImplementation("com.ms-square:debugoverlay-no-op:$debugOverlayVersion")
 
     // RatingBar (SY)
-    implementation("me.zhanghai.android.materialratingbar:library:1.4.0")
+    implementation ("me.zhanghai.android.materialratingbar:library:1.4.0")
+
+    // JsonReader for similar manga
+    implementation("com.squareup.moshi:moshi:1.11.0")
+
+    implementation("androidx.gridlayout:gridlayout:1.0.0")
+
+    implementation("com.mikepenz:fastadapter:5.3.4")
+    // SY -->
 }
 
 tasks {
@@ -311,8 +320,7 @@ tasks {
             "-Xuse-experimental=kotlinx.coroutines.FlowPreview",
             "-Xuse-experimental=kotlinx.coroutines.ExperimentalCoroutinesApi",
             "-Xuse-experimental=kotlinx.coroutines.InternalCoroutinesApi",
-            "-Xuse-experimental=kotlinx.serialization.ExperimentalSerializationApi",
+            "-Xuse-experimental=kotlinx.serialization.ExperimentalSerializationApi"
-            "-Xuse-experimental=coil.annotation.ExperimentalCoilApi",
         )
     }
 

app/proguard-android-optimize.txt

@@ -1,34 +0,0 @@
--allowaccessmodification
--dontusemixedcaseclassnames
--verbose
-
--keepattributes *Annotation*
-
--keepclasseswithmembernames,includedescriptorclasses class * {
-    native <methods>;
-}
-
--keepclassmembers enum * {
-    public static **[] values();
-    public static ** valueOf(java.lang.String);
-}
-
--keepclassmembers class * implements android.os.Parcelable {
-  public static final ** CREATOR;
-}
-
--keep class androidx.annotation.Keep
-
--keep @androidx.annotation.Keep class * {*;}
-
--keepclasseswithmembers class * {
-    @androidx.annotation.Keep <methods>;
-}
-
--keepclasseswithmembers class * {
-    @androidx.annotation.Keep <fields>;
-}
-
--keepclasseswithmembers class * {
-    @androidx.annotation.Keep <init>(...);
-}

app/proguard-rules.pro

@@ -58,7 +58,6 @@
     kotlinx.serialization.KSerializer serializer(...);
 }
 
-# Filter serializer
 -keep,includedescriptorclasses class xyz.nulldev.ts.api.http.serializer.**$$serializer { *; }
 -keepclassmembers class xyz.nulldev.ts.api.http.serializer.** {
     *** Companion;
@@ -67,22 +66,37 @@
     kotlinx.serialization.KSerializer serializer(...);
 }
 
-# Keep extension's common dependencies
+# Madokami extension username and password crash fix
--keep,allowoptimization class eu.kanade.tachiyomi.** { public protected *; }
+-keepclassmembers class androidx.preference.EditTextPreference {
--keep,allowoptimization class kotlin.** { public protected *; }
+      *** mOnBindEditTextListener;
--keep,allowoptimization class okhttp3.** { public protected *; }
+      *** mText;
--keep,allowoptimization class rx.** { public protected *; }
+      public *;
--keep,allowoptimization class org.jsoup.** { public protected *; }
+}
--keep,allowoptimization class com.google.gson.** { public protected *; }
+
--keep,allowoptimization class com.github.salomonbrys.kotson.** { public protected *; }
+# Hitomi extension crash fix
--keep,allowoptimization class com.squareup.duktape.** { public protected *; }
+-keepclassmembers class rx.Single {
--keep,allowoptimization class androidx.preference.** { *; }
+      *** onSubscribe;
--keep,allowoptimization class okio.** { *; }
+      final *;
--keep,allowoptimization class kotlinx.serialization.** { *; }
+      protected *;
+      public *;
+}
 
 # RxJava 1.1.0
 -dontwarn sun.misc.**
 
+-keepclassmembers class rx.internal.util.unsafe.*ArrayQueue*Field* {
+   long producerIndex;
+   long consumerIndex;
+}
+
+-keepclassmembers class rx.internal.util.unsafe.BaseLinkedQueueProducerNodeRef {
+    rx.internal.util.atomic.LinkedQueueNode producerNode;
+}
+
+-keepclassmembers class rx.internal.util.unsafe.BaseLinkedQueueConsumerNodeRef {
+    rx.internal.util.atomic.LinkedQueueNode consumerNode;
+}
+
 -dontnote rx.internal.util.PlatformDependent
 
 # === Reactive network: https://github.com/pwittchen/ReactiveNetwork/tree/v0.12.4#proguard-configuration
@@ -119,9 +133,8 @@
 # Application classes that will be serialized/deserialized over Gson
 -keep class com.google.gson.examples.android.model.** { <fields>; }
 
-# Prevent proguard from stripping interface information from TypeAdapterFactory, TypeAdapter,
+# Prevent proguard from stripping interface information from TypeAdapterFactory,
 # JsonSerializer, JsonDeserializer instances (so they can be used in @JsonAdapter)
--keep class * extends com.google.gson.TypeAdapter
 -keep class * implements com.google.gson.TypeAdapterFactory
 -keep class * implements com.google.gson.JsonSerializer
 -keep class * implements com.google.gson.JsonDeserializer
@@ -142,6 +155,20 @@
 ## From original config: "Attempt to fix: java.lang.NoClassDefFoundError: uy.kohesive.injekt.registry.default.DefaultRegistrar$NOKEY$1"
 -keep class uy.kohesive.injekt.** { *; }
 
+
+# === Glide
+-keep public class * implements com.bumptech.glide.module.GlideModule
+-keep public class * extends com.bumptech.glide.module.AppGlideModule
+-keep public enum com.bumptech.glide.load.ImageHeaderParser$** {
+  **[] $VALUES;
+  public *;
+}
+
+-dontwarn com.bumptech.glide.load.resource.bitmap.VideoDecoder
+
+# === Glide-transformations: https://github.com/wasabeef/glide-transformations/blob/3aa8e53c6a51b8351d312f802ba1354c5b115168/transformations/proguard-rules.txt
+-dontwarn jp.co.cyberagent.android.gpuimage.**
+
 # === Conductor
 # This isn't in the consumer proguard rules yet: https://github.com/bluelinelabs/Conductor/pull/550/files
 -keepclassmembers public class * extends com.bluelinelabs.conductor.ControllerChangeHandler {

app/shortcuts.xml

@@ -17,7 +17,7 @@
         android:shortcutDisabledMessage="@string/app_not_available"
         android:shortcutId="show_recently_updated"
         android:shortcutLongLabel="@string/label_recent_updates"
-        android:shortcutShortLabel="@string/label_recent_updates">
+        android:shortcutShortLabel="@string/short_recent_updates">
         <intent
             android:action="eu.kanade.tachiyomi.SHOW_RECENTLY_UPDATED"
             android:targetClass="eu.kanade.tachiyomi.ui.main.MainActivity" />

app/src/main/AndroidManifest.xml

@@ -14,7 +14,6 @@
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
     <uses-permission android:name="android.permission.WAKE_LOCK" />
     <uses-permission android:name="android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS" />
-    <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
 
     <!-- For managing extensions -->
     <uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" />
@@ -33,7 +32,7 @@
         android:largeHeap="true"
         android:requestLegacyExternalStorage="true"
         android:roundIcon="@mipmap/ic_launcher_round"
-        android:theme="@style/Theme.Base"
+        android:theme="@style/Theme.Tachiyomi.Light"
         android:networkSecurityConfig="@xml/network_security_config">
         <activity
             android:name=".ui.main.MainActivity"
@@ -84,8 +83,8 @@
                 android:resource="@xml/s_pen_actions"/>
         </activity>
         <activity
-            android:name=".ui.security.UnlockActivity"
+            android:name=".ui.security.BiometricUnlockActivity"
-            android:theme="@style/Theme.Base" />
+            android:theme="@style/Theme.Splash" />
         <activity
             android:name=".ui.webview.WebViewActivity"
             android:configChanges="uiMode|orientation|screenSize" />
@@ -150,10 +149,6 @@
             android:name=".extension.util.ExtensionInstallActivity"
             android:theme="@android:style/Theme.Translucent.NoTitleBar" />
 
-        <activity
-            android:name="exh.ui.login.EhLoginActivity"
-            android:label="EHentaiLogin" />
-
         <provider
             android:name="androidx.core.content.FileProvider"
             android:authorities="${applicationId}.provider"
@@ -189,6 +184,10 @@
             android:exported="false" />
 
         <!-- EH -->
+        <service
+            android:name="exh.md.similar.SimilarUpdateService"
+            android:exported="false" />
+
         <service
             android:name="exh.eh.EHentaiUpdateWorker"
             android:permission="android.permission.BIND_JOB_SERVICE"
@@ -196,7 +195,7 @@
         <activity
             android:name="exh.ui.intercept.InterceptActivity"
             android:label="@string/app_name"
-            android:theme="@style/Theme.Base">
+            android:theme="@style/Theme.EHActivity">
             <intent-filter>
                 <action android:name="android.intent.action.VIEW" />
 
@@ -316,7 +315,7 @@
                     android:scheme="https" />
 
                 <!-- MangaDex -->
-                <!--<data
+                <data
                     android:scheme="https"
                     android:host="www.mangadex.org"
                     android:pathPrefix="/manga/" />
@@ -365,12 +364,12 @@
                 <data
                     android:scheme="https"
                     android:host="www.mangadex.cc"
-                    android:pathPrefix="/chapter/" />-->
+                    android:pathPrefix="/chapter/" />
             </intent-filter>
         </activity>
         <activity
             android:name="exh.ui.captcha.BrowserActionActivity"
-            android:theme="@style/Theme.Base" />
+            android:theme="@style/Theme.EHActivity" />
     </application>
 
 </manifest>

app/src/main/java/eu/kanade/tachiyomi/App.kt

@@ -1,29 +1,16 @@
 package eu.kanade.tachiyomi
 
-import android.app.ActivityManager
 import android.app.Application
-import android.app.PendingIntent
-import android.content.BroadcastReceiver
 import android.content.Context
-import android.content.Intent
-import android.content.IntentFilter
 import android.content.res.Configuration
 import android.graphics.Color
 import android.os.Build
 import android.os.Environment
-import android.webkit.WebView
-import androidx.core.app.NotificationManagerCompat
-import androidx.core.content.getSystemService
 import androidx.lifecycle.Lifecycle
 import androidx.lifecycle.LifecycleObserver
 import androidx.lifecycle.OnLifecycleEvent
 import androidx.lifecycle.ProcessLifecycleOwner
-import androidx.lifecycle.lifecycleScope
 import androidx.multidex.MultiDex
-import coil.ImageLoader
-import coil.ImageLoaderFactory
-import coil.decode.GifDecoder
-import coil.decode.ImageDecoderDecoder
 import com.elvishew.xlog.LogConfiguration
 import com.elvishew.xlog.LogLevel
 import com.elvishew.xlog.XLog
@@ -35,34 +22,28 @@ import com.elvishew.xlog.printer.file.naming.DateFileNameGenerator
 import com.google.android.gms.common.GooglePlayServicesNotAvailableException
 import com.google.android.gms.common.GooglePlayServicesRepairableException
 import com.google.android.gms.security.ProviderInstaller
+import com.google.firebase.analytics.FirebaseAnalytics
 import com.google.firebase.analytics.ktx.analytics
 import com.google.firebase.ktx.Firebase
 import com.ms_square.debugoverlay.DebugOverlay
 import com.ms_square.debugoverlay.modules.FpsModule
-import eu.kanade.tachiyomi.data.coil.ByteBufferFetcher
-import eu.kanade.tachiyomi.data.coil.MangaCoverFetcher
 import eu.kanade.tachiyomi.data.notification.Notifications
 import eu.kanade.tachiyomi.data.preference.PreferencesHelper
-import eu.kanade.tachiyomi.network.NetworkHelper
 import eu.kanade.tachiyomi.ui.security.SecureActivityDelegate
 import eu.kanade.tachiyomi.util.system.LocaleHelper
-import eu.kanade.tachiyomi.util.system.notification
 import exh.debug.DebugToggles
 import exh.log.CrashlyticsPrinter
 import exh.log.EHDebugModeOverlay
 import exh.log.EHLogLevel
 import exh.log.EnhancedFilePrinter
-import exh.log.XLogTree
-import exh.log.xLogD
-import exh.log.xLogE
 import exh.syDebugVersion
 import io.realm.Realm
-import kotlinx.coroutines.flow.launchIn
+import io.realm.RealmConfiguration
-import kotlinx.coroutines.flow.onEach
+import kotlinx.coroutines.GlobalScope
+import kotlinx.coroutines.launch
 import org.conscrypt.Conscrypt
 import timber.log.Timber
 import uy.kohesive.injekt.Injekt
-import uy.kohesive.injekt.api.get
 import uy.kohesive.injekt.injectLazy
 import java.io.File
 import java.security.NoSuchAlgorithmException
@@ -70,20 +51,20 @@ import java.security.Security
 import java.text.SimpleDateFormat
 import java.util.Locale
 import javax.net.ssl.SSLContext
+import kotlin.concurrent.thread
 import kotlin.time.ExperimentalTime
 import kotlin.time.days
 
-open class App : Application(), LifecycleObserver, ImageLoaderFactory {
+open class App : Application(), LifecycleObserver {
 
     private val preferences: PreferencesHelper by injectLazy()
 
-    private val disableIncognitoReceiver = DisableIncognitoReceiver()
+    private lateinit var firebaseAnalytics: FirebaseAnalytics
 
     override fun onCreate() {
         super.onCreate()
-        // if (BuildConfig.DEBUG) Timber.plant(Timber.DebugTree())
+        if (BuildConfig.DEBUG) Timber.plant(Timber.DebugTree())
         setupExhLogging() // EXH logging
-        Timber.plant(XLogTree()) // SY Redirect Timber to XLog
         if (!BuildConfig.DEBUG) addAnalytics()
 
         workaroundAndroid7BrokenSSL()
@@ -93,16 +74,11 @@ open class App : Application(), LifecycleObserver, ImageLoaderFactory {
             Security.insertProviderAt(Conscrypt.newProvider(), 1)
         }
 
-        // Avoid potential crashes
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
-            val process = getProcessName()
-            if (packageName != process) WebView.setDataDirectorySuffix(process)
-        }
-
         Injekt.importModule(AppModule(this))
 
         setupNotificationChannels()
         Realm.init(this)
+        GlobalScope.launch { deleteOldMetadataRealm() } // Delete old metadata DB (EH)
         if ((BuildConfig.DEBUG || BuildConfig.BUILD_TYPE == "releaseTest") && DebugToggles.ENABLE_DEBUG_OVERLAY.enabled) {
             setupDebugOverlay()
         }
@@ -110,34 +86,6 @@ open class App : Application(), LifecycleObserver, ImageLoaderFactory {
         LocaleHelper.updateConfiguration(this, resources.configuration)
 
         ProcessLifecycleOwner.get().lifecycle.addObserver(this)
-
-        // Show notification to disable Incognito Mode when it's enabled
-        preferences.incognitoMode().asFlow()
-            .onEach { enabled ->
-                val notificationManager = NotificationManagerCompat.from(this)
-                if (enabled) {
-                    disableIncognitoReceiver.register()
-                    val notification = notification(Notifications.CHANNEL_INCOGNITO_MODE) {
-                        setContentTitle(getString(R.string.pref_incognito_mode))
-                        setContentText(getString(R.string.notification_incognito_text))
-                        setSmallIcon(R.drawable.ic_glasses_black_24dp)
-                        setOngoing(true)
-
-                        val pendingIntent = PendingIntent.getBroadcast(
-                            this@App,
-                            0,
-                            Intent(ACTION_DISABLE_INCOGNITO_MODE),
-                            PendingIntent.FLAG_ONE_SHOT
-                        )
-                        setContentIntent(pendingIntent)
-                    }
-                    notificationManager.notify(Notifications.ID_INCOGNITO_MODE, notification)
-                } else {
-                    disableIncognitoReceiver.unregister()
-                    notificationManager.cancel(Notifications.ID_INCOGNITO_MODE)
-                }
-            }
-            .launchIn(ProcessLifecycleOwner.get().lifecycleScope)
     }
 
     override fun attachBaseContext(base: Context) {
@@ -150,23 +98,6 @@ open class App : Application(), LifecycleObserver, ImageLoaderFactory {
         LocaleHelper.updateConfiguration(this, newConfig, true)
     }
 
-    override fun newImageLoader(): ImageLoader {
-        return ImageLoader.Builder(this).apply {
-            componentRegistry {
-                if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
-                    add(ImageDecoderDecoder(this@App))
-                } else {
-                    add(GifDecoder())
-                }
-                add(ByteBufferFetcher())
-                add(MangaCoverFetcher())
-            }
-            okHttpClient(Injekt.get<NetworkHelper>().coilClient)
-            crossfade(300)
-            allowRgb565(getSystemService<ActivityManager>()!!.isLowRamDevice)
-        }.build()
-    }
-
     private fun workaroundAndroid7BrokenSSL() {
         if (Build.VERSION.SDK_INT == Build.VERSION_CODES.N ||
             Build.VERSION.SDK_INT == Build.VERSION_CODES.N_MR1
@@ -174,22 +105,23 @@ open class App : Application(), LifecycleObserver, ImageLoaderFactory {
             try {
                 SSLContext.getInstance("TLSv1.2")
             } catch (e: NoSuchAlgorithmException) {
-                xLogE("Could not install Android 7 broken SSL workaround!", e)
+                XLog.tag("Init").e("Could not install Android 7 broken SSL workaround!", e)
             }
 
             try {
                 ProviderInstaller.installIfNeeded(applicationContext)
             } catch (e: GooglePlayServicesRepairableException) {
-                xLogE("Could not install Android 7 broken SSL workaround!", e)
+                XLog.tag("Init").e("Could not install Android 7 broken SSL workaround!", e)
             } catch (e: GooglePlayServicesNotAvailableException) {
-                xLogE("Could not install Android 7 broken SSL workaround!", e)
+                XLog.tag("Init").e("Could not install Android 7 broken SSL workaround!", e)
             }
         }
     }
 
     private fun addAnalytics() {
+        firebaseAnalytics = Firebase.analytics
         if (syDebugVersion != "0") {
-            Firebase.analytics.setUserProperty("preview_version", syDebugVersion)
+            firebaseAnalytics.setUserProperty("preview_version", syDebugVersion)
         }
     }
 
@@ -205,13 +137,36 @@ open class App : Application(), LifecycleObserver, ImageLoaderFactory {
         Notifications.createChannels(this)
     }
 
+    // EXH
+    private fun deleteOldMetadataRealm() {
+        val config = RealmConfiguration.Builder()
+            .name("gallery-metadata.realm")
+            .schemaVersion(3)
+            .deleteRealmIfMigrationNeeded()
+            .build()
+        Realm.deleteRealm(config)
+
+        // Delete old paper db files
+        listOf(
+            File(filesDir, "gallery-ex"),
+            File(filesDir, "gallery-perveden"),
+            File(filesDir, "gallery-nhentai")
+        ).forEach {
+            if (it.exists()) {
+                thread {
+                    it.deleteRecursively()
+                }
+            }
+        }
+    }
+
     // EXH
     private fun setupExhLogging() {
         EHLogLevel.init(this)
 
         val logLevel = when {
-            EHLogLevel.shouldLog(EHLogLevel.EXTREME) -> LogLevel.ALL
+            EHLogLevel.shouldLog(EHLogLevel.EXTRA) -> LogLevel.ALL
-            EHLogLevel.shouldLog(EHLogLevel.EXTRA) || BuildConfig.DEBUG -> LogLevel.DEBUG
+            BuildConfig.DEBUG -> LogLevel.DEBUG
             else -> LogLevel.WARN
         }
 
@@ -233,8 +188,9 @@ open class App : Application(), LifecycleObserver, ImageLoaderFactory {
 
         @OptIn(ExperimentalTime::class)
         printers += EnhancedFilePrinter
-            .Builder(logFolder.absolutePath) {
+            .Builder(logFolder.absolutePath)
-                fileNameGenerator = object : DateFileNameGenerator() {
+            .fileNameGenerator(
+                object : DateFileNameGenerator() {
                     override fun generateFileName(logLevel: Int, timestamp: Long): String {
                         return super.generateFileName(
                             logLevel,
@@ -242,12 +198,13 @@ open class App : Application(), LifecycleObserver, ImageLoaderFactory {
                         ) + "-${BuildConfig.BUILD_TYPE}.log"
                     }
                 }
-                flattener { timeMillis, level, tag, message ->
+            )
-                    "${dateFormat.format(timeMillis)} ${LogLevel.getShortLevelName(level)}/$tag: $message"
+            .flattener { timeMillis, level, tag, message ->
-                }
+                "${dateFormat.format(timeMillis)} ${LogLevel.getShortLevelName(level)}/$tag: $message"
-                cleanStrategy = FileLastModifiedCleanStrategy(7.days.toLongMilliseconds())
-                backupStrategy = NeverBackupStrategy()
             }
+            .cleanStrategy(FileLastModifiedCleanStrategy(7.days.toLongMilliseconds()))
+            .backupStrategy(NeverBackupStrategy())
+            .build()
 
         // Install Crashlytics in prod
         if (!BuildConfig.DEBUG) {
@@ -259,8 +216,8 @@ open class App : Application(), LifecycleObserver, ImageLoaderFactory {
             *printers.toTypedArray()
         )
 
-        xLogD("Application booting...")
+        XLog.tag("Init").d("Application booting...")
-        xLogD(
+        XLog.tag("Init").disableStackTrace().d(
             "App version: ${BuildConfig.VERSION_NAME} (${BuildConfig.FLAVOR}, ${BuildConfig.COMMIT_SHA}, ${BuildConfig.VERSION_CODE})\n" +
                 "Preview build: $syDebugVersion\n" +
                 "Android version: ${Build.VERSION.RELEASE} (SDK ${Build.VERSION.SDK_INT}) \n" +
@@ -285,33 +242,7 @@ open class App : Application(), LifecycleObserver, ImageLoaderFactory {
                 .install()
         } catch (e: IllegalStateException) {
             // Crashes if app is in background
-            xLogE("Failed to initialize debug overlay, app in background?", e)
+            XLog.tag("Init").e("Failed to initialize debug overlay, app in background?", e)
         }
     }
-
-    private inner class DisableIncognitoReceiver : BroadcastReceiver() {
-        private var registered = false
-
-        override fun onReceive(context: Context, intent: Intent) {
-            preferences.incognitoMode().set(false)
-        }
-
-        fun register() {
-            if (!registered) {
-                registerReceiver(this, IntentFilter(ACTION_DISABLE_INCOGNITO_MODE))
-                registered = true
-            }
-        }
-
-        fun unregister() {
-            if (registered) {
-                unregisterReceiver(this)
-                registered = false
-            }
-        }
-    }
-
-    companion object {
-        private const val ACTION_DISABLE_INCOGNITO_MODE = "tachi.action.DISABLE_INCOGNITO_MODE"
-    }
 }

app/src/main/java/eu/kanade/tachiyomi/AppModule.kt

@@ -2,6 +2,7 @@ package eu.kanade.tachiyomi
 
 import android.app.Application
 import android.os.Handler
+import com.google.gson.Gson
 import eu.kanade.tachiyomi.data.cache.ChapterCache
 import eu.kanade.tachiyomi.data.cache.CoverCache
 import eu.kanade.tachiyomi.data.database.DatabaseHelper
@@ -43,6 +44,8 @@ class AppModule(val app: Application) : InjektModule {
 
         addSingletonFactory { TrackManager(app) }
 
+        addSingletonFactory { Gson() }
+
         addSingletonFactory { Json { ignoreUnknownKeys = true } }
 
         // SY -->

app/src/main/java/eu/kanade/tachiyomi/Migrations.kt

@@ -1,6 +1,5 @@
 package eu.kanade.tachiyomi
 
-import android.os.Build
 import androidx.core.content.edit
 import androidx.preference.PreferenceManager
 import eu.kanade.tachiyomi.data.backup.BackupCreatorJob
@@ -10,9 +9,7 @@ import eu.kanade.tachiyomi.data.preference.PreferencesHelper
 import eu.kanade.tachiyomi.data.track.TrackManager
 import eu.kanade.tachiyomi.data.updater.UpdaterJob
 import eu.kanade.tachiyomi.extension.ExtensionUpdateJob
-import eu.kanade.tachiyomi.network.PREF_DOH_CLOUDFLARE
 import eu.kanade.tachiyomi.ui.library.LibrarySort
-import eu.kanade.tachiyomi.ui.reader.setting.OrientationType
 import eu.kanade.tachiyomi.util.system.toast
 import eu.kanade.tachiyomi.widget.ExtendedNavigationView
 import uy.kohesive.injekt.Injekt
@@ -132,61 +129,6 @@ object Migrations {
                     context.toast(R.string.myanimelist_relogin)
                 }
             }
-            if (oldVersion < 57) {
-                // Migrate DNS over HTTPS setting
-                val prefs = PreferenceManager.getDefaultSharedPreferences(context)
-                val wasDohEnabled = prefs.getBoolean("enable_doh", false)
-                if (wasDohEnabled) {
-                    prefs.edit {
-                        putInt(PreferenceKeys.dohProvider, PREF_DOH_CLOUDFLARE)
-                        remove("enable_doh")
-                    }
-                }
-            }
-            if (oldVersion < 59) {
-                // Reset rotation to Free after replacing Lock
-                val prefs = PreferenceManager.getDefaultSharedPreferences(context)
-                if (prefs.contains("pref_rotation_type_key")) {
-                    prefs.edit {
-                        putInt("pref_rotation_type_key", 1)
-                    }
-                }
-
-                // Disable update check for Android 5.x users
-                if (BuildConfig.INCLUDE_UPDATER && Build.VERSION.SDK_INT <= Build.VERSION_CODES.M) {
-                    UpdaterJob.cancelTask(context)
-                }
-            }
-            if (oldVersion < 60) {
-                // Migrate Rotation and Viewer values to default values for viewer_flags
-                val prefs = PreferenceManager.getDefaultSharedPreferences(context)
-                val newOrientation = when (prefs.getInt("pref_rotation_type_key", 1)) {
-                    1 -> OrientationType.FREE.flagValue
-                    2 -> OrientationType.PORTRAIT.flagValue
-                    3 -> OrientationType.LANDSCAPE.flagValue
-                    4 -> OrientationType.LOCKED_PORTRAIT.flagValue
-                    5 -> OrientationType.LOCKED_LANDSCAPE.flagValue
-                    else -> OrientationType.FREE.flagValue
-                }
-
-                // Reading mode flag and prefValue is the same value
-                val newReadingMode = prefs.getInt("pref_default_viewer_key", 1)
-
-                prefs.edit {
-                    putInt("pref_default_orientation_type_key", newOrientation)
-                    remove("pref_rotation_type_key")
-                    putInt("pref_default_reading_mode_key", newReadingMode)
-                    remove("pref_default_viewer_key")
-                }
-            }
-            if (oldVersion < 61) {
-                // Handle removed every 1 or 2 hour library updates
-                val updateInterval = preferences.libraryUpdateInterval().get()
-                if (updateInterval == 1 || updateInterval == 2) {
-                    preferences.libraryUpdateInterval().set(3)
-                    LibraryUpdateJob.setupTask(context, 3)
-                }
-            }
             return true
         }
 

app/src/main/java/eu/kanade/tachiyomi/data/backup/AbstractBackupManager.kt

@@ -6,7 +6,6 @@ import eu.kanade.tachiyomi.data.database.DatabaseHelper
 import eu.kanade.tachiyomi.data.database.models.Chapter
 import eu.kanade.tachiyomi.data.database.models.Manga
 import eu.kanade.tachiyomi.data.database.models.toMangaInfo
-import eu.kanade.tachiyomi.data.library.CustomMangaManager
 import eu.kanade.tachiyomi.data.preference.PreferencesHelper
 import eu.kanade.tachiyomi.data.track.TrackManager
 import eu.kanade.tachiyomi.source.Source
@@ -24,10 +23,6 @@ abstract class AbstractBackupManager(protected val context: Context) {
     internal val trackManager: TrackManager by injectLazy()
     protected val preferences: PreferencesHelper by injectLazy()
 
-    // SY -->
-    protected val customMangaManager: CustomMangaManager by injectLazy()
-    // SY <--
-
     abstract fun createBackup(uri: Uri, flags: Int, isJob: Boolean): String?
 
     /**

app/src/main/java/eu/kanade/tachiyomi/data/backup/AbstractBackupRestore.kt

@@ -7,7 +7,6 @@ import eu.kanade.tachiyomi.data.database.DatabaseHelper
 import eu.kanade.tachiyomi.data.database.models.Chapter
 import eu.kanade.tachiyomi.data.database.models.Manga
 import eu.kanade.tachiyomi.data.database.models.Track
-import eu.kanade.tachiyomi.data.library.CustomMangaManager
 import eu.kanade.tachiyomi.data.track.TrackManager
 import eu.kanade.tachiyomi.source.Source
 import eu.kanade.tachiyomi.util.chapter.NoChaptersException
@@ -25,10 +24,6 @@ abstract class AbstractBackupRestore<T : AbstractBackupManager>(protected val co
     protected val db: DatabaseHelper by injectLazy()
     protected val trackManager: TrackManager by injectLazy()
 
-    // SY -->
-    protected val customMangaManager: CustomMangaManager by injectLazy()
-    // SY <--
-
     var job: Job? = null
 
     protected lateinit var backupManager: T

app/src/main/java/eu/kanade/tachiyomi/data/backup/BackupConst.kt

@@ -8,6 +8,7 @@ object BackupConst {
     const val EXTRA_URI = "$ID.$NAME.EXTRA_URI"
     const val EXTRA_FLAGS = "$ID.$NAME.EXTRA_FLAGS"
     const val EXTRA_MODE = "$ID.$NAME.EXTRA_MODE"
+    const val EXTRA_TYPE = "$ID.$NAME.EXTRA_TYPE"
 
     const val BACKUP_TYPE_LEGACY = 0
     const val BACKUP_TYPE_FULL = 1

app/src/main/java/eu/kanade/tachiyomi/data/backup/BackupCreateService.kt

@@ -10,6 +10,7 @@ import androidx.core.content.ContextCompat
 import androidx.core.net.toUri
 import com.hippo.unifile.UniFile
 import eu.kanade.tachiyomi.data.backup.full.FullBackupManager
+import eu.kanade.tachiyomi.data.backup.legacy.LegacyBackupManager
 import eu.kanade.tachiyomi.data.notification.Notifications
 import eu.kanade.tachiyomi.util.system.acquireWakeLock
 import eu.kanade.tachiyomi.util.system.isServiceRunning
@@ -29,14 +30,7 @@ class BackupCreateService : Service() {
         internal const val BACKUP_HISTORY_MASK = 0x4
         internal const val BACKUP_TRACK = 0x8
         internal const val BACKUP_TRACK_MASK = 0x8
-
+        internal const val BACKUP_ALL = 0xF
-        // SY -->
-        internal const val BACKUP_CUSTOM_INFO = 0x10
-        internal const val BACKUP_CUSTOM_INFO_MASK = 0x10
-        internal const val BACKUP_READ_MANGA = 0x20
-        internal const val BACKUP_READ_MANGA_MASK = 0x20
-        internal const val BACKUP_ALL = 0x3F
-        // SY <--
 
         /**
          * Returns the status of the service.
@@ -54,11 +48,12 @@ class BackupCreateService : Service() {
          * @param uri path of Uri
          * @param flags determines what to backup
          */
-        fun start(context: Context, uri: Uri, flags: Int) {
+        fun start(context: Context, uri: Uri, flags: Int, type: Int) {
             if (!isRunning(context)) {
                 val intent = Intent(context, BackupCreateService::class.java).apply {
                     putExtra(BackupConst.EXTRA_URI, uri)
                     putExtra(BackupConst.EXTRA_FLAGS, flags)
+                    putExtra(BackupConst.EXTRA_TYPE, type)
                 }
                 ContextCompat.startForegroundService(context, intent)
             }
@@ -106,11 +101,17 @@ class BackupCreateService : Service() {
         if (intent == null) return START_NOT_STICKY
 
         try {
-            val uri = intent.getParcelableExtra<Uri>(BackupConst.EXTRA_URI)!!
+            val uri = intent.getParcelableExtra<Uri>(BackupConst.EXTRA_URI)
             val backupFlags = intent.getIntExtra(BackupConst.EXTRA_FLAGS, 0)
-            val backupFileUri = FullBackupManager(this).createBackup(uri, backupFlags, false)?.toUri()
+            val backupType = intent.getIntExtra(BackupConst.EXTRA_TYPE, BackupConst.BACKUP_TYPE_LEGACY)
+            val backupManager = when (backupType) {
+                BackupConst.BACKUP_TYPE_FULL -> FullBackupManager(this)
+                else -> LegacyBackupManager(this)
+            }
+
+            val backupFileUri = backupManager.createBackup(uri, backupFlags, false)?.toUri()
             val unifile = UniFile.fromUri(this, backupFileUri)
-            notifier.showBackupComplete(unifile)
+            notifier.showBackupComplete(unifile, backupType == BackupConst.BACKUP_TYPE_LEGACY)
         } catch (e: Exception) {
             notifier.showBackupError(e.message)
         }

app/src/main/java/eu/kanade/tachiyomi/data/backup/BackupCreatorJob.kt

@@ -8,6 +8,7 @@ import androidx.work.WorkManager
 import androidx.work.Worker
 import androidx.work.WorkerParameters
 import eu.kanade.tachiyomi.data.backup.full.FullBackupManager
+import eu.kanade.tachiyomi.data.backup.legacy.LegacyBackupManager
 import eu.kanade.tachiyomi.data.preference.PreferencesHelper
 import uy.kohesive.injekt.Injekt
 import uy.kohesive.injekt.api.get
@@ -22,6 +23,9 @@ class BackupCreatorJob(private val context: Context, workerParams: WorkerParamet
         val flags = BackupCreateService.BACKUP_ALL
         return try {
             FullBackupManager(context).createBackup(uri, flags, true)
+            if (preferences.createLegacyBackup().get()) {
+                LegacyBackupManager(context).createBackup(uri, flags, true)
+            }
             Result.success()
         } catch (e: Exception) {
             Result.failure()

app/src/main/java/eu/kanade/tachiyomi/data/backup/BackupNotifier.kt

@@ -24,7 +24,6 @@ class BackupNotifier(private val context: Context) {
         setSmallIcon(R.drawable.ic_tachi)
         setAutoCancel(false)
         setOngoing(true)
-        setOnlyAlertOnce(true)
     }
 
     private val completeNotificationBuilder = context.notificationBuilder(Notifications.CHANNEL_BACKUP_RESTORE_COMPLETE) {
@@ -42,6 +41,7 @@ class BackupNotifier(private val context: Context) {
             setContentTitle(context.getString(R.string.creating_backup))
 
             setProgress(0, 0, true)
+            setOnlyAlertOnce(true)
         }
 
         builder.show(Notifications.ID_BACKUP_PROGRESS)
@@ -60,7 +60,7 @@ class BackupNotifier(private val context: Context) {
         }
     }
 
-    fun showBackupComplete(unifile: UniFile) {
+    fun showBackupComplete(unifile: UniFile, isLegacyFormat: Boolean) {
         context.notificationManager.cancel(Notifications.ID_BACKUP_PROGRESS)
 
         with(completeNotificationBuilder) {
@@ -73,7 +73,7 @@ class BackupNotifier(private val context: Context) {
             addAction(
                 R.drawable.ic_share_24dp,
                 context.getString(R.string.action_share),
-                NotificationReceiver.shareBackupPendingBroadcast(context, unifile.uri, Notifications.ID_BACKUP_COMPLETE)
+                NotificationReceiver.shareBackupPendingBroadcast(context, unifile.uri, isLegacyFormat, Notifications.ID_BACKUP_COMPLETE)
             )
 
             show(Notifications.ID_BACKUP_COMPLETE)
@@ -141,7 +141,7 @@ class BackupNotifier(private val context: Context) {
 
                 addAction(
                     R.drawable.ic_folder_24dp,
-                    context.getString(R.string.action_show_errors),
+                    context.getString(R.string.action_open_log),
                     NotificationReceiver.openErrorLogPendingActivity(context, uri)
                 )
             }

app/src/main/java/eu/kanade/tachiyomi/data/backup/BackupRestoreService.kt

@@ -43,11 +43,12 @@ class BackupRestoreService : Service() {
          * @param context context of application
          * @param uri path of Uri
          */
-        fun start(context: Context, uri: Uri, mode: Int) {
+        fun start(context: Context, uri: Uri, mode: Int, online: Boolean?) {
             if (!isRunning(context)) {
                 val intent = Intent(context, BackupRestoreService::class.java).apply {
                     putExtra(BackupConst.EXTRA_URI, uri)
                     putExtra(BackupConst.EXTRA_MODE, mode)
+                    online?.let { putExtra(BackupConst.EXTRA_TYPE, it) }
                 }
                 ContextCompat.startForegroundService(context, intent)
             }
@@ -118,12 +119,13 @@ class BackupRestoreService : Service() {
     override fun onStartCommand(intent: Intent?, flags: Int, startId: Int): Int {
         val uri = intent?.getParcelableExtra<Uri>(BackupConst.EXTRA_URI) ?: return START_NOT_STICKY
         val mode = intent.getIntExtra(BackupConst.EXTRA_MODE, BackupConst.BACKUP_TYPE_FULL)
+        val online = intent.getBooleanExtra(BackupConst.EXTRA_TYPE, true)
 
         // Cancel any previous job if needed.
         backupRestore?.job?.cancel()
 
         backupRestore = when (mode) {
-            BackupConst.BACKUP_TYPE_FULL -> FullBackupRestore(this, notifier)
+            BackupConst.BACKUP_TYPE_FULL -> FullBackupRestore(this, notifier, online)
             else -> LegacyBackupRestore(this, notifier)
         }
 

app/src/main/java/eu/kanade/tachiyomi/data/backup/full/FullBackupManager.kt

@@ -8,12 +8,8 @@ import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_CATE
 import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_CATEGORY_MASK
 import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_CHAPTER
 import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_CHAPTER_MASK
-import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_CUSTOM_INFO
-import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_CUSTOM_INFO_MASK
 import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_HISTORY
 import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_HISTORY_MASK
-import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_READ_MANGA
-import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_READ_MANGA_MASK
 import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_TRACK
 import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_TRACK_MASK
 import eu.kanade.tachiyomi.data.backup.full.models.Backup
@@ -33,8 +29,11 @@ import eu.kanade.tachiyomi.data.database.models.History
 import eu.kanade.tachiyomi.data.database.models.Manga
 import eu.kanade.tachiyomi.data.database.models.MangaCategory
 import eu.kanade.tachiyomi.data.database.models.Track
+import eu.kanade.tachiyomi.data.database.models.toMangaInfo
+import eu.kanade.tachiyomi.source.Source
+import eu.kanade.tachiyomi.source.model.toSManga
 import eu.kanade.tachiyomi.source.online.MetadataSource
-import eu.kanade.tachiyomi.util.lang.launchIO
+import eu.kanade.tachiyomi.source.online.all.MergedSource
 import exh.metadata.metadata.base.getFlatMetadataForManga
 import exh.metadata.metadata.base.insertFlatMetadataAsync
 import exh.savedsearches.JsonSavedSearch
@@ -66,11 +65,7 @@ class FullBackupManager(context: Context) : AbstractBackupManager(context) {
         var backup: Backup? = null
 
         databaseHelper.inTransaction {
-            val databaseManga = getFavoriteManga() /* SY --> */ + if (flags and BACKUP_READ_MANGA_MASK == BACKUP_READ_MANGA) {
+            val databaseManga = getFavoriteManga() /* SY --> */ + getReadManga() + getMergedManga().filterNot { it.source == MERGED_SOURCE_ID } /* SY <-- */
-                getReadManga()
-            } else {
-                emptyList()
-            } + getMergedManga() /* SY <-- */
 
             backup = Backup(
                 backupManga(databaseManga, flags),
@@ -169,7 +164,7 @@ class FullBackupManager(context: Context) : AbstractBackupManager(context) {
      */
     private fun backupMangaObject(manga: Manga, options: Int): BackupManga {
         // Entry for this manga
-        val mangaObject = BackupManga.copyFrom(manga /* SY --> */, if (options and BACKUP_CUSTOM_INFO_MASK == BACKUP_CUSTOM_INFO) customMangaManager else null /* SY <-- */)
+        val mangaObject = BackupManga.copyFrom(manga)
 
         // SY -->
         if (manga.source == MERGED_SOURCE_ID) {
@@ -242,13 +237,24 @@ class FullBackupManager(context: Context) : AbstractBackupManager(context) {
     /**
      * Fetches manga information
      *
+     * @param source source of manga
      * @param manga manga that needs updating
      * @return Updated manga info.
      */
-    fun restoreManga(manga: Manga): Manga {
+    suspend fun restoreMangaFetch(source: Source?, manga: Manga, online: Boolean): Manga {
-        return manga.also {
+        return if (online && source != null /* SY --> */ && source !is MergedSource /* SY <-- */) {
-            it.initialized = it.description != null
+            val networkManga = source.getMangaDetails(manga.toMangaInfo())
-            it.id = insertManga(it)
+            manga.also {
+                it.copyFrom(networkManga.toSManga())
+                it.favorite = manga.favorite
+                it.initialized = true
+                it.id = insertManga(manga)
+            }
+        } else {
+            manga.also {
+                it.initialized = it.description != null
+                it.id = insertManga(it)
+            }
         }
     }
 
@@ -357,26 +363,29 @@ class FullBackupManager(context: Context) : AbstractBackupManager(context) {
         val trackToUpdate = mutableListOf<Track>()
 
         tracks.forEach { track ->
-            var isInDatabase = false
+            val service = trackManager.getService(track.sync_id)
-            for (dbTrack in dbTracks) {
+            if (service != null && service.isLogged) {
-                if (track.sync_id == dbTrack.sync_id) {
+                var isInDatabase = false
-                    // The sync is already in the db, only update its fields
+                for (dbTrack in dbTracks) {
-                    if (track.media_id != dbTrack.media_id) {
+                    if (track.sync_id == dbTrack.sync_id) {
-                        dbTrack.media_id = track.media_id
+                        // The sync is already in the db, only update its fields
+                        if (track.media_id != dbTrack.media_id) {
+                            dbTrack.media_id = track.media_id
+                        }
+                        if (track.library_id != dbTrack.library_id) {
+                            dbTrack.library_id = track.library_id
+                        }
+                        dbTrack.last_chapter_read = max(dbTrack.last_chapter_read, track.last_chapter_read)
+                        isInDatabase = true
+                        trackToUpdate.add(dbTrack)
+                        break
                     }
-                    if (track.library_id != dbTrack.library_id) {
-                        dbTrack.library_id = track.library_id
-                    }
-                    dbTrack.last_chapter_read = max(dbTrack.last_chapter_read, track.last_chapter_read)
-                    isInDatabase = true
-                    trackToUpdate.add(dbTrack)
-                    break
                 }
-            }
+                if (!isInDatabase) {
-            if (!isInDatabase) {
+                    // Insert new sync. Let the db assign the id
-                // Insert new sync. Let the db assign the id
+                    track.id = null
-                track.id = null
+                    trackToUpdate.add(track)
-                trackToUpdate.add(track)
+                }
             }
         }
         // Update database
@@ -385,7 +394,47 @@ class FullBackupManager(context: Context) : AbstractBackupManager(context) {
         }
     }
 
-    internal fun restoreChaptersForManga(manga: Manga, chapters: List<Chapter>) {
+    /**
+     * Restore the chapters for manga if chapters already in database
+     *
+     * @param manga manga of chapters
+     * @param chapters list containing chapters that get restored
+     * @return boolean answering if chapter fetch is not needed
+     */
+    internal fun restoreChaptersForManga(manga: Manga, chapters: List<Chapter>): Boolean {
+        val dbChapters = databaseHelper.getChapters(manga).executeAsBlocking()
+
+        // Return if fetch is needed
+        if (dbChapters.isEmpty() || dbChapters.size < chapters.size) {
+            return false
+        }
+
+        chapters.forEach { chapter ->
+            val dbChapter = dbChapters.find { it.url == chapter.url }
+            if (dbChapter != null) {
+                chapter.id = dbChapter.id
+                chapter.copyFrom(dbChapter)
+                if (dbChapter.read && !chapter.read) {
+                    chapter.read = dbChapter.read
+                    chapter.last_page_read = dbChapter.last_page_read
+                } else if (chapter.last_page_read == 0 && dbChapter.last_page_read != 0) {
+                    chapter.last_page_read = dbChapter.last_page_read
+                }
+                if (!chapter.bookmark && dbChapter.bookmark) {
+                    chapter.bookmark = dbChapter.bookmark
+                }
+            }
+
+            chapter.manga_id = manga.id
+        }
+
+        // Filter the chapters that couldn't be found.
+        updateChapters(chapters.filter { it.id != null })
+
+        return true
+    }
+
+    internal fun restoreChaptersForMangaOffline(manga: Manga, chapters: List<Chapter>) {
         val dbChapters = databaseHelper.getChapters(manga).executeAsBlocking()
 
         chapters.forEach { chapter ->
@@ -478,9 +527,8 @@ class FullBackupManager(context: Context) : AbstractBackupManager(context) {
         }
     }
 
-    internal fun restoreFlatMetadata(manga: Manga, backupFlatMetadata: BackupFlatMetadata) {
+    internal suspend fun restoreFlatMetadata(manga: Manga, backupFlatMetadata: BackupFlatMetadata) {
-        val mangaId = manga.id ?: return
+        manga.id?.let { mangaId ->
-        launchIO {
             databaseHelper.getFlatMetadataForManga(mangaId).executeOnIO().let {
                 if (it == null) {
                     val flatMetadata = backupFlatMetadata.getFlatMetadata(mangaId)

app/src/main/java/eu/kanade/tachiyomi/data/backup/full/FullBackupRestore.kt

@@ -15,7 +15,8 @@ import eu.kanade.tachiyomi.data.backup.full.models.BackupSerializer
 import eu.kanade.tachiyomi.data.database.models.Chapter
 import eu.kanade.tachiyomi.data.database.models.Manga
 import eu.kanade.tachiyomi.data.database.models.Track
-import eu.kanade.tachiyomi.data.library.CustomMangaManager
+import eu.kanade.tachiyomi.source.Source
+import eu.kanade.tachiyomi.source.online.all.MergedSource
 import exh.EXHMigrations
 import exh.source.MERGED_SOURCE_ID
 import okio.buffer
@@ -23,7 +24,7 @@ import okio.gzip
 import okio.source
 import java.util.Date
 
-class FullBackupRestore(context: Context, notifier: BackupNotifier) : AbstractBackupRestore<FullBackupManager>(context, notifier) {
+class FullBackupRestore(context: Context, notifier: BackupNotifier, private val online: Boolean) : AbstractBackupRestore<FullBackupManager>(context, notifier) {
 
     override suspend fun performRestore(uri: Uri): Boolean {
         // SY -->
@@ -56,11 +57,9 @@ class FullBackupRestore(context: Context, notifier: BackupNotifier) : AbstractBa
                 return false
             }
 
-            restoreManga(it, backup.backupCategories)
+            restoreManga(it, backup.backupCategories, online)
         }
 
-        // TODO: optionally trigger online library + tracker update
-
         return true
     }
 
@@ -82,8 +81,8 @@ class FullBackupRestore(context: Context, notifier: BackupNotifier) : AbstractBa
     }
     // SY <--
 
-    private fun restoreManga(backupManga: BackupManga, backupCategories: List<BackupCategory>) {
+    private suspend fun restoreManga(backupManga: BackupManga, backupCategories: List<BackupCategory>, online: Boolean) {
-        val manga = backupManga.getMangaImpl()
+        var manga = backupManga.getMangaImpl()
         val chapters = backupManga.getChaptersImpl()
         val categories = backupManga.categories
         val history = backupManga.history
@@ -91,17 +90,22 @@ class FullBackupRestore(context: Context, notifier: BackupNotifier) : AbstractBa
         // SY -->
         val mergedMangaReferences = backupManga.mergedMangaReferences
         val flatMetadata = backupManga.flatMetadata
-        val customManga = backupManga.getCustomMangaInfo()
         // SY <--
 
         // SY -->
-        EXHMigrations.migrateBackupEntry(manga)
+        manga = EXHMigrations.migrateBackupEntry(manga)
         // SY <--
 
+        val source = backupManager.sourceManager.get(manga.source)
+        val sourceName = sourceMapping[manga.source] ?: manga.source.toString()
+
         try {
-            restoreMangaData(manga, chapters, categories, history, tracks, backupCategories/* SY --> */, mergedMangaReferences, flatMetadata, customManga/* SY <-- */)
+            if (source != null || !online) {
+                restoreMangaData(manga, source, chapters, categories, history, tracks, backupCategories, mergedMangaReferences, flatMetadata, online)
+            } else {
+                errors.add(Date() to "${manga.title} [$sourceName]: ${context.getString(R.string.source_not_found_name, sourceName)}")
+            }
         } catch (e: Exception) {
-            val sourceName = sourceMapping[manga.source] ?: manga.source.toString()
             errors.add(Date() to "${manga.title} [$sourceName]: ${e.message}")
         }
 
@@ -113,35 +117,35 @@ class FullBackupRestore(context: Context, notifier: BackupNotifier) : AbstractBa
      * Returns a manga restore observable
      *
      * @param manga manga data from json
+     * @param source source to get manga data from
      * @param chapters chapters data from json
      * @param categories categories data from json
      * @param history history data from json
      * @param tracks tracking data from json
      */
-    private fun restoreMangaData(
+    private suspend fun restoreMangaData(
         manga: Manga,
+        source: Source?,
         chapters: List<Chapter>,
         categories: List<Int>,
         history: List<BackupHistory>,
         tracks: List<Track>,
         backupCategories: List<BackupCategory>,
-        // SY -->
         mergedMangaReferences: List<BackupMergedMangaReference>,
         flatMetadata: BackupFlatMetadata?,
-        customManga: CustomMangaManager.MangaJson?,
+        online: Boolean
-        // SY -->
     ) {
+        val dbManga = backupManager.getMangaFromDatabase(manga)
+
         db.inTransaction {
-            val dbManga = backupManager.getMangaFromDatabase(manga)
             if (dbManga == null) {
                 // Manga not in database
-                restoreMangaFetch(manga, chapters, categories, history, tracks, backupCategories/* SY --> */, mergedMangaReferences, flatMetadata, customManga/* SY <-- */)
+                restoreMangaFetch(source, manga, chapters, categories, history, tracks, backupCategories, mergedMangaReferences, flatMetadata, online)
-            } else {
+            } else { // Manga in database
-                // Manga in database
                 // Copy information from manga already in database
                 backupManager.restoreMangaNoFetch(manga, dbManga)
                 // Fetch rest of manga information
-                restoreMangaNoFetch(manga, chapters, categories, history, tracks, backupCategories/* SY --> */, mergedMangaReferences, flatMetadata, customManga/* SY <-- */)
+                restoreMangaNoFetch(source, manga, chapters, categories, history, tracks, backupCategories, mergedMangaReferences, flatMetadata, online)
             }
         }
     }
@@ -153,60 +157,66 @@ class FullBackupRestore(context: Context, notifier: BackupNotifier) : AbstractBa
      * @param chapters chapters of manga that needs updating
      * @param categories categories that need updating
      */
-    private fun restoreMangaFetch(
+    private suspend fun restoreMangaFetch(
+        source: Source?,
         manga: Manga,
         chapters: List<Chapter>,
         categories: List<Int>,
         history: List<BackupHistory>,
         tracks: List<Track>,
         backupCategories: List<BackupCategory>,
-        // SY -->
         mergedMangaReferences: List<BackupMergedMangaReference>,
         flatMetadata: BackupFlatMetadata?,
-        customManga: CustomMangaManager.MangaJson?,
+        online: Boolean
-        // SY <--
     ) {
         try {
-            val fetchedManga = backupManager.restoreManga(manga)
+            val fetchedManga = backupManager.restoreMangaFetch(source, manga, online)
             fetchedManga.id ?: return
-            backupManager.restoreChaptersForManga(fetchedManga, chapters)
 
-            restoreExtraForManga(fetchedManga, categories, history, tracks, backupCategories /* SY --> */, mergedMangaReferences, flatMetadata, customManga/* SY <-- */)
+            if (online && source != null) {
+                // SY -->
+                if (source !is MergedSource) {
+                    updateChapters(source, fetchedManga, chapters)
+                }
+                // SY <--
+            } else {
+                backupManager.restoreChaptersForMangaOffline(fetchedManga, chapters)
+            }
+
+            restoreExtraForManga(fetchedManga, categories, history, tracks, backupCategories, mergedMangaReferences, flatMetadata)
+
+            updateTracking(fetchedManga, tracks)
         } catch (e: Exception) {
             errors.add(Date() to "${manga.title} - ${e.message}")
         }
     }
 
-    private fun restoreMangaNoFetch(
+    private suspend fun restoreMangaNoFetch(
+        source: Source?,
         backupManga: Manga,
         chapters: List<Chapter>,
         categories: List<Int>,
         history: List<BackupHistory>,
         tracks: List<Track>,
         backupCategories: List<BackupCategory>,
-        // SY -->
         mergedMangaReferences: List<BackupMergedMangaReference>,
         flatMetadata: BackupFlatMetadata?,
-        customManga: CustomMangaManager.MangaJson?,
+        online: Boolean
-        // SY <--
     ) {
-        backupManager.restoreChaptersForManga(backupManga, chapters)
+        if (online && source != null) {
+            if (/* SY --> */ source !is MergedSource && /* SY <-- */ !backupManager.restoreChaptersForManga(backupManga, chapters)) {
+                updateChapters(source, backupManga, chapters)
+            }
+        } else {
+            backupManager.restoreChaptersForMangaOffline(backupManga, chapters)
+        }
 
-        restoreExtraForManga(backupManga, categories, history, tracks, backupCategories/* SY --> */, mergedMangaReferences, flatMetadata, customManga/* SY <-- */)
+        restoreExtraForManga(backupManga, categories, history, tracks, backupCategories, mergedMangaReferences, flatMetadata)
+
+        updateTracking(backupManga, tracks)
     }
 
-    private fun restoreExtraForManga(
+    private suspend fun restoreExtraForManga(manga: Manga, categories: List<Int>, history: List<BackupHistory>, tracks: List<Track>, backupCategories: List<BackupCategory>, mergedMangaReferences: List<BackupMergedMangaReference>, flatMetadata: BackupFlatMetadata?) {
-        manga: Manga,
-        categories: List<Int>,
-        history: List<BackupHistory>,
-        tracks: List<Track>,
-        backupCategories: List<BackupCategory>,
-        // SY -->
-        mergedMangaReferences: List<BackupMergedMangaReference>,
-        flatMetadata: BackupFlatMetadata?,
-        customManga: CustomMangaManager.MangaJson?,
-        // SY <--
-    ) {
         // Restore categories
         backupManager.restoreCategoriesForManga(manga, categories, backupCategories)
 
@@ -222,10 +232,6 @@ class FullBackupRestore(context: Context, notifier: BackupNotifier) : AbstractBa
 
         // Restore flat metadata for metadata sources
         flatMetadata?.let { backupManager.restoreFlatMetadata(manga, it) }
-
-        // Restore Custom Info
-        customManga?.id = manga.id!!
-        customManga?.let { customMangaManager.saveMangaInfo(it) }
         // SY <--
     }
 }

app/src/main/java/eu/kanade/tachiyomi/data/backup/full/models/BackupManga.kt

@@ -4,7 +4,6 @@ import eu.kanade.tachiyomi.data.database.models.ChapterImpl
 import eu.kanade.tachiyomi.data.database.models.Manga
 import eu.kanade.tachiyomi.data.database.models.MangaImpl
 import eu.kanade.tachiyomi.data.database.models.TrackImpl
-import eu.kanade.tachiyomi.data.library.CustomMangaManager
 import kotlinx.serialization.Serializable
 import kotlinx.serialization.protobuf.ProtoNumber
 
@@ -26,7 +25,7 @@ data class BackupManga(
     // @ProtoNumber(11) val lastUpdate: Long = 0, 1.x value, not used in 0.x
     // @ProtoNumber(12) val lastInit: Long = 0, 1.x value, not used in 0.x
     @ProtoNumber(13) var dateAdded: Long = 0,
-    @ProtoNumber(14) var viewer: Int = 0, // Replaced by viewer_flags
+    @ProtoNumber(14) var viewer: Int = 0,
     // @ProtoNumber(15) val flags: Int = 0, 1.x value, not used in 0.x
     @ProtoNumber(16) var chapters: List<BackupChapter> = emptyList(),
     @ProtoNumber(17) var categories: List<Int> = emptyList(),
@@ -35,22 +34,9 @@ data class BackupManga(
     @ProtoNumber(100) var favorite: Boolean = true,
     @ProtoNumber(101) var chapterFlags: Int = 0,
     @ProtoNumber(102) var history: List<BackupHistory> = emptyList(),
-    @ProtoNumber(103) var viewer_flags: Int? = null,
-
     // SY specific values
     @ProtoNumber(600) var mergedMangaReferences: List<BackupMergedMangaReference> = emptyList(),
-    @ProtoNumber(601) var flatMetadata: BackupFlatMetadata? = null,
+    @ProtoNumber(601) var flatMetadata: BackupFlatMetadata? = null
-    @ProtoNumber(602) var customStatus: Int = 0,
-
-    // J2K specific values
-    @ProtoNumber(800) var customTitle: String? = null,
-    @ProtoNumber(801) var customArtist: String? = null,
-    @ProtoNumber(802) var customAuthor: String? = null,
-    @ProtoNumber(803) var customDescription: String? = null,
-    @ProtoNumber(803) var customGenre: List<String>? = null,
-
-    // Neko specific values
-    @ProtoNumber(901) var filtered_scanlators: String? = null,
 ) {
     fun getMangaImpl(): MangaImpl {
         return MangaImpl().apply {
@@ -65,9 +51,8 @@ data class BackupManga(
             favorite = this@BackupManga.favorite
             source = this@BackupManga.source
             date_added = this@BackupManga.dateAdded
-            viewer_flags = this@BackupManga.viewer_flags ?: this@BackupManga.viewer
+            viewer = this@BackupManga.viewer
             chapter_flags = this@BackupManga.chapterFlags
-            filtered_scanlators = this@BackupManga.filtered_scanlators
         }
     }
 
@@ -77,29 +62,6 @@ data class BackupManga(
         }
     }
 
-    // SY -->
-    fun getCustomMangaInfo(): CustomMangaManager.MangaJson? {
-        if (customTitle != null ||
-            customArtist != null ||
-            customAuthor != null ||
-            customDescription != null ||
-            customGenre != null ||
-            customStatus != 0
-        ) {
-            return CustomMangaManager.MangaJson(
-                id = 0L,
-                title = customTitle,
-                author = customAuthor,
-                artist = customArtist,
-                description = customDescription,
-                genre = customGenre,
-                status = customStatus.takeUnless { it == 0 }
-            )
-        }
-        return null
-    }
-    // SY <--
-
     fun getTrackingImpl(): List<TrackImpl> {
         return tracking.map {
             it.getTrackingImpl()
@@ -107,37 +69,22 @@ data class BackupManga(
     }
 
     companion object {
-        fun copyFrom(manga: Manga /* SY --> */, customMangaManager: CustomMangaManager?/* SY <-- */): BackupManga {
+        fun copyFrom(manga: Manga): BackupManga {
             return BackupManga(
                 url = manga.url,
-                // SY -->
+                title = manga.title,
-                title = manga.originalTitle,
+                artist = manga.artist,
-                artist = manga.originalArtist,
+                author = manga.author,
-                author = manga.originalAuthor,
+                description = manga.description,
-                description = manga.originalDescription,
+                genre = manga.getGenres() ?: emptyList(),
-                genre = manga.getOriginalGenres() ?: emptyList(),
+                status = manga.status,
-                status = manga.originalStatus,
-                // SY <--
                 thumbnailUrl = manga.thumbnail_url,
                 favorite = manga.favorite,
                 source = manga.source,
                 dateAdded = manga.date_added,
-                viewer = manga.readingModeType,
+                viewer = manga.viewer,
-                viewer_flags = manga.viewer_flags,
+                chapterFlags = manga.chapter_flags
-                chapterFlags = manga.chapter_flags,
+            )
-                filtered_scanlators = manga.filtered_scanlators
-                // SY -->
-            ).also { backupManga ->
-                customMangaManager?.getManga(manga)?.let {
-                    backupManga.customTitle = it.title
-                    backupManga.customArtist = it.artist
-                    backupManga.customAuthor = it.author
-                    backupManga.customDescription = it.description
-                    backupManga.customGenre = it.getGenres()
-                    backupManga.customStatus = it.status
-                }
-            }
-            // SY <--
         }
     }
 }

app/src/main/java/eu/kanade/tachiyomi/data/backup/legacy/LegacyBackupManager.kt

@@ -5,13 +5,33 @@ import android.net.Uri
 import com.github.salomonbrys.kotson.fromJson
 import com.github.salomonbrys.kotson.registerTypeAdapter
 import com.github.salomonbrys.kotson.registerTypeHierarchyAdapter
+import com.github.salomonbrys.kotson.set
 import com.google.gson.Gson
 import com.google.gson.GsonBuilder
 import com.google.gson.JsonArray
 import com.google.gson.JsonElement
+import com.google.gson.JsonObject
+import com.hippo.unifile.UniFile
 import eu.kanade.tachiyomi.R
 import eu.kanade.tachiyomi.data.backup.AbstractBackupManager
+import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_CATEGORY
+import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_CATEGORY_MASK
+import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_CHAPTER
+import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_CHAPTER_MASK
+import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_HISTORY
+import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_HISTORY_MASK
+import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_TRACK
+import eu.kanade.tachiyomi.data.backup.BackupCreateService.Companion.BACKUP_TRACK_MASK
+import eu.kanade.tachiyomi.data.backup.legacy.models.Backup
+import eu.kanade.tachiyomi.data.backup.legacy.models.Backup.CATEGORIES
+import eu.kanade.tachiyomi.data.backup.legacy.models.Backup.CHAPTERS
 import eu.kanade.tachiyomi.data.backup.legacy.models.Backup.CURRENT_VERSION
+import eu.kanade.tachiyomi.data.backup.legacy.models.Backup.EXTENSIONS
+import eu.kanade.tachiyomi.data.backup.legacy.models.Backup.HISTORY
+import eu.kanade.tachiyomi.data.backup.legacy.models.Backup.MANGA
+import eu.kanade.tachiyomi.data.backup.legacy.models.Backup.MERGEDMANGAREFERENCES
+import eu.kanade.tachiyomi.data.backup.legacy.models.Backup.SAVEDSEARCHES
+import eu.kanade.tachiyomi.data.backup.legacy.models.Backup.TRACK
 import eu.kanade.tachiyomi.data.backup.legacy.models.DHistory
 import eu.kanade.tachiyomi.data.backup.legacy.serializer.CategoryTypeAdapter
 import eu.kanade.tachiyomi.data.backup.legacy.serializer.ChapterTypeAdapter
@@ -29,6 +49,8 @@ import eu.kanade.tachiyomi.data.database.models.MangaImpl
 import eu.kanade.tachiyomi.data.database.models.Track
 import eu.kanade.tachiyomi.data.database.models.TrackImpl
 import eu.kanade.tachiyomi.data.database.models.toMangaInfo
+import eu.kanade.tachiyomi.data.preference.PreferencesHelper
+import eu.kanade.tachiyomi.source.LocalSource
 import eu.kanade.tachiyomi.source.Source
 import eu.kanade.tachiyomi.source.model.toSManga
 import eu.kanade.tachiyomi.source.online.all.MergedSource
@@ -40,6 +62,8 @@ import kotlinx.serialization.decodeFromString
 import kotlinx.serialization.encodeToString
 import kotlinx.serialization.json.Json
 import timber.log.Timber
+import uy.kohesive.injekt.Injekt
+import uy.kohesive.injekt.api.get
 import java.lang.RuntimeException
 import kotlin.math.max
 
@@ -65,8 +89,180 @@ class LegacyBackupManager(context: Context, version: Int = CURRENT_VERSION) : Ab
      * @param uri path of Uri
      * @param isJob backup called from job
      */
-    override fun createBackup(uri: Uri, flags: Int, isJob: Boolean) =
+    override fun createBackup(uri: Uri, flags: Int, isJob: Boolean): String? {
-        throw IllegalStateException("Legacy backup creation is not supported")
+        // Create root object
+        val root = JsonObject()
+
+        // Create manga array
+        val mangaEntries = JsonArray()
+
+        // Create category array
+        val categoryEntries = JsonArray()
+
+        // Create extension ID/name mapping
+        val extensionEntries = JsonArray()
+
+        // Merged Manga References
+        val mergedMangaReferenceEntries = JsonArray()
+
+        // Add value's to root
+        root[Backup.VERSION] = CURRENT_VERSION
+        root[Backup.MANGAS] = mangaEntries
+        root[CATEGORIES] = categoryEntries
+        root[EXTENSIONS] = extensionEntries
+        // SY -->
+        root[MERGEDMANGAREFERENCES] = mergedMangaReferenceEntries
+        // SY <--
+
+        databaseHelper.inTransaction {
+            val mangas = getFavoriteManga()/* SY --> */.filterNot { it.source == MERGED_SOURCE_ID } + getMergedManga().filterNot { it.source == MERGED_SOURCE_ID } /* SY <-- */
+
+            val extensions: MutableSet<String> = mutableSetOf()
+
+            // Backup library manga and its dependencies
+            mangas.forEach { manga ->
+                mangaEntries.add(backupMangaObject(manga, flags))
+
+                // Maintain set of extensions/sources used (excludes local source)
+                if (manga.source != LocalSource.ID) {
+                    sourceManager.get(manga.source)?.let {
+                        extensions.add("${manga.source}:${it.name}")
+                    }
+                }
+            }
+
+            // Backup categories
+            if ((flags and BACKUP_CATEGORY_MASK) == BACKUP_CATEGORY) {
+                backupCategories(categoryEntries)
+            }
+
+            // Backup extension ID/name mapping
+            backupExtensionInfo(extensionEntries, extensions)
+            // SY -->
+            root[SAVEDSEARCHES] =
+                Injekt.get<PreferencesHelper>().savedSearches().get().joinToString(separator = "***")
+
+            backupMergedMangaReferences(mergedMangaReferenceEntries)
+            // SY <--
+        }
+
+        try {
+            val file: UniFile = (
+                if (isJob) {
+                    // Get dir of file and create
+                    var dir = UniFile.fromUri(context, uri)
+                    dir = dir.createDirectory("automatic")
+
+                    // Delete older backups
+                    val numberOfBackups = numberOfBackups()
+                    val backupRegex = Regex("""tachiyomi_\d+-\d+-\d+_\d+-\d+.json""")
+                    dir.listFiles { _, filename -> backupRegex.matches(filename) }
+                        .orEmpty()
+                        .sortedByDescending { it.name }
+                        .drop(numberOfBackups - 1)
+                        .forEach { it.delete() }
+
+                    // Create new file to place backup
+                    dir.createFile(Backup.getDefaultFilename())
+                } else {
+                    UniFile.fromUri(context, uri)
+                }
+                )
+                ?: throw Exception("Couldn't create backup file")
+
+            file.openOutputStream().bufferedWriter().use {
+                parser.toJson(root, it)
+            }
+            return file.uri.toString()
+        } catch (e: Exception) {
+            Timber.e(e)
+            throw e
+        }
+    }
+
+    private fun backupExtensionInfo(root: JsonArray, extensions: Set<String>) {
+        extensions.sorted().forEach {
+            root.add(it)
+        }
+    }
+
+    // SY -->
+    private fun backupMergedMangaReferences(root: JsonArray) {
+        val mergedMangaReferences = databaseHelper.getMergedMangaReferences().executeAsBlocking()
+        mergedMangaReferences.forEach { root.add(parser.toJsonTree(it)) }
+    }
+    // SY <--
+
+    /**
+     * Backup the categories of library
+     *
+     * @param root root of categories json
+     */
+    internal fun backupCategories(root: JsonArray) {
+        val categories = databaseHelper.getCategories().executeAsBlocking()
+        categories.forEach { root.add(parser.toJsonTree(it)) }
+    }
+
+    /**
+     * Convert a manga to Json
+     *
+     * @param manga manga that gets converted
+     * @return [JsonElement] containing manga information
+     */
+    internal fun backupMangaObject(manga: Manga, options: Int): JsonElement {
+        // Entry for this manga
+        val entry = JsonObject()
+
+        // Backup manga fields
+        entry[MANGA] = parser.toJsonTree(manga)
+
+        // Check if user wants chapter information in backup
+        if (options and BACKUP_CHAPTER_MASK == BACKUP_CHAPTER) {
+            // Backup all the chapters
+            val chapters = databaseHelper.getChapters(manga).executeAsBlocking()
+            if (chapters.isNotEmpty()) {
+                val chaptersJson = parser.toJsonTree(chapters)
+                if (chaptersJson.asJsonArray.size() > 0) {
+                    entry[CHAPTERS] = chaptersJson
+                }
+            }
+        }
+
+        // Check if user wants category information in backup
+        if (options and BACKUP_CATEGORY_MASK == BACKUP_CATEGORY) {
+            // Backup categories for this manga
+            val categoriesForManga = databaseHelper.getCategoriesForManga(manga).executeAsBlocking()
+            if (categoriesForManga.isNotEmpty()) {
+                val categoriesNames = categoriesForManga.map { it.name }
+                entry[CATEGORIES] = parser.toJsonTree(categoriesNames)
+            }
+        }
+
+        // Check if user wants track information in backup
+        if (options and BACKUP_TRACK_MASK == BACKUP_TRACK) {
+            val tracks = databaseHelper.getTracks(manga).executeAsBlocking()
+            if (tracks.isNotEmpty()) {
+                entry[TRACK] = parser.toJsonTree(tracks)
+            }
+        }
+
+        // Check if user wants history information in backup
+        if (options and BACKUP_HISTORY_MASK == BACKUP_HISTORY) {
+            val historyForManga = databaseHelper.getHistoryByMangaId(manga.id!!).executeAsBlocking()
+            if (historyForManga.isNotEmpty()) {
+                val historyData = historyForManga.mapNotNull { history ->
+                    val url = databaseHelper.getChapter(history.chapter_id).executeAsBlocking()?.url
+                    url?.let { DHistory(url, history.last_read) }
+                }
+                val historyJson = parser.toJsonTree(historyData)
+                if (historyJson.asJsonArray.size() > 0) {
+                    entry[HISTORY] = historyJson
+                }
+            }
+        }
+
+        return entry
+    }
 
     fun restoreMangaNoFetch(manga: Manga, dbManga: Manga) {
         manga.id = dbManga.id

app/src/main/java/eu/kanade/tachiyomi/data/backup/legacy/LegacyBackupRestore.kt

@@ -91,7 +91,7 @@ class LegacyBackupRestore(context: Context, notifier: BackupNotifier) : Abstract
     // SY <--
 
     private suspend fun restoreManga(mangaJson: JsonObject) {
-        val manga = backupManager.parser.fromJson<MangaImpl>(
+        /* SY --> */ var /* SY <-- */ manga = backupManager.parser.fromJson<MangaImpl>(
             mangaJson.get(
                 Backup.MANGA
             )
@@ -114,7 +114,7 @@ class LegacyBackupRestore(context: Context, notifier: BackupNotifier) : Abstract
         )
 
         // EXH -->
-        EXHMigrations.migrateBackupEntry(manga)
+        manga = EXHMigrations.migrateBackupEntry(manga)
         // <-- EXH
 
         val source = backupManager.sourceManager.get(manga.source)

app/src/main/java/eu/kanade/tachiyomi/data/backup/legacy/serializer/MangaTypeAdapter.kt

@@ -18,7 +18,7 @@ object MangaTypeAdapter {
                 value(it.originalTitle)
                 // SY <--
                 value(it.source)
-                value(it.viewer_flags)
+                value(it.viewer)
                 value(it.chapter_flags)
                 endArray()
             }
@@ -29,7 +29,7 @@ object MangaTypeAdapter {
                 manga.url = nextString()
                 manga.title = nextString()
                 manga.source = nextLong()
-                manga.viewer_flags = nextInt()
+                manga.viewer = nextInt()
                 manga.chapter_flags = nextInt()
                 endArray()
                 manga

app/src/main/java/eu/kanade/tachiyomi/data/cache/ChapterCache.kt

@@ -2,6 +2,8 @@ package eu.kanade.tachiyomi.data.cache
 
 import android.content.Context
 import android.text.format.Formatter
+import com.github.salomonbrys.kotson.fromJson
+import com.google.gson.Gson
 import com.jakewharton.disklrucache.DiskLruCache
 import eu.kanade.tachiyomi.data.database.models.Chapter
 import eu.kanade.tachiyomi.data.preference.PreferencesHelper
@@ -13,12 +15,10 @@ import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.Job
 import kotlinx.coroutines.flow.launchIn
 import kotlinx.coroutines.flow.onEach
-import kotlinx.serialization.decodeFromString
-import kotlinx.serialization.encodeToString
-import kotlinx.serialization.json.Json
 import okhttp3.Response
 import okio.buffer
 import okio.sink
+import rx.Observable
 import uy.kohesive.injekt.injectLazy
 import java.io.File
 import java.io.IOException
@@ -48,12 +48,14 @@ class ChapterCache(private val context: Context) {
     private val scope = CoroutineScope(Job() + Dispatchers.Main)
 
     /** Google Json class used for parsing JSON files.  */
-    private val json: Json by injectLazy()
+    private val gson: Gson by injectLazy()
 
     // --> EH
     private val prefs: PreferencesHelper by injectLazy()
+    // <-- EH
 
     /** Cache class used for cache management.  */
+    // --> EH
     private var diskCache = setupDiskCache(prefs.cacheSize().get().toLong())
 
     init {
@@ -71,7 +73,7 @@ class ChapterCache(private val context: Context) {
     /**
      * Returns directory of cache.
      */
-    private val cacheDir: File
+    val cacheDir: File
         get() = diskCache.directory
 
     /**
@@ -98,19 +100,43 @@ class ChapterCache(private val context: Context) {
     }
     // <-- EH
 
+    /**
+     * Remove file from cache.
+     *
+     * @param file name of file "md5.0".
+     * @return status of deletion for the file.
+     */
+    fun removeFileFromCache(file: String): Boolean {
+        // Make sure we don't delete the journal file (keeps track of cache).
+        if (file == "journal" || file.startsWith("journal.")) {
+            return false
+        }
+
+        return try {
+            // Remove the extension from the file to get the key of the cache
+            val key = file.substringBeforeLast(".")
+            // Remove file from cache.
+            diskCache.remove(key)
+        } catch (e: Exception) {
+            false
+        }
+    }
+
     /**
      * Get page list from cache.
      *
      * @param chapter the chapter.
-     * @return the list of pages.
+     * @return an observable of the list of pages.
      */
-    fun getPageListFromCache(chapter: Chapter): List<Page> {
+    fun getPageListFromCache(chapter: Chapter): Observable<List<Page>> {
-        // Get the key for the chapter.
+        return Observable.fromCallable {
-        val key = DiskUtil.hashKeyForDisk(getKey(chapter))
+            // Get the key for the chapter.
+            val key = DiskUtil.hashKeyForDisk(getKey(chapter))
 
-        // Convert JSON string to list of objects. Throws an exception if snapshot is null
+            // Convert JSON string to list of objects. Throws an exception if snapshot is null
-        return diskCache.get(key).use {
+            diskCache.get(key).use {
-            json.decodeFromString(it.getString(0))
+                gson.fromJson<List<Page>>(it.getString(0))
+            }
         }
     }
 
@@ -122,7 +148,7 @@ class ChapterCache(private val context: Context) {
      */
     fun putPageListToCache(chapter: Chapter, pages: List<Page>) {
         // Convert list of pages to json string.
-        val cachedValue = json.encodeToString(pages)
+        val cachedValue = gson.toJson(pages)
 
         // Initialize the editor (edits the values for an entry).
         var editor: DiskLruCache.Editor? = null
@@ -202,38 +228,6 @@ class ChapterCache(private val context: Context) {
         }
     }
 
-    fun clear(): Int {
-        var deletedFiles = 0
-        cacheDir.listFiles()?.forEach {
-            if (removeFileFromCache(it.name)) {
-                deletedFiles++
-            }
-        }
-        return deletedFiles
-    }
-
-    /**
-     * Remove file from cache.
-     *
-     * @param file name of file "md5.0".
-     * @return status of deletion for the file.
-     */
-    private fun removeFileFromCache(file: String): Boolean {
-        // Make sure we don't delete the journal file (keeps track of cache).
-        if (file == "journal" || file.startsWith("journal.")) {
-            return false
-        }
-
-        return try {
-            // Remove the extension from the file to get the key of the cache
-            val key = file.substringBeforeLast(".")
-            // Remove file from cache.
-            diskCache.remove(key)
-        } catch (e: Exception) {
-            false
-        }
-    }
-
     private fun getKey(chapter: Chapter): String {
         return "${chapter.manga_id}${chapter.url}"
     }

app/src/main/java/eu/kanade/tachiyomi/data/cache/CoverCache.kt

@@ -1,7 +1,6 @@
 package eu.kanade.tachiyomi.data.cache
 
 import android.content.Context
-import coil.imageLoader
 import eu.kanade.tachiyomi.data.database.models.Manga
 import eu.kanade.tachiyomi.util.storage.DiskUtil
 import java.io.File
@@ -100,13 +99,6 @@ class CoverCache(private val context: Context) {
         }
     }
 
-    /**
-     * Clear coil's memory cache.
-     */
-    fun clearMemoryCache() {
-        context.imageLoader.memoryCache.clear()
-    }
-
     private fun getCacheDir(dir: String): File {
         return context.getExternalFilesDir(dir)
             ?: File(context.filesDir, dir).also { it.mkdirs() }

app/src/main/java/eu/kanade/tachiyomi/data/coil/ByteBufferFetcher.kt

@@ -1,25 +0,0 @@
-package eu.kanade.tachiyomi.data.coil
-
-import coil.bitmap.BitmapPool
-import coil.decode.DataSource
-import coil.decode.Options
-import coil.fetch.FetchResult
-import coil.fetch.Fetcher
-import coil.fetch.SourceResult
-import coil.size.Size
-import okio.buffer
-import okio.source
-import java.io.ByteArrayInputStream
-import java.nio.ByteBuffer
-
-class ByteBufferFetcher : Fetcher<ByteBuffer> {
-    override suspend fun fetch(pool: BitmapPool, data: ByteBuffer, size: Size, options: Options): FetchResult {
-        return SourceResult(
-            source = ByteArrayInputStream(data.array()).source().buffer(),
-            mimeType = null,
-            dataSource = DataSource.MEMORY
-        )
-    }
-
-    override fun key(data: ByteBuffer): String? = null
-}

app/src/main/java/eu/kanade/tachiyomi/data/coil/MangaCoverFetcher.kt

@@ -1,172 +0,0 @@
-package eu.kanade.tachiyomi.data.coil
-
-import coil.bitmap.BitmapPool
-import coil.decode.DataSource
-import coil.decode.Options
-import coil.fetch.FetchResult
-import coil.fetch.Fetcher
-import coil.fetch.SourceResult
-import coil.network.HttpException
-import coil.request.get
-import coil.size.Size
-import eu.kanade.tachiyomi.data.cache.CoverCache
-import eu.kanade.tachiyomi.data.database.models.Manga
-import eu.kanade.tachiyomi.network.NetworkHelper
-import eu.kanade.tachiyomi.network.await
-import eu.kanade.tachiyomi.source.SourceManager
-import eu.kanade.tachiyomi.source.online.HttpSource
-import okhttp3.CacheControl
-import okhttp3.Call
-import okhttp3.Request
-import okhttp3.Response
-import okhttp3.ResponseBody
-import okio.buffer
-import okio.sink
-import okio.source
-import uy.kohesive.injekt.Injekt
-import uy.kohesive.injekt.api.get
-import uy.kohesive.injekt.injectLazy
-import java.io.File
-import java.util.Date
-
-/**
- * Coil component that fetches [Manga] cover while using the cached file in disk when available.
- *
- * Available request parameter:
- * - [USE_CUSTOM_COVER]: Use custom cover if set by user, default is true
- */
-class MangaCoverFetcher : Fetcher<Manga> {
-    private val coverCache: CoverCache by injectLazy()
-    private val sourceManager: SourceManager by injectLazy()
-    private val defaultClient = Injekt.get<NetworkHelper>().coilClient
-
-    override fun key(data: Manga): String? {
-        if (data.thumbnail_url.isNullOrBlank()) return null
-        return data.thumbnail_url!!
-    }
-
-    override suspend fun fetch(pool: BitmapPool, data: Manga, size: Size, options: Options): FetchResult {
-        // Use custom cover if exists
-        val useCustomCover = options.parameters[USE_CUSTOM_COVER] as? Boolean ?: true
-        val customCoverFile = coverCache.getCustomCoverFile(data)
-        if (useCustomCover && customCoverFile.exists()) {
-            return fileLoader(customCoverFile)
-        }
-
-        val cover = data.thumbnail_url
-        return when (getResourceType(cover)) {
-            Type.URL -> httpLoader(data, options)
-            Type.File -> fileLoader(data)
-            null -> error("Invalid image")
-        }
-    }
-
-    private suspend fun httpLoader(manga: Manga, options: Options): FetchResult {
-        val coverFile = coverCache.getCoverFile(manga) ?: error("No cover specified")
-
-        // Use previously cached cover if exist
-        if (coverFile.exists() && options.diskCachePolicy.readEnabled) {
-            if (!manga.favorite) {
-                coverFile.setLastModified(Date().time)
-            }
-            return fileLoader(coverFile)
-        }
-
-        val (response, body) = awaitGetCall(manga, options)
-        if (!response.isSuccessful) {
-            body.close()
-            throw HttpException(response)
-        }
-
-        // Write to disk for future use
-        if (options.diskCachePolicy.writeEnabled) {
-            response.peekBody(Long.MAX_VALUE).source().use { input ->
-                val tmpFile = File(coverFile.absolutePath + "_tmp")
-                tmpFile.parentFile?.mkdirs()
-                tmpFile.sink().buffer().use { output ->
-                    output.writeAll(input)
-                }
-                if (coverFile.exists()) {
-                    coverFile.delete()
-                }
-                tmpFile.renameTo(coverFile)
-            }
-        }
-
-        return SourceResult(
-            source = body.source(),
-            mimeType = "image/*",
-            dataSource = if (response.cacheResponse != null) DataSource.DISK else DataSource.NETWORK
-        )
-    }
-
-    private suspend fun awaitGetCall(manga: Manga, options: Options): Pair<Response, ResponseBody> {
-        val call = getCall(manga, options)
-        val response = call.await()
-        return response to checkNotNull(response.body) { "Null response source" }
-    }
-
-    private fun getCall(manga: Manga, options: Options): Call {
-        val source = sourceManager.get(manga.source) as? HttpSource
-        val client = source?.client ?: defaultClient
-
-        val newClient = client.newBuilder().build()
-
-        val request = Request.Builder().url(manga.thumbnail_url!!).also {
-            if (source != null) {
-                it.headers(source.headers)
-            }
-
-            val networkRead = options.networkCachePolicy.readEnabled
-            val diskRead = options.diskCachePolicy.readEnabled
-            when {
-                !networkRead && diskRead -> {
-                    it.cacheControl(CacheControl.FORCE_CACHE)
-                }
-                networkRead && !diskRead -> if (options.diskCachePolicy.writeEnabled) {
-                    it.cacheControl(CacheControl.FORCE_NETWORK)
-                } else {
-                    it.cacheControl(CACHE_CONTROL_FORCE_NETWORK_NO_CACHE)
-                }
-                !networkRead && !diskRead -> {
-                    // This causes the request to fail with a 504 Unsatisfiable Request.
-                    it.cacheControl(CACHE_CONTROL_NO_NETWORK_NO_CACHE)
-                }
-            }
-        }.build()
-
-        return newClient.newCall(request)
-    }
-
-    private fun fileLoader(manga: Manga): FetchResult {
-        return fileLoader(File(manga.thumbnail_url!!.substringAfter("file://")))
-    }
-
-    private fun fileLoader(file: File): FetchResult {
-        return SourceResult(
-            source = file.source().buffer(),
-            mimeType = "image/*",
-            dataSource = DataSource.DISK
-        )
-    }
-
-    private fun getResourceType(cover: String?): Type? {
-        return when {
-            cover.isNullOrEmpty() -> null
-            cover.startsWith("http") || cover.startsWith("Custom-", true) -> Type.URL
-            cover.startsWith("/") || cover.startsWith("file://") -> Type.File
-            else -> null
-        }
-    }
-
-    private enum class Type {
-        File, URL
-    }
-
-    companion object {
-        const val USE_CUSTOM_COVER = "use_custom_cover"
-
-        private val CACHE_CONTROL_FORCE_NETWORK_NO_CACHE = CacheControl.Builder().noCache().noStore().build()
-        private val CACHE_CONTROL_NO_NETWORK_NO_CACHE = CacheControl.Builder().noCache().onlyIfCached().build()
-    }
-}

app/src/main/java/eu/kanade/tachiyomi/data/database/DatabaseHelper.kt

@@ -21,6 +21,9 @@ import eu.kanade.tachiyomi.data.database.queries.HistoryQueries
 import eu.kanade.tachiyomi.data.database.queries.MangaCategoryQueries
 import eu.kanade.tachiyomi.data.database.queries.MangaQueries
 import eu.kanade.tachiyomi.data.database.queries.TrackQueries
+import exh.md.similar.sql.mappers.SimilarTypeMapping
+import exh.md.similar.sql.models.MangaSimilar
+import exh.md.similar.sql.queries.SimilarQueries
 import exh.merged.sql.mappers.MergedMangaTypeMapping
 import exh.merged.sql.models.MergedMangaReference
 import exh.merged.sql.queries.MergedQueries
@@ -39,7 +42,7 @@ import io.requery.android.database.sqlite.RequerySQLiteOpenHelperFactory
  * This class provides operations to manage the database through its interfaces.
  */
 open class DatabaseHelper(context: Context) :
-    MangaQueries, ChapterQueries, TrackQueries, CategoryQueries, MangaCategoryQueries, HistoryQueries /* SY --> */, SearchMetadataQueries, SearchTagQueries, SearchTitleQueries, MergedQueries /* SY <-- */ {
+    MangaQueries, ChapterQueries, TrackQueries, CategoryQueries, MangaCategoryQueries, HistoryQueries /* SY --> */, SearchMetadataQueries, SearchTagQueries, SearchTitleQueries, MergedQueries, SimilarQueries /* SY <-- */ {
 
     private val configuration = SupportSQLiteOpenHelper.Configuration.builder(context)
         .name(DbOpenCallback.DATABASE_NAME)
@@ -59,6 +62,7 @@ open class DatabaseHelper(context: Context) :
         .addTypeMapping(SearchTag::class.java, SearchTagTypeMapping())
         .addTypeMapping(SearchTitle::class.java, SearchTitleTypeMapping())
         .addTypeMapping(MergedMangaReference::class.java, MergedMangaTypeMapping())
+        .addTypeMapping(MangaSimilar::class.java, SimilarTypeMapping())
         // SY <--
         .build()
 

app/src/main/java/eu/kanade/tachiyomi/data/database/DbOpenCallback.kt

@@ -8,6 +8,7 @@ import eu.kanade.tachiyomi.data.database.tables.HistoryTable
 import eu.kanade.tachiyomi.data.database.tables.MangaCategoryTable
 import eu.kanade.tachiyomi.data.database.tables.MangaTable
 import eu.kanade.tachiyomi.data.database.tables.TrackTable
+import exh.md.similar.sql.tables.SimilarTable
 import exh.merged.sql.tables.MergedTable
 import exh.metadata.sql.tables.SearchMetadataTable
 import exh.metadata.sql.tables.SearchTagTable
@@ -24,7 +25,7 @@ class DbOpenCallback : SupportSQLiteOpenHelper.Callback(DATABASE_VERSION) {
         /**
          * Version of the database.
          */
-        const val DATABASE_VERSION = /* SY --> */ 7 /* SY <-- */
+        const val DATABASE_VERSION = /* SY --> */ 5 /* SY <-- */
     }
 
     override fun onCreate(db: SupportSQLiteDatabase) = with(db) {
@@ -39,6 +40,7 @@ class DbOpenCallback : SupportSQLiteOpenHelper.Callback(DATABASE_VERSION) {
         execSQL(SearchTagTable.createTableQuery)
         execSQL(SearchTitleTable.createTableQuery)
         execSQL(MergedTable.createTableQuery)
+        execSQL(SimilarTable.createTableQuery)
         // SY <--
 
         // DB indexes
@@ -55,6 +57,7 @@ class DbOpenCallback : SupportSQLiteOpenHelper.Callback(DATABASE_VERSION) {
         execSQL(SearchTitleTable.createMangaIdIndexQuery)
         execSQL(SearchTitleTable.createTitleIndexQuery)
         execSQL(MergedTable.createIndexQuery)
+        execSQL(SimilarTable.createMangaIdIndexQuery)
         // SY <--
     }
 
@@ -71,15 +74,9 @@ class DbOpenCallback : SupportSQLiteOpenHelper.Callback(DATABASE_VERSION) {
             db.execSQL(MergedTable.createTableQuery)
             db.execSQL(MergedTable.createIndexQuery)
         }
-        /*if (oldVersion < 5) {
+        if (oldVersion < 5) {
             db.execSQL(SimilarTable.createTableQuery)
             db.execSQL(SimilarTable.createMangaIdIndexQuery)
-        }*/
-        if (oldVersion < 6) {
-            db.execSQL(MangaTable.addFilteredScanlators)
-        }
-        if (oldVersion < 7) {
-            db.execSQL("DROP TABLE IF EXISTS manga_related")
         }
     }
 

app/src/main/java/eu/kanade/tachiyomi/data/database/mappers/MangaTypeMapping.kt

@@ -18,7 +18,6 @@ import eu.kanade.tachiyomi.data.database.tables.MangaTable.COL_COVER_LAST_MODIFI
 import eu.kanade.tachiyomi.data.database.tables.MangaTable.COL_DATE_ADDED
 import eu.kanade.tachiyomi.data.database.tables.MangaTable.COL_DESCRIPTION
 import eu.kanade.tachiyomi.data.database.tables.MangaTable.COL_FAVORITE
-import eu.kanade.tachiyomi.data.database.tables.MangaTable.COL_FILTERED_SCANLATORS
 import eu.kanade.tachiyomi.data.database.tables.MangaTable.COL_GENRE
 import eu.kanade.tachiyomi.data.database.tables.MangaTable.COL_ID
 import eu.kanade.tachiyomi.data.database.tables.MangaTable.COL_INITIALIZED
@@ -60,17 +59,16 @@ class MangaPutResolver : DefaultPutResolver<Manga>() {
             COL_DESCRIPTION to obj.originalDescription,
             COL_GENRE to obj.originalGenre,
             COL_TITLE to obj.originalTitle,
-            COL_STATUS to obj.originalStatus,
             // SY <--
+            COL_STATUS to obj.status,
             COL_THUMBNAIL_URL to obj.thumbnail_url,
             COL_FAVORITE to obj.favorite,
             COL_LAST_UPDATE to obj.last_update,
             COL_INITIALIZED to obj.initialized,
-            COL_VIEWER to obj.viewer_flags,
+            COL_VIEWER to obj.viewer,
             COL_CHAPTER_FLAGS to obj.chapter_flags,
             COL_COVER_LAST_MODIFIED to obj.cover_last_modified,
-            COL_DATE_ADDED to obj.date_added,
+            COL_DATE_ADDED to obj.date_added
-            COL_FILTERED_SCANLATORS to obj.filtered_scanlators
         )
 }
 
@@ -89,11 +87,10 @@ interface BaseMangaGetResolver {
         favorite = cursor.getInt(cursor.getColumnIndex(COL_FAVORITE)) == 1
         last_update = cursor.getLong(cursor.getColumnIndex(COL_LAST_UPDATE))
         initialized = cursor.getInt(cursor.getColumnIndex(COL_INITIALIZED)) == 1
-        viewer_flags = cursor.getInt(cursor.getColumnIndex(COL_VIEWER))
+        viewer = cursor.getInt(cursor.getColumnIndex(COL_VIEWER))
         chapter_flags = cursor.getInt(cursor.getColumnIndex(COL_CHAPTER_FLAGS))
         cover_last_modified = cursor.getLong(cursor.getColumnIndex(COL_COVER_LAST_MODIFIED))
         date_added = cursor.getLong(cursor.getColumnIndex(COL_DATE_ADDED))
-        filtered_scanlators = cursor.getString(cursor.getColumnIndex(COL_FILTERED_SCANLATORS))
     }
 }
 

app/src/main/java/eu/kanade/tachiyomi/data/database/models/Manga.kt

@@ -1,8 +1,6 @@
 package eu.kanade.tachiyomi.data.database.models
 
 import eu.kanade.tachiyomi.source.model.SManga
-import eu.kanade.tachiyomi.ui.reader.setting.OrientationType
-import eu.kanade.tachiyomi.ui.reader.setting.ReadingModeType
 import tachiyomi.source.model.MangaInfo
 
 interface Manga : SManga {
@@ -17,20 +15,18 @@ interface Manga : SManga {
 
     var date_added: Long
 
-    var viewer_flags: Int
+    var viewer: Int
 
     var chapter_flags: Int
 
     var cover_last_modified: Long
 
-    var filtered_scanlators: String?
-
     fun setChapterOrder(order: Int) {
-        setChapterFlags(order, CHAPTER_SORT_MASK)
+        setFlags(order, SORT_MASK)
     }
 
     fun sortDescending(): Boolean {
-        return chapter_flags and CHAPTER_SORT_MASK == CHAPTER_SORT_DESC
+        return chapter_flags and SORT_MASK == SORT_DESC
     }
 
     fun getGenres(): List<String>? {
@@ -43,72 +39,60 @@ interface Manga : SManga {
     }
     // SY <--
 
-    private fun setChapterFlags(flag: Int, mask: Int) {
+    private fun setFlags(flag: Int, mask: Int) {
         chapter_flags = chapter_flags and mask.inv() or (flag and mask)
     }
 
-    private fun setViewerFlags(flag: Int, mask: Int) {
-        viewer_flags = viewer_flags and mask.inv() or (flag and mask)
-    }
-
     // Used to display the chapter's title one way or another
     var displayMode: Int
-        get() = chapter_flags and CHAPTER_DISPLAY_MASK
+        get() = chapter_flags and DISPLAY_MASK
-        set(mode) = setChapterFlags(mode, CHAPTER_DISPLAY_MASK)
+        set(mode) = setFlags(mode, DISPLAY_MASK)
 
     var readFilter: Int
-        get() = chapter_flags and CHAPTER_READ_MASK
+        get() = chapter_flags and READ_MASK
-        set(filter) = setChapterFlags(filter, CHAPTER_READ_MASK)
+        set(filter) = setFlags(filter, READ_MASK)
 
     var downloadedFilter: Int
-        get() = chapter_flags and CHAPTER_DOWNLOADED_MASK
+        get() = chapter_flags and DOWNLOADED_MASK
-        set(filter) = setChapterFlags(filter, CHAPTER_DOWNLOADED_MASK)
+        set(filter) = setFlags(filter, DOWNLOADED_MASK)
 
     var bookmarkedFilter: Int
-        get() = chapter_flags and CHAPTER_BOOKMARKED_MASK
+        get() = chapter_flags and BOOKMARKED_MASK
-        set(filter) = setChapterFlags(filter, CHAPTER_BOOKMARKED_MASK)
+        set(filter) = setFlags(filter, BOOKMARKED_MASK)
 
     var sorting: Int
-        get() = chapter_flags and CHAPTER_SORTING_MASK
+        get() = chapter_flags and SORTING_MASK
-        set(sort) = setChapterFlags(sort, CHAPTER_SORTING_MASK)
+        set(sort) = setFlags(sort, SORTING_MASK)
-
-    var readingModeType: Int
-        get() = viewer_flags and ReadingModeType.MASK
-        set(readingMode) = setViewerFlags(readingMode, ReadingModeType.MASK)
-
-    var orientationType: Int
-        get() = viewer_flags and OrientationType.MASK
-        set(rotationType) = setViewerFlags(rotationType, OrientationType.MASK)
 
     companion object {
 
+        const val SORT_DESC = 0x00000000
+        const val SORT_ASC = 0x00000001
+        const val SORT_MASK = 0x00000001
+
         // Generic filter that does not filter anything
         const val SHOW_ALL = 0x00000000
 
-        const val CHAPTER_SORT_DESC = 0x00000000
+        const val SHOW_UNREAD = 0x00000002
-        const val CHAPTER_SORT_ASC = 0x00000001
+        const val SHOW_READ = 0x00000004
-        const val CHAPTER_SORT_MASK = 0x00000001
+        const val READ_MASK = 0x00000006
 
-        const val CHAPTER_SHOW_UNREAD = 0x00000002
+        const val SHOW_DOWNLOADED = 0x00000008
-        const val CHAPTER_SHOW_READ = 0x00000004
+        const val SHOW_NOT_DOWNLOADED = 0x00000010
-        const val CHAPTER_READ_MASK = 0x00000006
+        const val DOWNLOADED_MASK = 0x00000018
 
-        const val CHAPTER_SHOW_DOWNLOADED = 0x00000008
+        const val SHOW_BOOKMARKED = 0x00000020
-        const val CHAPTER_SHOW_NOT_DOWNLOADED = 0x00000010
+        const val SHOW_NOT_BOOKMARKED = 0x00000040
-        const val CHAPTER_DOWNLOADED_MASK = 0x00000018
+        const val BOOKMARKED_MASK = 0x00000060
 
-        const val CHAPTER_SHOW_BOOKMARKED = 0x00000020
+        const val SORTING_SOURCE = 0x00000000
-        const val CHAPTER_SHOW_NOT_BOOKMARKED = 0x00000040
+        const val SORTING_NUMBER = 0x00000100
-        const val CHAPTER_BOOKMARKED_MASK = 0x00000060
+        const val SORTING_UPLOAD_DATE = 0x00000200
+        const val SORTING_MASK = 0x00000300
 
-        const val CHAPTER_SORTING_SOURCE = 0x00000000
+        const val DISPLAY_NAME = 0x00000000
-        const val CHAPTER_SORTING_NUMBER = 0x00000100
+        const val DISPLAY_NUMBER = 0x00100000
-        const val CHAPTER_SORTING_UPLOAD_DATE = 0x00000200
+        const val DISPLAY_MASK = 0x00100000
-        const val CHAPTER_SORTING_MASK = 0x00000300
-
-        const val CHAPTER_DISPLAY_NAME = 0x00000000
-        const val CHAPTER_DISPLAY_NUMBER = 0x00100000
-        const val CHAPTER_DISPLAY_MASK = 0x00100000
 
         fun create(source: Long): Manga = MangaImpl().apply {
             this.source = source

app/src/main/java/eu/kanade/tachiyomi/data/database/models/MangaImpl.kt

@@ -40,12 +40,10 @@ open class MangaImpl : Manga {
     override var genre: String?
         get() = if (favorite) customMangaManager.getManga(this)?.genre ?: ogGenre else ogGenre
         set(value) { ogGenre = value }
-
-    override var status: Int
-        get() = if (favorite) customMangaManager.getManga(this)?.status?.takeUnless { it == 0 } ?: ogStatus else ogStatus
-        set(value) { ogStatus = value }
     // SY <--
 
+    override var status: Int = 0
+
     override var thumbnail_url: String? = null
 
     override var favorite: Boolean = false
@@ -56,14 +54,12 @@ open class MangaImpl : Manga {
 
     override var initialized: Boolean = false
 
-    override var viewer_flags: Int = 0
+    override var viewer: Int = 0
 
     override var chapter_flags: Int = 0
 
     override var cover_last_modified: Long = 0
 
-    override var filtered_scanlators: String? = null
-
     // SY -->
     lateinit var ogTitle: String
         private set
@@ -75,8 +71,6 @@ open class MangaImpl : Manga {
         private set
     var ogGenre: String? = null
         private set
-    var ogStatus: Int = 0
-        private set
     // SY <--
 
     override fun equals(other: Any?): Boolean {

app/src/main/java/eu/kanade/tachiyomi/data/database/queries/MangaQueries.kt

@@ -9,13 +9,12 @@ import eu.kanade.tachiyomi.data.database.models.Manga
 import eu.kanade.tachiyomi.data.database.resolvers.LibraryMangaGetResolver
 import eu.kanade.tachiyomi.data.database.resolvers.MangaCoverLastModifiedPutResolver
 import eu.kanade.tachiyomi.data.database.resolvers.MangaFavoritePutResolver
-import eu.kanade.tachiyomi.data.database.resolvers.MangaFilteredScanlatorsPutResolver
 import eu.kanade.tachiyomi.data.database.resolvers.MangaFlagsPutResolver
 import eu.kanade.tachiyomi.data.database.resolvers.MangaInfoPutResolver
 import eu.kanade.tachiyomi.data.database.resolvers.MangaLastUpdatedPutResolver
 import eu.kanade.tachiyomi.data.database.resolvers.MangaMigrationPutResolver
-import eu.kanade.tachiyomi.data.database.resolvers.MangaThumbnailPutResolver
 import eu.kanade.tachiyomi.data.database.resolvers.MangaTitlePutResolver
+import eu.kanade.tachiyomi.data.database.resolvers.MangaViewerPutResolver
 import eu.kanade.tachiyomi.data.database.tables.CategoryTable
 import eu.kanade.tachiyomi.data.database.tables.ChapterTable
 import eu.kanade.tachiyomi.data.database.tables.MangaCategoryTable
@@ -103,35 +102,20 @@ interface MangaQueries : DbProvider {
         .`object`(manga)
         .withPutResolver(MangaMigrationPutResolver())
         .prepare()
-
-    fun updateMangaThumbnail(manga: Manga) = db.put()
-        .`object`(manga)
-        .withPutResolver(MangaThumbnailPutResolver())
-        .prepare()
     // SY <--
 
     fun insertManga(manga: Manga) = db.put().`object`(manga).prepare()
 
     fun insertMangas(mangas: List<Manga>) = db.put().objects(mangas).prepare()
 
-    fun updateChapterFlags(manga: Manga) = db.put()
+    fun updateFlags(manga: Manga) = db.put()
         .`object`(manga)
-        .withPutResolver(MangaFlagsPutResolver(MangaTable.COL_CHAPTER_FLAGS, Manga::chapter_flags))
+        .withPutResolver(MangaFlagsPutResolver())
         .prepare()
 
-    fun updateChapterFlags(manga: List<Manga>) = db.put()
+    fun updateFlags(mangas: List<Manga>) = db.put()
-        .objects(manga)
+        .objects(mangas)
-        .withPutResolver(MangaFlagsPutResolver(MangaTable.COL_CHAPTER_FLAGS, Manga::chapter_flags, true))
+        .withPutResolver(MangaFlagsPutResolver(true))
-        .prepare()
-
-    fun updateViewerFlags(manga: Manga) = db.put()
-        .`object`(manga)
-        .withPutResolver(MangaFlagsPutResolver(MangaTable.COL_VIEWER, Manga::viewer_flags))
-        .prepare()
-
-    fun updateViewerFlags(manga: List<Manga>) = db.put()
-        .objects(manga)
-        .withPutResolver(MangaFlagsPutResolver(MangaTable.COL_VIEWER, Manga::viewer_flags, true))
         .prepare()
 
     fun updateLastUpdated(manga: Manga) = db.put()
@@ -144,6 +128,11 @@ interface MangaQueries : DbProvider {
         .withPutResolver(MangaFavoritePutResolver())
         .prepare()
 
+    fun updateMangaViewer(manga: Manga) = db.put()
+        .`object`(manga)
+        .withPutResolver(MangaViewerPutResolver())
+        .prepare()
+
     fun updateMangaTitle(manga: Manga) = db.put()
         .`object`(manga)
         .withPutResolver(MangaTitlePutResolver())
@@ -154,13 +143,6 @@ interface MangaQueries : DbProvider {
         .withPutResolver(MangaCoverLastModifiedPutResolver())
         .prepare()
 
-    // SY -->
-    fun updateMangaFilteredScanlators(manga: Manga) = db.put()
-        .`object`(manga)
-        .withPutResolver(MangaFilteredScanlatorsPutResolver())
-        .prepare()
-    // SY <--
-
     fun deleteManga(manga: Manga) = db.delete().`object`(manga).prepare()
 
     fun deleteMangas(mangas: List<Manga>) = db.delete().objects(mangas).prepare()
@@ -169,38 +151,12 @@ interface MangaQueries : DbProvider {
         .byQuery(
             DeleteQuery.builder()
                 .table(MangaTable.TABLE)
-                .where(
+                .where("${MangaTable.COL_FAVORITE} = ? AND ${MangaTable.COL_ID} NOT IN (SELECT ${MergedTable.COL_MANGA_ID} FROM ${MergedTable.TABLE})")
-                    """
-                    ${MangaTable.COL_FAVORITE} = ? AND ${MangaTable.COL_ID} NOT IN (
-                        SELECT ${MergedTable.COL_MANGA_ID} FROM ${MergedTable.TABLE} WHERE ${MergedTable.COL_MANGA_ID} != ${MergedTable.COL_MERGE_ID}
-                    )
-                    """.trimIndent()
-                )
                 .whereArgs(0)
                 .build()
         )
         .prepare()
 
-    // SY -->
-    fun deleteMangasNotInLibraryAndNotRead() = db.delete()
-        .byQuery(
-            DeleteQuery.builder()
-                .table(MangaTable.TABLE)
-                .where(
-                    """
-                    ${MangaTable.COL_FAVORITE} = ? AND ${MangaTable.COL_ID} NOT IN (
-                        SELECT ${MergedTable.COL_MANGA_ID} FROM ${MergedTable.TABLE} WHERE ${MergedTable.COL_MANGA_ID} != ${MergedTable.COL_MERGE_ID}
-                    ) AND ${MangaTable.COL_ID} NOT IN (
-                        SELECT ${ChapterTable.COL_MANGA_ID} FROM ${ChapterTable.TABLE} WHERE ${ChapterTable.COL_READ} = 1 OR ${ChapterTable.COL_LAST_PAGE_READ} != 0
-                    )
-                    """.trimIndent()
-                )
-                .whereArgs(0)
-                .build()
-        )
-        .prepare()
-    // SY <--
-
     fun deleteMangas() = db.delete()
         .byQuery(
             DeleteQuery.builder()
@@ -239,16 +195,6 @@ interface MangaQueries : DbProvider {
         )
         .prepare()
 
-    fun getChapterFetchDateManga() = db.get()
-        .listOfObjects(Manga::class.java)
-        .withQuery(
-            RawQuery.builder()
-                .query(getChapterFetchDateMangaQuery())
-                .observesTables(MangaTable.TABLE)
-                .build()
-        )
-        .prepare()
-
     // SY -->
     fun getMangaWithMetadata() = db.get()
         .listOfObjects(Manga::class.java)

app/src/main/java/eu/kanade/tachiyomi/data/database/queries/RawQueries.kt

@@ -69,7 +69,7 @@ fun getReadMangaNotInLibraryQuery() =
     SELECT ${Manga.TABLE}.* 
     FROM ${Manga.TABLE} 
     WHERE ${Manga.COL_FAVORITE} = 0 AND ${Manga.COL_ID} IN(
-        SELECT ${Chapter.TABLE}.${Chapter.COL_MANGA_ID} FROM ${Chapter.TABLE} WHERE ${Chapter.COL_READ} = 1 OR ${Chapter.COL_LAST_PAGE_READ} != 0
+        SELECT ${Chapter.TABLE}.${Chapter.COL_MANGA_ID} FROM ${Chapter.TABLE} WHERE ${Chapter.COL_READ} = 1
     )
 """
 
@@ -221,16 +221,6 @@ fun getLatestChapterMangaQuery() =
     ORDER by max DESC
 """
 
-fun getChapterFetchDateMangaQuery() =
-    """
-    SELECT ${Manga.TABLE}.*, MAX(${Chapter.TABLE}.${Chapter.COL_DATE_FETCH}) AS max
-    FROM ${Manga.TABLE}
-    JOIN ${Chapter.TABLE}
-    ON ${Manga.TABLE}.${Manga.COL_ID} = ${Chapter.TABLE}.${Chapter.COL_MANGA_ID}
-    GROUP BY ${Manga.TABLE}.${Manga.COL_ID}
-    ORDER by max DESC
-"""
-
 /**
  * Query to get the categories for a manga.
  */

app/src/main/java/eu/kanade/tachiyomi/data/database/resolvers/MangaFilteredScanlatorsPutResolver.kt

@@ -1,32 +0,0 @@
-package eu.kanade.tachiyomi.data.database.resolvers
-
-import androidx.core.content.contentValuesOf
-import com.pushtorefresh.storio.sqlite.StorIOSQLite
-import com.pushtorefresh.storio.sqlite.operations.put.PutResolver
-import com.pushtorefresh.storio.sqlite.operations.put.PutResult
-import com.pushtorefresh.storio.sqlite.queries.UpdateQuery
-import eu.kanade.tachiyomi.data.database.inTransactionReturn
-import eu.kanade.tachiyomi.data.database.models.Manga
-import eu.kanade.tachiyomi.data.database.tables.MangaTable
-
-// [EXH]
-class MangaFilteredScanlatorsPutResolver : PutResolver<Manga>() {
-
-    override fun performPut(db: StorIOSQLite, manga: Manga) = db.inTransactionReturn {
-        val updateQuery = mapToUpdateQuery(manga)
-        val contentValues = mapToContentValues(manga)
-
-        val numberOfRowsUpdated = db.lowLevel().update(updateQuery, contentValues)
-        PutResult.newUpdateResult(numberOfRowsUpdated, updateQuery.table())
-    }
-
-    fun mapToUpdateQuery(manga: Manga) = UpdateQuery.builder()
-        .table(MangaTable.TABLE)
-        .where("${MangaTable.COL_FILTERED_SCANLATORS} = ?")
-        .whereArgs(manga.filtered_scanlators)
-        .build()
-
-    fun mapToContentValues(manga: Manga) = contentValuesOf(
-        MangaTable.COL_FILTERED_SCANLATORS to manga.filtered_scanlators
-    )
-}

app/src/main/java/eu/kanade/tachiyomi/data/database/resolvers/MangaFlagsPutResolver.kt

@@ -8,9 +8,8 @@ import com.pushtorefresh.storio.sqlite.queries.UpdateQuery
 import eu.kanade.tachiyomi.data.database.inTransactionReturn
 import eu.kanade.tachiyomi.data.database.models.Manga
 import eu.kanade.tachiyomi.data.database.tables.MangaTable
-import kotlin.reflect.KProperty1
 
-class MangaFlagsPutResolver(private val colName: String, private val fieldGetter: KProperty1<Manga, Int>, private val updateAll: Boolean = false) : PutResolver<Manga>() {
+class MangaFlagsPutResolver(private val updateAll: Boolean = false) : PutResolver<Manga>() {
 
     override fun performPut(db: StorIOSQLite, manga: Manga) = db.inTransactionReturn {
         val updateQuery = mapToUpdateQuery(manga)
@@ -38,6 +37,6 @@ class MangaFlagsPutResolver(private val colName: String, private val fieldGetter
 
     fun mapToContentValues(manga: Manga) =
         contentValuesOf(
-            colName to fieldGetter.get(manga)
+            MangaTable.COL_CHAPTER_FLAGS to manga.chapter_flags
         )
 }

app/src/main/java/eu/kanade/tachiyomi/data/database/resolvers/MangaInfoPutResolver.kt

@@ -1,5 +1,6 @@
 package eu.kanade.tachiyomi.data.database.resolvers
 
+import android.content.ContentValues
 import androidx.core.content.contentValuesOf
 import com.pushtorefresh.storio.sqlite.StorIOSQLite
 import com.pushtorefresh.storio.sqlite.operations.put.PutResolver
@@ -8,7 +9,6 @@ import com.pushtorefresh.storio.sqlite.queries.UpdateQuery
 import eu.kanade.tachiyomi.data.database.inTransactionReturn
 import eu.kanade.tachiyomi.data.database.models.Manga
 import eu.kanade.tachiyomi.data.database.tables.MangaTable
-import exh.util.nullIfZero
 
 class MangaInfoPutResolver(val reset: Boolean = false) : PutResolver<Manga>() {
 
@@ -31,20 +31,15 @@ class MangaInfoPutResolver(val reset: Boolean = false) : PutResolver<Manga>() {
         MangaTable.COL_GENRE to manga.originalGenre,
         MangaTable.COL_AUTHOR to manga.originalAuthor,
         MangaTable.COL_ARTIST to manga.originalArtist,
-        MangaTable.COL_DESCRIPTION to manga.originalDescription,
+        MangaTable.COL_DESCRIPTION to manga.originalDescription
-        MangaTable.COL_STATUS to manga.originalStatus
     )
 
-    private fun resetToContentValues(manga: Manga) = contentValuesOf(
+    fun resetToContentValues(manga: Manga) = ContentValues(1).apply {
-        MangaTable.COL_TITLE to manga.title.split(splitter).last(),
+        val splitter = "▒ ▒∩▒"
-        MangaTable.COL_GENRE to manga.genre?.split(splitter)?.lastOrNull(),
+        put(MangaTable.COL_TITLE, manga.title.split(splitter).last())
-        MangaTable.COL_AUTHOR to manga.author?.split(splitter)?.lastOrNull(),
+        put(MangaTable.COL_GENRE, manga.genre?.split(splitter)?.lastOrNull())
-        MangaTable.COL_ARTIST to manga.artist?.split(splitter)?.lastOrNull(),
+        put(MangaTable.COL_AUTHOR, manga.author?.split(splitter)?.lastOrNull())
-        MangaTable.COL_DESCRIPTION to manga.description?.split(splitter)?.lastOrNull(),
+        put(MangaTable.COL_ARTIST, manga.artist?.split(splitter)?.lastOrNull())
-        MangaTable.COL_STATUS to manga.status.nullIfZero()?.toString()?.split(splitter)?.lastOrNull()
+        put(MangaTable.COL_DESCRIPTION, manga.description?.split(splitter)?.lastOrNull())
-    )
-
-    companion object {
-        const val splitter = "▒ ▒∩▒"
     }
 }

app/src/main/java/eu/kanade/tachiyomi/data/database/resolvers/MangaMigrationPutResolver.kt

@@ -30,6 +30,6 @@ class MangaMigrationPutResolver : PutResolver<Manga>() {
         MangaTable.COL_DATE_ADDED to manga.date_added,
         MangaTable.COL_TITLE to manga.title,
         MangaTable.COL_CHAPTER_FLAGS to manga.chapter_flags,
-        MangaTable.COL_VIEWER to manga.viewer_flags
+        MangaTable.COL_VIEWER to manga.viewer
     )
 }

app/src/main/java/eu/kanade/tachiyomi/data/database/resolvers/MangaViewerPutResolver.kt

@@ -9,8 +9,7 @@ import eu.kanade.tachiyomi.data.database.inTransactionReturn
 import eu.kanade.tachiyomi.data.database.models.Manga
 import eu.kanade.tachiyomi.data.database.tables.MangaTable
 
-// SY
+class MangaViewerPutResolver : PutResolver<Manga>() {
-class MangaThumbnailPutResolver : PutResolver<Manga>() {
 
     override fun performPut(db: StorIOSQLite, manga: Manga) = db.inTransactionReturn {
         val updateQuery = mapToUpdateQuery(manga)
@@ -26,7 +25,8 @@ class MangaThumbnailPutResolver : PutResolver<Manga>() {
         .whereArgs(manga.id)
         .build()
 
-    fun mapToContentValues(manga: Manga) = contentValuesOf(
+    fun mapToContentValues(manga: Manga) =
-        MangaTable.COL_THUMBNAIL_URL to manga.thumbnail_url
+        contentValuesOf(
-    )
+            MangaTable.COL_VIEWER to manga.viewer
+        )
 }

app/src/main/java/eu/kanade/tachiyomi/data/database/tables/MangaTable.kt

@@ -40,8 +40,6 @@ object MangaTable {
 
     // SY ->>
     const val COL_READ = "read"
-
-    const val COL_FILTERED_SCANLATORS = "filtered_scanlators"
     // SY <--
 
     const val COL_CATEGORY = "category"
@@ -67,8 +65,7 @@ object MangaTable {
             $COL_VIEWER INTEGER NOT NULL,
             $COL_CHAPTER_FLAGS INTEGER NOT NULL,
             $COL_COVER_LAST_MODIFIED LONG NOT NULL,
-            $COL_DATE_ADDED LONG NOT NULL,
+            $COL_DATE_ADDED LONG NOT NULL
-            $COL_FILTERED_SCANLATORS TEXT
             )"""
 
     val createUrlIndexQuery: String
@@ -93,7 +90,4 @@ object MangaTable {
             "FROM $TABLE INNER JOIN ${ChapterTable.TABLE} " +
             "ON $TABLE.$COL_ID = ${ChapterTable.TABLE}.${ChapterTable.COL_MANGA_ID} " +
             "GROUP BY $TABLE.$COL_ID)"
-
-    val addFilteredScanlators: String
-        get() = "ALTER TABLE $TABLE ADD COLUMN $COL_FILTERED_SCANLATORS TEXT"
 }

app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadManager.kt

@@ -12,7 +12,6 @@ import eu.kanade.tachiyomi.data.preference.PreferencesHelper
 import eu.kanade.tachiyomi.source.Source
 import eu.kanade.tachiyomi.source.SourceManager
 import eu.kanade.tachiyomi.source.model.Page
-import eu.kanade.tachiyomi.util.lang.launchIO
 import rx.Observable
 import timber.log.Timber
 import uy.kohesive.injekt.injectLazy
@@ -24,7 +23,7 @@ import uy.kohesive.injekt.injectLazy
  *
  * @param context the application context.
  */
-class DownloadManager(private val context: Context) {
+class DownloadManager(/* SY private */ val context: Context) {
 
     private val sourceManager: SourceManager by injectLazy()
     private val preferences: PreferencesHelper by injectLazy()
@@ -203,15 +202,6 @@ class DownloadManager(private val context: Context) {
         deleteChapters(listOf(download.chapter), download.manga, download.source)
     }
 
-    fun deletePendingDownloads(vararg downloads: Download) {
-        val downloadsByManga = downloads.groupBy { it.manga.id }
-        downloadsByManga.map { entry ->
-            val manga = entry.value.first().manga
-            val source = entry.value.first().source
-            deleteChapters(entry.value.map { it.chapter }, manga, source)
-        }
-    }
-
     /**
      * Deletes the directories of a list of downloaded chapters.
      *
@@ -221,16 +211,16 @@ class DownloadManager(private val context: Context) {
      */
     fun deleteChapters(chapters: List<Chapter>, manga: Manga, source: Source): List<Chapter> {
         val filteredChapters = getChaptersToDelete(chapters)
-        launchIO {
-            removeFromDownloadQueue(filteredChapters)
 
-            val chapterDirs = provider.findChapterDirs(filteredChapters, manga, source)
+        removeFromDownloadQueue(filteredChapters)
-            chapterDirs.forEach { it.delete() }
+
-            cache.removeChapters(filteredChapters, manga)
+        val chapterDirs = provider.findChapterDirs(filteredChapters, manga, source)
-            if (cache.getDownloadCount(manga) == 0) { // Delete manga directory if empty
+        chapterDirs.forEach { it.delete() }
-                chapterDirs.firstOrNull()?.parentFile?.delete()
+        cache.removeChapters(filteredChapters, manga)
-            }
+        if (cache.getDownloadCount(manga) == 0) { // Delete manga directory if empty
+            chapterDirs.firstOrNull()?.parentFile?.delete()
         }
+
         return filteredChapters
     }
 
@@ -272,7 +262,7 @@ class DownloadManager(private val context: Context) {
 
         if (removeNonFavorite && !manga.favorite) {
             val mangaFolder = provider.getMangaDir(manga, source)
-            cleaned += 1 + mangaFolder.listFiles().orEmpty().size
+            cleaned += 1 + (mangaFolder.listFiles()?.size ?: 0)
             mangaFolder.delete()
             cache.removeManga(manga)
             return cleaned
@@ -293,7 +283,8 @@ class DownloadManager(private val context: Context) {
 
         if (cache.getDownloadCount(manga) == 0) {
             val mangaFolder = provider.getMangaDir(manga, source)
-            if (!mangaFolder.listFiles().isNullOrEmpty()) {
+            val size = mangaFolder.listFiles()?.size ?: 0
+            if (size == 0) {
                 mangaFolder.delete()
                 cache.removeManga(manga)
             } else {
@@ -311,11 +302,9 @@ class DownloadManager(private val context: Context) {
      * @param source the source of the manga.
      */
     fun deleteManga(manga: Manga, source: Source) {
-        launchIO {
+        downloader.queue.remove(manga)
-            downloader.queue.remove(manga)
+        provider.findMangaDir(manga, source)?.delete()
-            provider.findMangaDir(manga, source)?.delete()
+        cache.removeManga(manga)
-            cache.removeManga(manga)
-        }
     }
 
     /**

app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadNotifier.kt

@@ -27,8 +27,6 @@ internal class DownloadNotifier(private val context: Context) {
     private val progressNotificationBuilder by lazy {
         context.notificationBuilder(Notifications.CHANNEL_DOWNLOADER_PROGRESS) {
             setLargeIcon(BitmapFactory.decodeResource(context.resources, R.mipmap.ic_launcher))
-            setAutoCancel(false)
-            setOnlyAlertOnce(true)
         }
     }
 
@@ -83,8 +81,10 @@ internal class DownloadNotifier(private val context: Context) {
      */
     fun onProgressChange(download: Download) {
         with(progressNotificationBuilder) {
+            // Check if first call.
             if (!isDownloading) {
                 setSmallIcon(android.R.drawable.stat_sys_download)
+                setAutoCancel(false)
                 clearActions()
                 // Open download manager when clicked
                 setContentIntent(NotificationHandler.openDownloadManagerPendingActivity(context))
@@ -114,7 +114,6 @@ internal class DownloadNotifier(private val context: Context) {
             }
 
             setProgress(download.pages!!.size, download.downloadedImages, false)
-            setOngoing(true)
 
             show(Notifications.ID_DOWNLOAD_CHAPTER_PROGRESS)
         }
@@ -128,8 +127,8 @@ internal class DownloadNotifier(private val context: Context) {
             setContentTitle(context.getString(R.string.chapter_paused))
             setContentText(context.getString(R.string.download_notifier_download_paused))
             setSmallIcon(R.drawable.ic_pause_24dp)
+            setAutoCancel(false)
             setProgress(0, 0, false)
-            setOngoing(false)
             clearActions()
             // Open download manager when clicked
             setContentIntent(NotificationHandler.openDownloadManagerPendingActivity(context))
@@ -218,6 +217,7 @@ internal class DownloadNotifier(private val context: Context) {
             setContentText(error ?: context.getString(R.string.download_notifier_unknown_error))
             setSmallIcon(android.R.drawable.stat_sys_warning)
             clearActions()
+            setAutoCancel(false)
             setContentIntent(NotificationHandler.openDownloadManagerPendingActivity(context))
             setProgress(0, 0, false)
 

app/src/main/java/eu/kanade/tachiyomi/data/download/DownloadProvider.kt

@@ -53,8 +53,8 @@ class DownloadProvider(private val context: Context) {
             return downloadsDir
                 .createDirectory(getSourceDirName(source))
                 .createDirectory(getMangaDirName(manga))
-        } catch (e: Throwable) {
+        } catch (e: NullPointerException) {
-            Timber.e(e, "Invalid download directory")
+            Timber.w(e)
             throw Exception(context.getString(R.string.invalid_download_dir))
         }
     }
@@ -65,7 +65,7 @@ class DownloadProvider(private val context: Context) {
      * @param source the source to query.
      */
     fun findSourceDir(source: Source): UniFile? {
-        return downloadsDir.findFile(getSourceDirName(source), true)
+        return downloadsDir.findFile(getSourceDirName(source))
     }
 
     /**
@@ -76,7 +76,7 @@ class DownloadProvider(private val context: Context) {
      */
     fun findMangaDir(manga: Manga, source: Source): UniFile? {
         val sourceDir = findSourceDir(source)
-        return sourceDir?.findFile(getMangaDirName(manga), true)
+        return sourceDir?.findFile(getMangaDirName(manga))
     }
 
     /**
@@ -89,7 +89,7 @@ class DownloadProvider(private val context: Context) {
     fun findChapterDir(chapter: Chapter, manga: Manga, source: Source): UniFile? {
         val mangaDir = findMangaDir(manga, source)
         return getValidChapterDirNames(chapter).asSequence()
-            .mapNotNull { mangaDir?.findFile(it, true) ?: mangaDir?.findFile("$it.cbz", true) }
+            .mapNotNull { mangaDir?.findFile(it) ?: mangaDir?.findFile("$it.cbz") }
             .firstOrNull()
     }
 
@@ -123,12 +123,14 @@ class DownloadProvider(private val context: Context) {
         source: Source
     ): List<UniFile> {
         val mangaDir = findMangaDir(manga, source) ?: return emptyList()
-        return mangaDir.listFiles().orEmpty().asList().filter {
+        return mangaDir.listFiles()!!.asList().filter {
-            chapters.find { chp ->
+            (
-                getValidChapterDirNames(chp).any { dir ->
+                chapters.find { chp ->
-                    mangaDir.findFile(dir) ?: mangaDir.findFile("$dir.cbz") != null
+                    getValidChapterDirNames(chp).any { dir ->
-                }
+                        mangaDir.findFile(dir) ?: mangaDir.findFile("$dir.cbz") != null
-            } == null || it.name?.endsWith(Downloader.TMP_DIR_SUFFIX) == true
+                    }
+                } == null
+                ) || it.name?.endsWith(Downloader.TMP_DIR_SUFFIX) == true
         }
     }
     // SY <--
@@ -139,7 +141,7 @@ class DownloadProvider(private val context: Context) {
      * @param source the source to query.
      */
     fun getSourceDirName(source: Source): String {
-        return DiskUtil.buildValidFilename(source.toString())
+        return source.toString()
     }
 
     /**
@@ -176,7 +178,6 @@ class DownloadProvider(private val context: Context) {
         return listOf(
             getChapterDirName(chapter),
 
-            // TODO: remove this
             // Legacy chapter directory name used in v0.9.2 and before
             DiskUtil.buildValidFilename(chapter.name)
         )

app/src/main/java/eu/kanade/tachiyomi/data/glide/FileFetcher.kt

@@ -0,0 +1,60 @@
+package eu.kanade.tachiyomi.data.glide
+
+import android.content.ContentValues.TAG
+import android.util.Log
+import com.bumptech.glide.Priority
+import com.bumptech.glide.load.DataSource
+import com.bumptech.glide.load.data.DataFetcher
+import timber.log.Timber
+import java.io.File
+import java.io.FileInputStream
+import java.io.FileNotFoundException
+import java.io.IOException
+import java.io.InputStream
+
+open class FileFetcher(private val filePath: String = "") : DataFetcher<InputStream> {
+
+    private var data: InputStream? = null
+
+    override fun loadData(priority: Priority, callback: DataFetcher.DataCallback<in InputStream>) {
+        loadFromFile(callback)
+    }
+
+    private fun loadFromFile(callback: DataFetcher.DataCallback<in InputStream>) {
+        loadFromFile(File(filePath), callback)
+    }
+
+    protected fun loadFromFile(file: File, callback: DataFetcher.DataCallback<in InputStream>) {
+        try {
+            data = FileInputStream(file)
+        } catch (e: FileNotFoundException) {
+            if (Log.isLoggable(TAG, Log.DEBUG)) {
+                Timber.d(e, "Failed to open file")
+            }
+            callback.onLoadFailed(e)
+            return
+        }
+
+        callback.onDataReady(data)
+    }
+
+    override fun cleanup() {
+        try {
+            data?.close()
+        } catch (e: IOException) {
+            // Ignored.
+        }
+    }
+
+    override fun cancel() {
+        // Do nothing.
+    }
+
+    override fun getDataClass(): Class<InputStream> {
+        return InputStream::class.java
+    }
+
+    override fun getDataSource(): DataSource {
+        return DataSource.LOCAL
+    }
+}

app/src/main/java/eu/kanade/tachiyomi/data/glide/LibraryMangaCustomCoverFetcher.kt

@@ -0,0 +1,25 @@
+package eu.kanade.tachiyomi.data.glide
+
+import com.bumptech.glide.Priority
+import com.bumptech.glide.load.data.DataFetcher
+import eu.kanade.tachiyomi.data.cache.CoverCache
+import eu.kanade.tachiyomi.data.database.models.Manga
+import java.io.File
+import java.io.InputStream
+import java.lang.Exception
+
+open class LibraryMangaCustomCoverFetcher(
+    private val manga: Manga,
+    private val coverCache: CoverCache
+) : FileFetcher() {
+
+    override fun loadData(priority: Priority, callback: DataFetcher.DataCallback<in InputStream>) {
+        getCustomCoverFile()?.let {
+            loadFromFile(it, callback)
+        } ?: callback.onLoadFailed(Exception("Custom cover file not found"))
+    }
+
+    protected fun getCustomCoverFile(): File? {
+        return coverCache.getCustomCoverFile(manga).takeIf { it.exists() }
+    }
+}

app/src/main/java/eu/kanade/tachiyomi/data/glide/LibraryMangaUrlFetcher.kt

@@ -0,0 +1,86 @@
+package eu.kanade.tachiyomi.data.glide
+
+import com.bumptech.glide.Priority
+import com.bumptech.glide.load.data.DataFetcher
+import eu.kanade.tachiyomi.data.cache.CoverCache
+import eu.kanade.tachiyomi.data.database.models.Manga
+import java.io.File
+import java.io.FileNotFoundException
+import java.io.InputStream
+
+/**
+ * A [DataFetcher] for loading a cover of a library manga.
+ * It tries to load the cover from our custom cache, and if it's not found, it fallbacks to network
+ * and copies the result to the cache.
+ *
+ * @param networkFetcher the network fetcher for this cover.
+ * @param manga the manga of the cover to load.
+ * @param file the file where this cover should be. It may exists or not.
+ */
+class LibraryMangaUrlFetcher(
+    private val networkFetcher: DataFetcher<InputStream>,
+    private val manga: Manga,
+    private val coverCache: CoverCache
+) : LibraryMangaCustomCoverFetcher(manga, coverCache) {
+
+    override fun loadData(priority: Priority, callback: DataFetcher.DataCallback<in InputStream>) {
+        getCustomCoverFile()?.let {
+            loadFromFile(it, callback)
+            return
+        }
+
+        val cover = coverCache.getCoverFile(manga)
+        if (cover == null) {
+            callback.onLoadFailed(Exception("Null thumbnail url"))
+            return
+        }
+
+        if (!cover.exists()) {
+            networkFetcher.loadData(
+                priority,
+                object : DataFetcher.DataCallback<InputStream> {
+                    override fun onDataReady(data: InputStream?) {
+                        if (data != null) {
+                            val tmpFile = File(cover.path + ".tmp")
+                            try {
+                                // Retrieve destination stream, create parent folders if needed.
+                                val output = try {
+                                    tmpFile.outputStream()
+                                } catch (e: FileNotFoundException) {
+                                    tmpFile.parentFile!!.mkdirs()
+                                    tmpFile.outputStream()
+                                }
+
+                                // Copy the file and rename to the original.
+                                data.use { output.use { data.copyTo(output) } }
+                                tmpFile.renameTo(cover)
+                                loadFromFile(cover, callback)
+                            } catch (e: Exception) {
+                                tmpFile.delete()
+                                callback.onLoadFailed(e)
+                            }
+                        } else {
+                            callback.onLoadFailed(Exception("Null data"))
+                        }
+                    }
+
+                    override fun onLoadFailed(e: Exception) {
+                        callback.onLoadFailed(e)
+                    }
+                }
+            )
+        } else {
+            loadFromFile(cover, callback)
+        }
+    }
+
+    override fun cleanup() {
+        super.cleanup()
+        networkFetcher.cleanup()
+    }
+
+    override fun cancel() {
+        super.cancel()
+        networkFetcher.cancel()
+    }
+}

app/src/main/java/eu/kanade/tachiyomi/data/glide/MangaThumbnail.kt

@@ -0,0 +1,15 @@
+package eu.kanade.tachiyomi.data.glide
+
+import com.bumptech.glide.load.Key
+import eu.kanade.tachiyomi.data.database.models.Manga
+import java.security.MessageDigest
+
+data class MangaThumbnail(val manga: Manga, val coverLastModified: Long) : Key {
+    val key = manga.url + coverLastModified
+
+    override fun updateDiskCacheKey(messageDigest: MessageDigest) {
+        messageDigest.update(key.toByteArray(Key.CHARSET))
+    }
+}
+
+fun Manga.toMangaThumbnail() = MangaThumbnail(this, cover_last_modified)

app/src/main/java/eu/kanade/tachiyomi/data/glide/MangaThumbnailModelLoader.kt

@@ -0,0 +1,134 @@
+package eu.kanade.tachiyomi.data.glide
+
+import com.bumptech.glide.integration.okhttp3.OkHttpStreamFetcher
+import com.bumptech.glide.load.Options
+import com.bumptech.glide.load.model.GlideUrl
+import com.bumptech.glide.load.model.Headers
+import com.bumptech.glide.load.model.LazyHeaders
+import com.bumptech.glide.load.model.ModelLoader
+import com.bumptech.glide.load.model.ModelLoaderFactory
+import com.bumptech.glide.load.model.MultiModelLoaderFactory
+import eu.kanade.tachiyomi.data.cache.CoverCache
+import eu.kanade.tachiyomi.data.database.models.Manga
+import eu.kanade.tachiyomi.network.NetworkHelper
+import eu.kanade.tachiyomi.source.SourceManager
+import eu.kanade.tachiyomi.source.online.HttpSource
+import eu.kanade.tachiyomi.util.isLocal
+import uy.kohesive.injekt.Injekt
+import uy.kohesive.injekt.api.get
+import uy.kohesive.injekt.injectLazy
+import java.io.InputStream
+
+/**
+ * A class for loading a cover associated with a [Manga] that can be present in our own cache.
+ * Coupled with [LibraryMangaUrlFetcher], this class allows to implement the following flow:
+ *
+ * - Check in RAM LRU.
+ * - Check in disk LRU.
+ * - Check in this module.
+ * - Fetch from the network connection.
+ *
+ * @param context the application context.
+ */
+class MangaThumbnailModelLoader : ModelLoader<MangaThumbnail, InputStream> {
+
+    /**
+     * Cover cache where persistent covers are stored.
+     */
+    private val coverCache: CoverCache by injectLazy()
+
+    /**
+     * Source manager.
+     */
+    private val sourceManager: SourceManager by injectLazy()
+
+    /**
+     * Default network client.
+     */
+    private val defaultClient = Injekt.get<NetworkHelper>().client
+
+    /**
+     * Map where request headers are stored for a source.
+     */
+    private val cachedHeaders = hashMapOf<Long, LazyHeaders>()
+
+    /**
+     * Factory class for creating [MangaThumbnailModelLoader] instances.
+     */
+    class Factory : ModelLoaderFactory<MangaThumbnail, InputStream> {
+
+        override fun build(multiFactory: MultiModelLoaderFactory): ModelLoader<MangaThumbnail, InputStream> {
+            return MangaThumbnailModelLoader()
+        }
+
+        override fun teardown() {}
+    }
+
+    override fun handles(model: MangaThumbnail): Boolean {
+        return true
+    }
+
+    /**
+     * Returns a fetcher for the given manga or null if the url is empty.
+     *
+     * @param mangaThumbnail the model.
+     * @param width the width of the view where the resource will be loaded.
+     * @param height the height of the view where the resource will be loaded.
+     */
+    override fun buildLoadData(
+        mangaThumbnail: MangaThumbnail,
+        width: Int,
+        height: Int,
+        options: Options
+    ): ModelLoader.LoadData<InputStream>? {
+        val manga = mangaThumbnail.manga
+        val url = manga.thumbnail_url
+
+        if (url.isNullOrEmpty()) {
+            return if (!manga.favorite || manga.isLocal()) {
+                null
+            } else {
+                ModelLoader.LoadData(mangaThumbnail, LibraryMangaCustomCoverFetcher(manga, coverCache))
+            }
+        }
+
+        if (url.startsWith("http", true)) {
+            val source = sourceManager.get(manga.source) as? HttpSource
+            val glideUrl = GlideUrl(url, getHeaders(manga, source))
+
+            // Get the resource fetcher for this request url.
+            val networkFetcher = OkHttpStreamFetcher(source?.client ?: defaultClient, glideUrl)
+
+            if (!manga.favorite) {
+                return ModelLoader.LoadData(glideUrl, networkFetcher)
+            }
+
+            val libraryFetcher = LibraryMangaUrlFetcher(networkFetcher, manga, coverCache)
+
+            // Return an instance of the fetcher providing the needed elements.
+            return ModelLoader.LoadData(mangaThumbnail, libraryFetcher)
+        } else {
+            // Return an instance of the fetcher providing the needed elements.
+            return ModelLoader.LoadData(mangaThumbnail, FileFetcher(url.removePrefix("file://")))
+        }
+    }
+
+    /**
+     * Returns the request headers for a source copying its OkHttp headers and caching them.
+     *
+     * @param manga the model.
+     */
+    private fun getHeaders(manga: Manga, source: HttpSource?): Headers {
+        if (source == null) return LazyHeaders.DEFAULT
+
+        return cachedHeaders.getOrPut(manga.source) {
+            LazyHeaders.Builder().apply {
+                val nullStr: String? = null
+                setHeader("User-Agent", nullStr)
+                for ((key, value) in source.headers.toMultimap()) {
+                    addHeader(key, value[0])
+                }
+            }.build()
+        }
+    }
+}

app/src/main/java/eu/kanade/tachiyomi/data/glide/PassthroughModelLoader.kt

@@ -0,0 +1,72 @@
+package eu.kanade.tachiyomi.data.glide
+
+import com.bumptech.glide.Priority
+import com.bumptech.glide.load.DataSource
+import com.bumptech.glide.load.Options
+import com.bumptech.glide.load.data.DataFetcher
+import com.bumptech.glide.load.model.ModelLoader
+import com.bumptech.glide.load.model.ModelLoaderFactory
+import com.bumptech.glide.load.model.MultiModelLoaderFactory
+import com.bumptech.glide.signature.ObjectKey
+import java.io.IOException
+import java.io.InputStream
+
+class PassthroughModelLoader : ModelLoader<InputStream, InputStream> {
+
+    override fun buildLoadData(
+        model: InputStream,
+        width: Int,
+        height: Int,
+        options: Options
+    ): ModelLoader.LoadData<InputStream>? {
+        return ModelLoader.LoadData(ObjectKey(model), Fetcher(model))
+    }
+
+    override fun handles(model: InputStream): Boolean {
+        return true
+    }
+
+    class Fetcher(private val stream: InputStream) : DataFetcher<InputStream> {
+
+        override fun getDataClass(): Class<InputStream> {
+            return InputStream::class.java
+        }
+
+        override fun cleanup() {
+            try {
+                stream.close()
+            } catch (e: IOException) {
+                // Do nothing
+            }
+        }
+
+        override fun getDataSource(): DataSource {
+            return DataSource.LOCAL
+        }
+
+        override fun cancel() {
+            // Do nothing
+        }
+
+        override fun loadData(
+            priority: Priority,
+            callback: DataFetcher.DataCallback<in InputStream>
+        ) {
+            callback.onDataReady(stream)
+        }
+    }
+
+    /**
+     * Factory class for creating [PassthroughModelLoader] instances.
+     */
+    class Factory : ModelLoaderFactory<InputStream, InputStream> {
+
+        override fun build(
+            multiFactory: MultiModelLoaderFactory
+        ): ModelLoader<InputStream, InputStream> {
+            return PassthroughModelLoader()
+        }
+
+        override fun teardown() {}
+    }
+}

app/src/main/java/eu/kanade/tachiyomi/data/glide/TachiGlideModule.kt

@@ -0,0 +1,55 @@
+package eu.kanade.tachiyomi.data.glide
+
+import android.content.Context
+import android.graphics.drawable.Drawable
+import com.bumptech.glide.Glide
+import com.bumptech.glide.GlideBuilder
+import com.bumptech.glide.Registry
+import com.bumptech.glide.annotation.GlideModule
+import com.bumptech.glide.integration.okhttp3.OkHttpUrlLoader
+import com.bumptech.glide.load.DecodeFormat
+import com.bumptech.glide.load.engine.cache.InternalCacheDiskCacheFactory
+import com.bumptech.glide.load.model.GlideUrl
+import com.bumptech.glide.load.resource.drawable.DrawableTransitionOptions
+import com.bumptech.glide.module.AppGlideModule
+import com.bumptech.glide.request.RequestOptions
+import eu.kanade.tachiyomi.network.NetworkHelper
+import uy.kohesive.injekt.Injekt
+import uy.kohesive.injekt.api.get
+import java.io.InputStream
+
+/**
+ * Class used to update Glide module settings
+ */
+@GlideModule
+class TachiGlideModule : AppGlideModule() {
+
+    override fun applyOptions(context: Context, builder: GlideBuilder) {
+        builder.setDiskCache(InternalCacheDiskCacheFactory(context, 50 * 1024 * 1024))
+        builder.setDefaultRequestOptions(RequestOptions().format(DecodeFormat.PREFER_RGB_565))
+        builder.setDefaultTransitionOptions(
+            Drawable::class.java,
+            DrawableTransitionOptions.withCrossFade()
+        )
+    }
+
+    override fun registerComponents(context: Context, glide: Glide, registry: Registry) {
+        val networkFactory = OkHttpUrlLoader.Factory(Injekt.get<NetworkHelper>().client)
+
+        registry.replace(
+            GlideUrl::class.java,
+            InputStream::class.java,
+            networkFactory
+        )
+        registry.append(
+            MangaThumbnail::class.java,
+            InputStream::class.java,
+            MangaThumbnailModelLoader.Factory()
+        )
+        registry.append(
+            InputStream::class.java,
+            InputStream::class.java,
+            PassthroughModelLoader.Factory()
+        )
+    }
+}

app/src/main/java/eu/kanade/tachiyomi/data/library/CustomMangaManager.kt

@@ -8,6 +8,7 @@ import kotlinx.serialization.decodeFromString
 import kotlinx.serialization.encodeToString
 import kotlinx.serialization.json.Json
 import java.io.File
+import java.util.Scanner
 
 class CustomMangaManager(val context: Context) {
 
@@ -22,7 +23,7 @@ class CustomMangaManager(val context: Context) {
 
         val json = try {
             Json.decodeFromString<MangaList>(
-                editJson.bufferedReader().use { it.readText() }
+                Scanner(editJson).useDelimiter("\\Z").next()
             )
         } catch (e: Exception) {
             null
@@ -31,15 +32,30 @@ class CustomMangaManager(val context: Context) {
         val mangasJson = json.mangas ?: return mutableMapOf()
         return mangasJson.mapNotNull { mangaJson ->
             val id = mangaJson.id ?: return@mapNotNull null
-            id to mangaJson.toManga()
+            val manga = MangaImpl().apply {
+                this.id = id
+                title = mangaJson.title ?: ""
+                author = mangaJson.author
+                artist = mangaJson.artist
+                description = mangaJson.description
+                genre = mangaJson.genre?.joinToString(", ")
+            }
+            id to manga
         }.toMap().toMutableMap()
     }
 
     fun saveMangaInfo(manga: MangaJson) {
-        if (manga.title == null && manga.author == null && manga.artist == null && manga.description == null && manga.genre == null && manga.status == null) {
+        if (manga.title == null && manga.author == null && manga.artist == null && manga.description == null && manga.genre == null) {
             customMangaMap.remove(manga.id!!)
         } else {
-            customMangaMap[manga.id!!] = manga.toManga()
+            customMangaMap[manga.id!!] = MangaImpl().apply {
+                id = manga.id
+                title = manga.title ?: ""
+                author = manga.author
+                artist = manga.artist
+                description = manga.description
+                genre = manga.genre?.joinToString(", ")
+            }
         }
         saveCustomInfo()
     }
@@ -59,8 +75,7 @@ class CustomMangaManager(val context: Context) {
             author,
             artist,
             description,
-            genre?.split(", "),
+            genre?.split(", ")
-            status
         )
     }
 
@@ -71,23 +86,24 @@ class CustomMangaManager(val context: Context) {
 
     @Serializable
     data class MangaJson(
-        var id: Long? = null,
+        val id: Long? = null,
         val title: String? = null,
         val author: String? = null,
         val artist: String? = null,
         val description: String? = null,
-        val genre: List<String>? = null,
+        val genre: List<String>? = null
-        val status: Int? = null
     ) {
 
-        fun toManga() = MangaImpl().apply {
+        override fun equals(other: Any?): Boolean {
-            id = this@MangaJson.id
+            if (this === other) return true
-            title = this@MangaJson.title ?: ""
+            if (javaClass != other?.javaClass) return false
-            author = this@MangaJson.author
+            other as MangaJson
-            artist = this@MangaJson.artist
+            if (id != other.id) return false
-            description = this@MangaJson.description
+            return true
-            genre = this@MangaJson.genre?.joinToString(", ")
+        }
-            status = this@MangaJson.status ?: 0
+
+        override fun hashCode(): Int {
+            return id.hashCode()
         }
     }
 }

app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateJob.kt

@@ -8,9 +8,7 @@ import androidx.work.PeriodicWorkRequestBuilder
 import androidx.work.WorkManager
 import androidx.work.Worker
 import androidx.work.WorkerParameters
-import eu.kanade.tachiyomi.data.preference.CHARGING
 import eu.kanade.tachiyomi.data.preference.PreferencesHelper
-import eu.kanade.tachiyomi.data.preference.UNMETERED_NETWORK
 import uy.kohesive.injekt.Injekt
 import uy.kohesive.injekt.api.get
 import java.util.concurrent.TimeUnit
@@ -33,9 +31,9 @@ class LibraryUpdateJob(private val context: Context, workerParams: WorkerParamet
             val preferences = Injekt.get<PreferencesHelper>()
             val interval = prefInterval ?: preferences.libraryUpdateInterval().get()
             if (interval > 0) {
-                val restrictions = preferences.libraryUpdateRestriction().get()
+                val restrictions = preferences.libraryUpdateRestriction()!!
-                val acRestriction = CHARGING in restrictions
+                val acRestriction = "ac" in restrictions
-                val wifiRestriction = if (UNMETERED_NETWORK in restrictions) {
+                val wifiRestriction = if ("wifi" in restrictions) {
                     NetworkType.UNMETERED
                 } else {
                     NetworkType.CONNECTED

app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateNotifier.kt

@@ -6,23 +6,20 @@ import android.content.Context
 import android.content.Intent
 import android.graphics.Bitmap
 import android.graphics.BitmapFactory
-import android.graphics.drawable.BitmapDrawable
 import android.net.Uri
 import androidx.core.app.NotificationCompat
 import androidx.core.app.NotificationManagerCompat
-import coil.imageLoader
+import com.bumptech.glide.Glide
-import coil.request.ImageRequest
-import coil.transform.CircleCropTransformation
 import eu.kanade.tachiyomi.R
 import eu.kanade.tachiyomi.data.database.models.Chapter
 import eu.kanade.tachiyomi.data.database.models.Manga
+import eu.kanade.tachiyomi.data.glide.toMangaThumbnail
 import eu.kanade.tachiyomi.data.notification.NotificationReceiver
 import eu.kanade.tachiyomi.data.notification.Notifications
 import eu.kanade.tachiyomi.data.preference.PreferencesHelper
 import eu.kanade.tachiyomi.source.model.SManga
 import eu.kanade.tachiyomi.ui.main.MainActivity
 import eu.kanade.tachiyomi.util.lang.chop
-import eu.kanade.tachiyomi.util.lang.launchUI
 import eu.kanade.tachiyomi.util.system.notification
 import eu.kanade.tachiyomi.util.system.notificationBuilder
 import eu.kanade.tachiyomi.util.system.notificationManager
@@ -79,8 +76,7 @@ class LibraryUpdateNotifier(private val context: Context) {
         context.notificationManager.notify(
             Notifications.ID_LIBRARY_PROGRESS,
             progressNotificationBuilder
-                .setContentTitle(title.chop(40))
+                .setContentTitle(title)
-                .setContentText("($current/$total)")
                 .setProgress(total, current, false)
                 .build()
         )
@@ -115,7 +111,7 @@ class LibraryUpdateNotifier(private val context: Context) {
                 setContentIntent(errorLogIntent)
                 addAction(
                     R.drawable.ic_folder_24dp,
-                    context.getString(R.string.action_show_errors),
+                    context.getString(R.string.action_open_log),
                     errorLogIntent
                 )
             }
@@ -170,17 +166,14 @@ class LibraryUpdateNotifier(private val context: Context) {
 
             // Per-manga notification
             if (!preferences.hideNotificationContent()) {
-                launchUI {
+                updates.forEach { (manga, chapters) ->
-                    updates.forEach { (manga, chapters) ->
+                    notify(manga.id.hashCode(), createNewChaptersNotification(manga, chapters))
-                        notify(manga.id.hashCode(), createNewChaptersNotification(manga, chapters))
-                    }
                 }
             }
         }
     }
 
-    private suspend fun createNewChaptersNotification(manga: Manga, chapters: Array<Chapter>): Notification {
+    private fun createNewChaptersNotification(manga: Manga, chapters: Array<Chapter>): Notification {
-        val icon = getMangaIcon(manga)
         return context.notification(Notifications.CHANNEL_NEW_CHAPTERS) {
             setContentTitle(manga.title)
 
@@ -190,6 +183,7 @@ class LibraryUpdateNotifier(private val context: Context) {
 
             setSmallIcon(R.drawable.ic_tachi)
 
+            val icon = getMangaIcon(manga)
             if (icon != null) {
                 setLargeIcon(icon)
             }
@@ -233,14 +227,23 @@ class LibraryUpdateNotifier(private val context: Context) {
         context.notificationManager.cancel(Notifications.ID_LIBRARY_PROGRESS)
     }
 
-    private suspend fun getMangaIcon(manga: Manga): Bitmap? {
+    private fun getMangaIcon(manga: Manga): Bitmap? {
-        val request = ImageRequest.Builder(context)
+        return try {
-            .data(manga)
+            Glide.with(context)
-            .transformations(CircleCropTransformation())
+                .asBitmap()
-            .size(NOTIF_ICON_SIZE)
+                .load(manga.toMangaThumbnail())
-            .build()
+                .dontTransform()
-        val drawable = context.imageLoader.execute(request).drawable
+                .centerCrop()
-        return (drawable as? BitmapDrawable)?.bitmap
+                .circleCrop()
+                .override(
+                    NOTIF_ICON_SIZE,
+                    NOTIF_ICON_SIZE
+                )
+                .submit()
+                .get()
+        } catch (e: Exception) {
+            null
+        }
     }
 
     private fun getNewChaptersDescription(chapters: Array<Chapter>): String {

app/src/main/java/eu/kanade/tachiyomi/data/library/LibraryUpdateService.kt

@@ -22,18 +22,16 @@ import eu.kanade.tachiyomi.data.notification.Notifications
 import eu.kanade.tachiyomi.data.preference.PreferenceValues
 import eu.kanade.tachiyomi.data.preference.PreferencesHelper
 import eu.kanade.tachiyomi.data.track.TrackManager
-import eu.kanade.tachiyomi.data.track.TrackService
-import eu.kanade.tachiyomi.data.track.UnattendedTrackService
 import eu.kanade.tachiyomi.source.SourceManager
 import eu.kanade.tachiyomi.source.model.SManga
 import eu.kanade.tachiyomi.source.model.toSChapter
 import eu.kanade.tachiyomi.source.model.toSManga
+import eu.kanade.tachiyomi.source.online.all.MangaDex
 import eu.kanade.tachiyomi.source.online.all.MergedSource
 import eu.kanade.tachiyomi.ui.library.LibraryGroup
 import eu.kanade.tachiyomi.ui.manga.track.TrackItem
 import eu.kanade.tachiyomi.util.chapter.NoChaptersException
 import eu.kanade.tachiyomi.util.chapter.syncChaptersWithSource
-import eu.kanade.tachiyomi.util.chapter.syncChaptersWithTrackServiceTwoWay
 import eu.kanade.tachiyomi.util.lang.withIOContext
 import eu.kanade.tachiyomi.util.prepUpdateCover
 import eu.kanade.tachiyomi.util.shouldDownloadNewChapters
@@ -43,11 +41,10 @@ import eu.kanade.tachiyomi.util.system.createFileInCacheDir
 import eu.kanade.tachiyomi.util.system.isServiceRunning
 import exh.md.utils.FollowStatus
 import exh.md.utils.MdUtil
-import exh.metadata.metadata.base.insertFlatMetadataAsync
+import exh.metadata.metadata.base.insertFlatMetadata
 import exh.source.LIBRARY_UPDATE_EXCLUDED_SOURCES
 import exh.source.MERGED_SOURCE_ID
 import exh.source.getMainSource
-import exh.source.isMdBasedSource
 import exh.source.mangaDexSourceIds
 import exh.util.executeOnIO
 import exh.util.nullIfBlank
@@ -91,7 +88,6 @@ class LibraryUpdateService(
     private lateinit var notifier: LibraryUpdateNotifier
     private lateinit var ioScope: CoroutineScope
 
-    private var mangaToUpdate: List<LibraryManga> = mutableListOf()
     private var updateJob: Job? = null
 
     /**
@@ -113,8 +109,6 @@ class LibraryUpdateService(
 
     companion object {
 
-        private var instance: LibraryUpdateService? = null
-
         /**
          * Key for category to update.
          */
@@ -153,7 +147,7 @@ class LibraryUpdateService(
          * @return true if service newly started, false otherwise
          */
         fun start(context: Context, category: Category? = null, target: Target = Target.CHAPTERS /* SY --> */, group: Int = LibraryGroup.BY_DEFAULT, groupExtra: String? = null /* SY <-- */): Boolean {
-            return if (!isRunning(context)) {
+            if (!isRunning(context)) {
                 val intent = Intent(context, LibraryUpdateService::class.java).apply {
                     putExtra(KEY_TARGET, target)
                     category?.let { putExtra(KEY_CATEGORY, it.id) }
@@ -164,11 +158,10 @@ class LibraryUpdateService(
                 }
                 ContextCompat.startForegroundService(context, intent)
 
-                true
+                return true
-            } else {
-                instance?.addMangaToQueue(category?.id ?: -1, group, groupExtra, target)
-                false
             }
+
+            return false
         }
 
         /**
@@ -205,9 +198,6 @@ class LibraryUpdateService(
         if (wakeLock.isHeld) {
             wakeLock.release()
         }
-        if (instance == this) {
-            instance = null
-        }
         super.onDestroy()
     }
 
@@ -231,27 +221,23 @@ class LibraryUpdateService(
         val target = intent.getSerializableExtra(KEY_TARGET) as? Target
             ?: return START_NOT_STICKY
 
-        instance = this
+        // Unsubscribe from any previous subscription if needed.
-
-        // Unsubscribe from any previous subscription if needed
         updateJob?.cancel()
 
-        // Update favorite manga
+        // Update favorite manga. Destroy service when completed or in case of an error.
-        val categoryId = intent.getIntExtra(KEY_CATEGORY, -1)
+        val selectedScheme = preferences.libraryUpdatePrioritization().get()
-        val group = intent.getIntExtra(KEY_GROUP, LibraryGroup.BY_DEFAULT)
+        val mangaList = getMangaToUpdate(intent, target)
-        val groupExtra = intent.getStringExtra(KEY_GROUP_EXTRA)
+            .sortedWith(rankingScheme[selectedScheme])
-        addMangaToQueue(categoryId, group, groupExtra, target)
 
-        // Destroy service when completed or in case of an error.
         val handler = CoroutineExceptionHandler { _, exception ->
             Timber.e(exception)
             stopSelf(startId)
         }
         updateJob = ioScope.launch(handler) {
             when (target) {
-                Target.CHAPTERS -> updateChapterList()
+                Target.CHAPTERS -> updateChapterList(mangaList)
-                Target.COVERS -> updateCovers()
+                Target.COVERS -> updateCovers(mangaList)
-                Target.TRACKING -> updateTrackings()
+                Target.TRACKING -> updateTrackings(mangaList)
                 // SY -->
                 Target.SYNC_FOLLOWS -> syncFollows()
                 Target.PUSH_FAVORITES -> pushFavorites()
@@ -264,40 +250,36 @@ class LibraryUpdateService(
     }
 
     /**
-     * Adds list of manga to be updated.
+     * Returns the list of manga to be updated.
      *
-     * @param category the ID of the category to update, or -1 if no category specified.
+     * @param intent the update intent.
      * @param target the target to update.
+     * @return a list of manga to update
      */
-    fun addMangaToQueue(categoryId: Int, group: Int, groupExtra: String?, target: Target) {
+    fun getMangaToUpdate(intent: Intent, target: Target): List<LibraryManga> {
-        val libraryManga = db.getLibraryMangas().executeAsBlocking()
+        val categoryId = intent.getIntExtra(KEY_CATEGORY, -1)
         // SY -->
+        val group = intent.getIntExtra(KEY_GROUP, LibraryGroup.BY_DEFAULT)
         val groupLibraryUpdateType = preferences.groupLibraryUpdateType().get()
         // SY <--
 
         var listToUpdate = if (categoryId != -1) {
-            libraryManga.filter { it.category == categoryId }
+            db.getLibraryMangas().executeAsBlocking().filter { it.category == categoryId }
             // SY -->
         } else if (group == LibraryGroup.BY_DEFAULT || groupLibraryUpdateType == PreferenceValues.GroupLibraryMode.GLOBAL || (groupLibraryUpdateType == PreferenceValues.GroupLibraryMode.ALL_BUT_UNGROUPED && group == LibraryGroup.UNGROUPED)) {
             val categoriesToUpdate = preferences.libraryUpdateCategories().get().map(String::toInt)
-            val listToInclude = if (categoriesToUpdate.isNotEmpty()) {
+            if (categoriesToUpdate.isNotEmpty()) {
-                libraryManga.filter { it.category in categoriesToUpdate }
+                db.getLibraryMangas().executeAsBlocking()
+                    .filter { it.category in categoriesToUpdate }
+                    .distinctBy { it.id }
             } else {
-                libraryManga
+                db.getLibraryMangas().executeAsBlocking().distinctBy { it.id }
             }
-
-            val categoriesToExclude = preferences.libraryUpdateCategoriesExclude().get().map(String::toInt)
-            val listToExclude = if (categoriesToExclude.isNotEmpty()) {
-                libraryManga.filter { it.category in categoriesToExclude }
-            } else {
-                emptyList()
-            }
-
-            listToInclude.minus(listToExclude)
         } else {
+            val libraryManga = db.getLibraryMangas().executeAsBlocking().distinctBy { it.id }
             when (group) {
                 LibraryGroup.BY_TRACK_STATUS -> {
-                    val trackingExtra = groupExtra?.toIntOrNull() ?: -1
+                    val trackingExtra = intent.getStringExtra(KEY_GROUP_EXTRA)?.toIntOrNull() ?: -1
                     libraryManga.filter {
                         val loggedServices = trackManager.services.filter { it.isLogged }
                         val status: String = run {
@@ -316,12 +298,12 @@ class LibraryUpdateService(
                     }
                 }
                 LibraryGroup.BY_SOURCE -> {
-                    val sourceExtra = groupExtra.nullIfBlank()
+                    val sourceExtra = intent.getStringExtra(KEY_GROUP_EXTRA).nullIfBlank()
                     val source = sourceManager.getCatalogueSources().find { it.name == sourceExtra }
                     if (source != null) libraryManga.filter { it.source == source.id } else emptyList()
                 }
                 LibraryGroup.BY_STATUS -> {
-                    val statusExtra = groupExtra?.toIntOrNull() ?: -1
+                    val statusExtra = intent.getStringExtra(KEY_GROUP_EXTRA)?.toIntOrNull() ?: -1
                     libraryManga.filter {
                         it.status == statusExtra
                     }
@@ -332,13 +314,10 @@ class LibraryUpdateService(
             // SY <--
         }
         if (target == Target.CHAPTERS && preferences.updateOnlyNonCompleted()) {
-            listToUpdate = listToUpdate.filterNot { it.status == SManga.COMPLETED }
+            listToUpdate = listToUpdate.filter { it.status != SManga.COMPLETED }
         }
 
-        val selectedScheme = preferences.libraryUpdatePrioritization().get()
+        return listToUpdate
-        mangaToUpdate = listToUpdate
-            .distinctBy { it.id }
-            .sortedWith(rankingScheme[selectedScheme])
     }
 
     /**
@@ -350,13 +329,12 @@ class LibraryUpdateService(
      * @param mangaToUpdate the list to update
      * @return an observable delivering the progress of each update.
      */
-    suspend fun updateChapterList() {
+    suspend fun updateChapterList(mangaToUpdate: List<LibraryManga>) {
         val semaphore = Semaphore(5)
         val progressCount = AtomicInteger(0)
         val newUpdates = mutableListOf<Pair<LibraryManga, Array<Chapter>>>()
         val failedUpdates = mutableListOf<Pair<Manga, String?>>()
         var hasDownloads = false
-        val loggedServices by lazy { trackManager.services.filter { it.isLogged } }
 
         withIOContext {
             mangaToUpdate.groupBy { it.source }
@@ -395,10 +373,6 @@ class LibraryUpdateService(
                                         }
                                         failedUpdates.add(manga to errorMessage)
                                     }
-
-                                    if (preferences.autoUpdateTrackers()) {
-                                        updateTrackings(manga, loggedServices)
-                                    }
                                 }
                         }
                     }
@@ -468,7 +442,7 @@ class LibraryUpdateService(
             Timber.e(exception)
         }
         ioScope.launch(handler) {
-            if (source.isMdBasedSource() && trackManager.mdList.isLogged) {
+            if (source is MangaDex && trackManager.mdList.isLogged) {
                 val tracks = db.getTracks(manga).executeOnIO()
                 if (tracks.isEmpty() || tracks.none { it.sync_id == TrackManager.MDLIST }) {
                     var track = trackManager.mdList.createInitialTracker(manga)
@@ -489,7 +463,7 @@ class LibraryUpdateService(
         return syncChaptersWithSource(db, chapters, manga, source)
     }
 
-    private suspend fun updateCovers() {
+    private suspend fun updateCovers(mangaToUpdate: List<LibraryManga>) {
         var progressCount = 0
 
         mangaToUpdate.forEach { manga ->
@@ -515,7 +489,6 @@ class LibraryUpdateService(
             }
         }
 
-        coverCache.clearMemoryCache()
         notifier.cancelProgressNotification()
     }
 
@@ -523,7 +496,7 @@ class LibraryUpdateService(
      * Method that updates the metadata of the connected tracking services. It's called in a
      * background thread, so it's safe to do heavy operations or network calls here.
      */
-    private suspend fun updateTrackings() {
+    private suspend fun updateTrackings(mangaToUpdate: List<LibraryManga>) {
         var progressCount = 0
         val loggedServices = trackManager.services.filter { it.isLogged }
 
@@ -536,35 +509,27 @@ class LibraryUpdateService(
             notifier.showProgressNotification(manga, progressCount++, mangaToUpdate.size)
 
             // Update the tracking details.
-            updateTrackings(manga, loggedServices)
+            db.getTracks(manga).executeAsBlocking()
-        }
+                .map { track ->
-
+                    supervisorScope {
-        notifier.cancelProgressNotification()
+                        async {
-    }
+                            val service = trackManager.getService(track.sync_id)
-
+                            if (service != null && service in loggedServices) {
-    private suspend fun updateTrackings(manga: LibraryManga, loggedServices: List<TrackService>) {
+                                try {
-        db.getTracks(manga).executeAsBlocking()
+                                    val updatedTrack = service.refresh(track)
-            .map { track ->
+                                    db.insertTrack(updatedTrack).executeAsBlocking()
-                supervisorScope {
+                                } catch (e: Throwable) {
-                    async {
+                                    // Ignore errors and continue
-                        val service = trackManager.getService(track.sync_id)
+                                    Timber.e(e)
-                        if (service != null && service in loggedServices) {
-                            try {
-                                val updatedTrack = service.refresh(track)
-                                db.insertTrack(updatedTrack).executeAsBlocking()
-
-                                if (service is UnattendedTrackService) {
-                                    syncChaptersWithTrackServiceTwoWay(db, db.getChapters(manga).executeAsBlocking(), track, service)
                                 }
-                            } catch (e: Throwable) {
-                                // Ignore errors and continue
-                                Timber.e(e)
                             }
                         }
                     }
                 }
-            }
+                .awaitAll()
-            .awaitAll()
+        }
+
+        notifier.cancelProgressNotification()
     }
 
     // SY -->
@@ -574,12 +539,11 @@ class LibraryUpdateService(
     private suspend fun syncFollows() {
         val count = AtomicInteger(0)
         val mangaDex = MdUtil.getEnabledMangaDex(preferences, sourceManager) ?: return
-        val syncFollowStatusInts = preferences.mangadexSyncToLibraryIndexes().get().map { it.toInt() }
 
         val size: Int
-        mangaDex.fetchAllFollows()
+        mangaDex.fetchAllFollows(true)
             .filter { (_, metadata) ->
-                syncFollowStatusInts.contains(metadata.followStatus)
+                metadata.follow_status == FollowStatus.RE_READING.int || metadata.follow_status == FollowStatus.READING.int
             }
             .also { size = it.size }
             .forEach { (networkManga, metadata) ->
@@ -605,7 +569,7 @@ class LibraryUpdateService(
                 val id = db.insertManga(dbManga).executeOnIO().insertedId()
                 if (id != null) {
                     metadata.mangaId = id
-                    db.insertFlatMetadataAsync(metadata.flatten()).await()
+                    db.insertFlatMetadata(metadata.flatten()).await()
                 }
             }
 

app/src/main/java/eu/kanade/tachiyomi/data/notification/NotificationReceiver.kt

@@ -26,6 +26,7 @@ import eu.kanade.tachiyomi.util.storage.DiskUtil
 import eu.kanade.tachiyomi.util.storage.getUriCompat
 import eu.kanade.tachiyomi.util.system.notificationManager
 import eu.kanade.tachiyomi.util.system.toast
+import exh.md.similar.SimilarUpdateService
 import uy.kohesive.injekt.Injekt
 import uy.kohesive.injekt.api.get
 import uy.kohesive.injekt.injectLazy
@@ -58,22 +59,22 @@ class NotificationReceiver : BroadcastReceiver() {
             ACTION_SHARE_IMAGE ->
                 shareImage(
                     context,
-                    intent.getStringExtra(EXTRA_FILE_LOCATION)!!,
+                    intent.getStringExtra(EXTRA_FILE_LOCATION),
                     intent.getIntExtra(EXTRA_NOTIFICATION_ID, -1)
                 )
             // Delete image from path and dismiss notification
             ACTION_DELETE_IMAGE ->
                 deleteImage(
                     context,
-                    intent.getStringExtra(EXTRA_FILE_LOCATION)!!,
+                    intent.getStringExtra(EXTRA_FILE_LOCATION),
                     intent.getIntExtra(EXTRA_NOTIFICATION_ID, -1)
                 )
             // Share backup file
             ACTION_SHARE_BACKUP ->
                 shareFile(
                     context,
-                    intent.getParcelableExtra(EXTRA_URI)!!,
+                    intent.getParcelableExtra(EXTRA_URI),
-                    "application/x-protobuf+gzip",
+                    if (intent.getBooleanExtra(EXTRA_IS_LEGACY_BACKUP, false)) "application/json" else "application/octet-stream+gzip",
                     intent.getIntExtra(EXTRA_NOTIFICATION_ID, -1)
                 )
             ACTION_CANCEL_RESTORE -> cancelRestore(
@@ -106,10 +107,13 @@ class NotificationReceiver : BroadcastReceiver() {
             ACTION_SHARE_CRASH_LOG ->
                 shareFile(
                     context,
-                    intent.getParcelableExtra(EXTRA_URI)!!,
+                    intent.getParcelableExtra(EXTRA_URI),
                     "text/plain",
                     intent.getIntExtra(EXTRA_NOTIFICATION_ID, -1)
                 )
+            // SY -->
+            ACTION_CANCEL_SIMILAR_UPDATE -> cancelSimilarUpdate(context)
+            // SY <--
         }
     }
 
@@ -251,6 +255,18 @@ class NotificationReceiver : BroadcastReceiver() {
         }
     }
 
+    // SY -->
+    /**
+     * Method called when user wants to stop a similar manga update
+     *
+     * @param context context of application
+     */
+    private fun cancelSimilarUpdate(context: Context) {
+        SimilarUpdateService.stop(context)
+        Handler().post { dismissNotification(context, Notifications.ID_SIMILAR_PROGRESS) }
+    }
+    // SY <--
+
     companion object {
         private const val NAME = "NotificationReceiver"
 
@@ -281,6 +297,12 @@ class NotificationReceiver : BroadcastReceiver() {
         private const val EXTRA_MANGA_ID = "$ID.$NAME.EXTRA_MANGA_ID"
         private const val EXTRA_CHAPTER_ID = "$ID.$NAME.EXTRA_CHAPTER_ID"
         private const val EXTRA_CHAPTER_URL = "$ID.$NAME.EXTRA_CHAPTER_URL"
+        private const val EXTRA_IS_LEGACY_BACKUP = "$ID.$NAME.EXTRA_IS_LEGACY_BACKUP"
+
+        // Sy -->
+        // Called to cancel similar manga update.
+        private const val ACTION_CANCEL_SIMILAR_UPDATE = "$ID.$NAME.CANCEL_SIMILAR_UPDATE"
+        // SY <--
 
         /**
          * Returns a [PendingIntent] that resumes the download of a chapter
@@ -493,10 +515,11 @@ class NotificationReceiver : BroadcastReceiver() {
          * @param notificationId id of notification
          * @return [PendingIntent]
          */
-        internal fun shareBackupPendingBroadcast(context: Context, uri: Uri, notificationId: Int): PendingIntent {
+        internal fun shareBackupPendingBroadcast(context: Context, uri: Uri, isLegacyFormat: Boolean, notificationId: Int): PendingIntent {
             val intent = Intent(context, NotificationReceiver::class.java).apply {
                 action = ACTION_SHARE_BACKUP
                 putExtra(EXTRA_URI, uri)
+                putExtra(EXTRA_IS_LEGACY_BACKUP, isLegacyFormat)
                 putExtra(EXTRA_NOTIFICATION_ID, notificationId)
             }
             return PendingIntent.getBroadcast(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT)
@@ -549,5 +572,20 @@ class NotificationReceiver : BroadcastReceiver() {
             }
             return PendingIntent.getBroadcast(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT)
         }
+
+        // SY -->
+        /**
+         * Returns [PendingIntent] that starts a service which stops the similar update
+         *
+         * @param context context of application
+         * @return [PendingIntent]
+         */
+        internal fun cancelSimilarUpdatePendingBroadcast(context: Context): PendingIntent {
+            val intent = Intent(context, NotificationReceiver::class.java).apply {
+                action = ACTION_CANCEL_SIMILAR_UPDATE
+            }
+            return PendingIntent.getBroadcast(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT)
+        }
+        // SY <--
     }
 }

app/src/main/java/eu/kanade/tachiyomi/data/notification/Notifications.kt

@@ -68,11 +68,14 @@ object Notifications {
     const val CHANNEL_CRASH_LOGS = "crash_logs_channel"
     const val ID_CRASH_LOGS = -601
 
+    // SY -->
     /**
-     * Notification channel used for Incognito Mode
+     * Notification channel and ids used for backup and restore.
      */
-    const val CHANNEL_INCOGNITO_MODE = "incognito_mode_channel"
+    const val CHANNEL_SIMILAR = "similar_channel"
-    const val ID_INCOGNITO_MODE = -701
+    const val ID_SIMILAR_PROGRESS = -901
+    const val ID_SIMILAR_COMPLETE = -902
+    // SY <--
 
     private val deprecatedChannels = listOf(
         "downloader_channel",
@@ -162,10 +165,12 @@ object Notifications {
                 NotificationManager.IMPORTANCE_HIGH
             ),
             NotificationChannel(
-                CHANNEL_INCOGNITO_MODE,
+                CHANNEL_SIMILAR,
-                context.getString(R.string.pref_incognito_mode),
+                context.getString(R.string.similar_manga),
                 NotificationManager.IMPORTANCE_LOW
-            )
+            ).apply {
+                setShowBadge(false)
+            }
         ).forEach(context.notificationManager::createNotificationChannel)
 
         // Delete old notification channels

app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferenceKeys.kt

@@ -13,25 +13,17 @@ object PreferenceKeys {
 
     const val confirmExit = "pref_confirm_exit"
 
-    const val hideBottomBarOnScroll = "pref_hide_bottom_bar_on_scroll"
+    const val hideBottomBar = "pref_hide_bottom_bar_on_scroll"
 
-    const val showSideNavOnBottom = "pref_show_side_nav_on_bottom"
+    const val rotation = "pref_rotation_type_key"
 
-    const val enableTransitionsPager = "pref_enable_transitions_pager_key"
+    const val enableTransitions = "pref_enable_transitions_key"
-
-    const val enableTransitionsWebtoon = "pref_enable_transitions_webtoon_key"
 
     const val doubleTapAnimationSpeed = "pref_double_tap_anim_speed"
 
     const val showPageNumber = "pref_show_page_number_key"
 
-    const val dualPageSplitPaged = "pref_dual_page_split"
+    const val dualPageSplit = "pref_dual_page_split"
-
-    const val dualPageSplitWebtoon = "pref_dual_page_split_webtoon"
-
-    const val dualPageInvertPaged = "pref_dual_page_invert"
-
-    const val dualPageInvertWebtoon = "pref_dual_page_invert_webtoon"
 
     const val showReadingMode = "pref_show_reading_mode"
 
@@ -53,11 +45,7 @@ object PreferenceKeys {
 
     const val colorFilterMode = "color_filter_mode"
 
-    const val grayscale = "pref_grayscale"
+    const val defaultViewer = "pref_default_viewer_key"
-
-    const val defaultReadingMode = "pref_default_reading_mode_key"
-
-    const val defaultOrientationType = "pref_default_orientation_type_key"
 
     const val imageScaleType = "pref_image_scale_type_key"
 
@@ -85,10 +73,6 @@ object PreferenceKeys {
 
     const val navigationModeWebtoon = "reader_navigation_mode_webtoon"
 
-    const val showNavigationOverlayNewUser = "reader_navigation_overlay_new_user"
-
-    const val showNavigationOverlayOnStart = "reader_navigation_overlay_on_start"
-
     const val webtoonSidePadding = "webtoon_side_padding"
 
     const val portraitColumns = "pref_library_columns_portrait_key"
@@ -101,8 +85,6 @@ object PreferenceKeys {
 
     const val autoUpdateTrack = "pref_auto_update_manga_sync_key"
 
-    const val autoAddTrack = "pref_auto_add_track_key"
-
     const val lastUsedSource = "last_catalogue_source"
 
     const val lastUsedCategory = "last_used_category"
@@ -117,8 +99,6 @@ object PreferenceKeys {
 
     const val downloadOnlyOverWifi = "pref_download_only_over_wifi_key"
 
-    const val folderPerManga = "create_folder_per_manga"
-
     const val numberOfBackups = "backup_slots"
 
     const val backupInterval = "backup_interval"
@@ -134,7 +114,6 @@ object PreferenceKeys {
     const val libraryUpdateRestriction = "library_update_restriction"
 
     const val libraryUpdateCategories = "library_update_categories"
-    const val libraryUpdateCategoriesExclude = "library_update_categories_exclude"
 
     const val libraryUpdatePrioritization = "library_update_prioritization"
 
@@ -162,7 +141,7 @@ object PreferenceKeys {
 
     const val startScreen = "start_screen"
 
-    const val useAuthenticator = "use_biometric_lock"
+    const val useBiometricLock = "use_biometric_lock"
 
     const val lockAppAfter = "lock_app_after"
 
@@ -174,14 +153,11 @@ object PreferenceKeys {
 
     const val autoUpdateMetadata = "auto_update_metadata"
 
-    const val autoUpdateTrackers = "auto_update_trackers"
-
     const val showLibraryUpdateErrors = "show_library_update_errors"
 
     const val downloadNew = "download_new"
 
     const val downloadNewCategories = "download_new_categories"
-    const val downloadNewCategoriesExclude = "download_new_categories_exclude"
 
     const val libraryDisplayMode = "pref_display_mode_library"
 
@@ -199,8 +175,6 @@ object PreferenceKeys {
 
     const val unreadBadge = "display_unread_badge"
 
-    const val localBadge = "display_local_badge"
-
     const val categoryTabs = "display_category_tabs"
 
     const val categoryNumberOfItems = "display_number_of_items"
@@ -209,7 +183,7 @@ object PreferenceKeys {
 
     const val searchPinnedSourcesOnly = "search_pinned_sources_only"
 
-    const val dohProvider = "doh_provider"
+    const val enableDoh = "enable_doh"
 
     const val defaultChapterFilterByRead = "default_chapter_filter_by_read"
 
@@ -333,7 +307,11 @@ object PreferenceKeys {
 
     const val mangaDexForceLatestCovers = "manga_dex_force_latest_covers"
 
-    const val mangadexSyncToLibraryIndexes = "pref_mangadex_sync_to_library_indexes"
+    const val mangadexSimilarEnabled = "pref_related_show_tab_key"
+
+    const val mangadexSimilarUpdateInterval = "related_update_interval"
+
+    const val mangadexSimilarOnlyOverWifi = "pref_simular_only_over_wifi_key"
 
     const val preferredMangaDexId = "preferred_mangaDex_id"
 
@@ -357,31 +335,15 @@ object PreferenceKeys {
 
     const val allowLocalSourceHiddenFolders = "allow_local_source_hidden_folders"
 
-    const val authenticatorTimeRanges = "biometric_time_ranges"
+    const val biometricTimeRanges = "biometric_time_ranges"
 
     const val sortTagsForLibrary = "sort_tags_for_library"
 
+    const val createLegacyBackup = "create_legacy_backup"
+
     const val dontDeleteFromCategories = "dont_delete_from_categories"
 
     const val extensionRepos = "extension_repos"
 
-    const val cropBordersContinuousVertical = "crop_borders_continues_vertical"
+    const val cropBordersContinuesVertical = "crop_borders_continues_vertical"
-
-    const val landscapeVerticalSeekbar = "pref_show_vert_seekbar_landscape"
-
-    const val leftVerticalSeekbar = "pref_left_handed_vertical_seekbar"
-
-    const val forceHorizontalSeekbar = "pref_force_horz_seekbar"
-
-    const val readerBottomButtons = "reader_bottom_buttons"
-
-    const val bottomBarLabels = "pref_show_bottom_bar_labels"
-
-    const val hideUpdatesButton = "pref_hide_updates_button"
-
-    const val hideHistoryButton = "pref_hide_history_button"
-
-    const val pageLayout = "page_layout"
-
-    const val invertDoublePages = "invert_double_pages"
 }

app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferenceValues.kt

@@ -1,15 +1,10 @@
 package eu.kanade.tachiyomi.data.preference
 
-const val UNMETERED_NETWORK = "wifi"
-const val CHARGING = "ac"
-
 /**
  * This class stores the values for the preferences in the application.
  */
 object PreferenceValues {
 
-    /* ktlint-disable experimental:enum-entry-name-case */
-
     // Keys are lowercase to match legacy string values
     enum class ThemeMode {
         light,
@@ -21,23 +16,17 @@ object PreferenceValues {
     enum class LightThemeVariant {
         default,
         blue,
-        strawberrydaiquiri,
     }
 
     // Keys are lowercase to match legacy string values
     enum class DarkThemeVariant {
         default,
         blue,
-        greenapple,
-        midnightdusk,
         amoled,
-        hotpink,
-        amoledblue,
         red,
+        midnightdusk,
     }
 
-    /* ktlint-enable experimental:enum-entry-name-case */
-
     enum class DisplayMode {
         COMPACT_GRID,
         COMFORTABLE_GRID,

app/src/main/java/eu/kanade/tachiyomi/data/preference/PreferencesHelper.kt

@@ -12,10 +12,6 @@ import eu.kanade.tachiyomi.data.database.models.Manga
 import eu.kanade.tachiyomi.data.preference.PreferenceValues.DisplayMode
 import eu.kanade.tachiyomi.data.track.TrackService
 import eu.kanade.tachiyomi.data.track.anilist.Anilist
-import eu.kanade.tachiyomi.ui.reader.setting.OrientationType
-import eu.kanade.tachiyomi.ui.reader.setting.ReaderBottomButton
-import eu.kanade.tachiyomi.ui.reader.setting.ReadingModeType
-import eu.kanade.tachiyomi.ui.reader.viewer.pager.PagerConfig
 import eu.kanade.tachiyomi.widget.ExtendedNavigationView
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.onEach
@@ -26,7 +22,7 @@ import java.util.Locale
 import eu.kanade.tachiyomi.data.preference.PreferenceKeys as Keys
 import eu.kanade.tachiyomi.data.preference.PreferenceValues as Values
 
-fun <T> Preference<T>.asImmediateFlow(block: (T) -> Unit): Flow<T> {
+fun <T> Preference<T>.asImmediateFlow(block: (value: T) -> Unit): Flow<T> {
     block(get())
     return asFlow()
         .onEach { block(it) }
@@ -40,11 +36,6 @@ operator fun <T> Preference<Set<T>>.minusAssign(item: T) {
     set(get() - item)
 }
 
-fun Preference<Boolean>.toggle(): Boolean {
-    set(!get())
-    return get()
-}
-
 class PreferencesHelper(val context: Context) {
 
     private val prefs = PreferenceManager.getDefaultSharedPreferences(context)
@@ -66,11 +57,9 @@ class PreferencesHelper(val context: Context) {
 
     fun confirmExit() = prefs.getBoolean(Keys.confirmExit, false)
 
-    fun hideBottomBarOnScroll() = flowPrefs.getBoolean(Keys.hideBottomBarOnScroll, true)
+    fun hideBottomBar() = flowPrefs.getBoolean(Keys.hideBottomBar, true)
 
-    fun showSideNavOnBottom() = flowPrefs.getBoolean(Keys.showSideNavOnBottom, false)
+    fun useBiometricLock() = flowPrefs.getBoolean(Keys.useBiometricLock, false)
-
-    fun useAuthenticator() = flowPrefs.getBoolean(Keys.useAuthenticator, false)
 
     fun lockAppAfter() = flowPrefs.getInt(Keys.lockAppAfter, 0)
 
@@ -82,31 +71,25 @@ class PreferencesHelper(val context: Context) {
 
     fun autoUpdateMetadata() = prefs.getBoolean(Keys.autoUpdateMetadata, false)
 
-    fun autoUpdateTrackers() = prefs.getBoolean(Keys.autoUpdateTrackers, false)
-
     fun showLibraryUpdateErrors() = prefs.getBoolean(Keys.showLibraryUpdateErrors, false)
 
+    fun clear() = prefs.edit { clear() }
+
     fun themeMode() = flowPrefs.getEnum(Keys.themeMode, Values.ThemeMode.system)
 
     fun themeLight() = flowPrefs.getEnum(Keys.themeLight, Values.LightThemeVariant.default)
 
     fun themeDark() = flowPrefs.getEnum(Keys.themeDark, Values.DarkThemeVariant.default)
 
-    fun pageTransitionsPager() = flowPrefs.getBoolean(Keys.enableTransitionsPager, true)
+    fun rotation() = flowPrefs.getInt(Keys.rotation, 1)
 
-    fun pageTransitionsWebtoon() = flowPrefs.getBoolean(Keys.enableTransitionsWebtoon, true)
+    fun pageTransitions() = flowPrefs.getBoolean(Keys.enableTransitions, true)
 
     fun doubleTapAnimSpeed() = flowPrefs.getInt(Keys.doubleTapAnimationSpeed, 500)
 
     fun showPageNumber() = flowPrefs.getBoolean(Keys.showPageNumber, true)
 
-    fun dualPageSplitPaged() = flowPrefs.getBoolean(Keys.dualPageSplitPaged, false)
+    fun dualPageSplit() = flowPrefs.getBoolean(Keys.dualPageSplit, false)
-
-    fun dualPageSplitWebtoon() = flowPrefs.getBoolean(Keys.dualPageSplitWebtoon, false)
-
-    fun dualPageInvertPaged() = flowPrefs.getBoolean(Keys.dualPageInvertPaged, false)
-
-    fun dualPageInvertWebtoon() = flowPrefs.getBoolean(Keys.dualPageInvertWebtoon, false)
 
     fun showReadingMode() = prefs.getBoolean(Keys.showReadingMode, true)
 
@@ -128,11 +111,7 @@ class PreferencesHelper(val context: Context) {
 
     fun colorFilterMode() = flowPrefs.getInt(Keys.colorFilterMode, 0)
 
-    fun grayscale() = flowPrefs.getBoolean(Keys.grayscale, false)
+    fun defaultViewer() = prefs.getInt(Keys.defaultViewer, 2)
-
-    fun defaultReadingMode() = prefs.getInt(Keys.defaultReadingMode, ReadingModeType.RIGHT_TO_LEFT.flagValue)
-
-    fun defaultOrientationType() = prefs.getInt(Keys.defaultOrientationType, OrientationType.FREE.flagValue)
 
     fun imageScaleType() = flowPrefs.getInt(Keys.imageScaleType, 1)
 
@@ -164,10 +143,6 @@ class PreferencesHelper(val context: Context) {
 
     fun navigationModeWebtoon() = flowPrefs.getInt(Keys.navigationModeWebtoon, 0)
 
-    fun showNavigationOverlayNewUser() = flowPrefs.getBoolean(Keys.showNavigationOverlayNewUser, true)
-
-    fun showNavigationOverlayOnStart() = flowPrefs.getBoolean(Keys.showNavigationOverlayOnStart, false)
-
     fun portraitColumns() = flowPrefs.getInt(Keys.portraitColumns, 0)
 
     fun landscapeColumns() = flowPrefs.getInt(Keys.landscapeColumns, 0)
@@ -178,8 +153,6 @@ class PreferencesHelper(val context: Context) {
 
     fun autoUpdateTrack() = prefs.getBoolean(Keys.autoUpdateTrack, true)
 
-    fun autoAddTrack() = prefs.getBoolean(Keys.autoAddTrack, true)
-
     fun lastUsedSource() = flowPrefs.getLong(Keys.lastUsedSource, -1)
 
     fun lastUsedCategory() = flowPrefs.getInt(Keys.lastUsedCategory, 0)
@@ -216,8 +189,6 @@ class PreferencesHelper(val context: Context) {
 
     fun downloadOnlyOverWifi() = prefs.getBoolean(Keys.downloadOnlyOverWifi, true)
 
-    fun folderPerManga() = prefs.getBoolean(Keys.folderPerManga, false)
-
     fun numberOfBackups() = flowPrefs.getInt(Keys.numberOfBackups, 1)
 
     fun backupInterval() = flowPrefs.getInt(Keys.backupInterval, 0)
@@ -230,10 +201,9 @@ class PreferencesHelper(val context: Context) {
 
     fun libraryUpdateInterval() = flowPrefs.getInt(Keys.libraryUpdateInterval, 24)
 
-    fun libraryUpdateRestriction() = flowPrefs.getStringSet(Keys.libraryUpdateRestriction, setOf(UNMETERED_NETWORK))
+    fun libraryUpdateRestriction() = prefs.getStringSet(Keys.libraryUpdateRestriction, setOf("wifi"))
 
     fun libraryUpdateCategories() = flowPrefs.getStringSet(Keys.libraryUpdateCategories, emptySet())
-    fun libraryUpdateCategoriesExclude() = flowPrefs.getStringSet(Keys.libraryUpdateCategoriesExclude, emptySet())
 
     fun libraryUpdatePrioritization() = flowPrefs.getInt(Keys.libraryUpdatePrioritization, 0)
 
@@ -241,8 +211,6 @@ class PreferencesHelper(val context: Context) {
 
     fun downloadBadge() = flowPrefs.getBoolean(Keys.downloadBadge, false)
 
-    fun localBadge() = flowPrefs.getBoolean(Keys.localBadge, true)
-
     fun downloadedOnly() = flowPrefs.getBoolean(Keys.downloadedOnly, false)
 
     fun unreadBadge() = flowPrefs.getBoolean(Keys.unreadBadge, true)
@@ -286,7 +254,6 @@ class PreferencesHelper(val context: Context) {
     fun downloadNew() = flowPrefs.getBoolean(Keys.downloadNew, false)
 
     fun downloadNewCategories() = flowPrefs.getStringSet(Keys.downloadNewCategories, emptySet())
-    fun downloadNewCategoriesExclude() = flowPrefs.getStringSet(Keys.downloadNewCategoriesExclude, emptySet())
 
     fun lang() = prefs.getString(Keys.lang, "")
 
@@ -300,7 +267,7 @@ class PreferencesHelper(val context: Context) {
 
     fun trustedSignatures() = flowPrefs.getStringSet("trusted_signatures", emptySet())
 
-    fun dohProvider() = prefs.getInt(Keys.dohProvider, -1)
+    fun enableDoh() = prefs.getBoolean(Keys.enableDoh, false)
 
     fun lastSearchQuerySearchSettings() = flowPrefs.getString("last_search_query", "")
 
@@ -310,14 +277,16 @@ class PreferencesHelper(val context: Context) {
 
     fun filterChapterByBookmarked() = prefs.getInt(Keys.defaultChapterFilterByBookmarked, Manga.SHOW_ALL)
 
-    fun sortChapterBySourceOrNumber() = prefs.getInt(Keys.defaultChapterSortBySourceOrNumber, Manga.CHAPTER_SORTING_SOURCE)
+    fun sortChapterBySourceOrNumber() = prefs.getInt(Keys.defaultChapterSortBySourceOrNumber, Manga.SORTING_SOURCE)
 
-    fun displayChapterByNameOrNumber() = prefs.getInt(Keys.defaultChapterDisplayByNameOrNumber, Manga.CHAPTER_DISPLAY_NAME)
+    fun displayChapterByNameOrNumber() = prefs.getInt(Keys.defaultChapterDisplayByNameOrNumber, Manga.DISPLAY_NAME)
 
-    fun sortChapterByAscendingOrDescending() = prefs.getInt(Keys.defaultChapterSortByAscendingOrDescending, Manga.CHAPTER_SORT_DESC)
+    fun sortChapterByAscendingOrDescending() = prefs.getInt(Keys.defaultChapterSortByAscendingOrDescending, Manga.SORT_DESC)
 
     fun incognitoMode() = flowPrefs.getBoolean(Keys.incognitoMode, false)
 
+    fun createLegacyBackup() = flowPrefs.getBoolean(Keys.createLegacyBackup, true)
+
     fun setChapterSettingsDefault(manga: Manga) {
         prefs.edit {
             putInt(Keys.defaultChapterFilterByRead, manga.readFilter)
@@ -325,7 +294,7 @@ class PreferencesHelper(val context: Context) {
             putInt(Keys.defaultChapterFilterByBookmarked, manga.bookmarkedFilter)
             putInt(Keys.defaultChapterSortBySourceOrNumber, manga.sorting)
             putInt(Keys.defaultChapterDisplayByNameOrNumber, manga.displayMode)
-            putInt(Keys.defaultChapterSortByAscendingOrDescending, if (manga.sortDescending()) Manga.CHAPTER_SORT_DESC else Manga.CHAPTER_SORT_ASC)
+            putInt(Keys.defaultChapterSortByAscendingOrDescending, if (manga.sortDescending()) Manga.SORT_DESC else Manga.SORT_ASC)
         }
     }
 
@@ -450,7 +419,13 @@ class PreferencesHelper(val context: Context) {
 
     fun preferredMangaDexId() = flowPrefs.getString(Keys.preferredMangaDexId, "0")
 
-    fun mangadexSyncToLibraryIndexes() = flowPrefs.getStringSet(Keys.mangadexSyncToLibraryIndexes, emptySet())
+    fun mangadexSimilarEnabled() = flowPrefs.getBoolean(Keys.mangadexSimilarEnabled, false)
+
+    fun shownMangaDexSimilarAskDialog() = flowPrefs.getBoolean("shown_similar_ask_dialog", false)
+
+    fun mangadexSimilarOnlyOverWifi() = flowPrefs.getBoolean(Keys.mangadexSimilarOnlyOverWifi, true)
+
+    fun mangadexSimilarUpdateInterval() = flowPrefs.getInt(Keys.mangadexSimilarUpdateInterval, 2)
 
     fun dataSaver() = flowPrefs.getBoolean(Keys.dataSaver, false)
 
@@ -472,7 +447,7 @@ class PreferencesHelper(val context: Context) {
 
     fun allowLocalSourceHiddenFolders() = flowPrefs.getBoolean(Keys.allowLocalSourceHiddenFolders, false)
 
-    fun authenticatorTimeRanges() = flowPrefs.getStringSet(Keys.authenticatorTimeRanges, mutableSetOf())
+    fun biometricTimeRanges() = flowPrefs.getStringSet(Keys.biometricTimeRanges, mutableSetOf())
 
     fun sortTagsForLibrary() = flowPrefs.getStringSet(Keys.sortTagsForLibrary, mutableSetOf())
 
@@ -480,23 +455,5 @@ class PreferencesHelper(val context: Context) {
 
     fun extensionRepos() = flowPrefs.getStringSet(Keys.extensionRepos, emptySet())
 
-    fun cropBordersContinuousVertical() = flowPrefs.getBoolean(Keys.cropBordersContinuousVertical, false)
+    fun cropBordersContinuesVertical() = flowPrefs.getBoolean(Keys.cropBordersContinuesVertical, false)
-
-    fun forceHorizontalSeekbar() = flowPrefs.getBoolean(Keys.forceHorizontalSeekbar, false)
-
-    fun landscapeVerticalSeekbar() = flowPrefs.getBoolean(Keys.landscapeVerticalSeekbar, false)
-
-    fun leftVerticalSeekbar() = flowPrefs.getBoolean(Keys.leftVerticalSeekbar, false)
-
-    fun readerBottomButtons() = flowPrefs.getStringSet(Keys.readerBottomButtons, ReaderBottomButton.BUTTONS_DEFAULTS)
-
-    fun bottomBarLabels() = flowPrefs.getBoolean(Keys.bottomBarLabels, true)
-
-    fun hideUpdatesButton() = flowPrefs.getBoolean(Keys.hideUpdatesButton, false)
-
-    fun hideHistoryButton() = flowPrefs.getBoolean(Keys.hideHistoryButton, false)
-
-    fun pageLayout() = flowPrefs.getInt(Keys.pageLayout, PagerConfig.PageLayout.SINGLE_PAGE)
-
-    fun invertDoublePages() = flowPrefs.getBoolean(Keys.invertDoublePages, false)
 }

app/src/main/java/eu/kanade/tachiyomi/data/track/NoLoginTrackService.kt

@@ -1,8 +0,0 @@
-package eu.kanade.tachiyomi.data.track
-
-/**
- * A TrackService that doesn't need explicit login.
- */
-interface NoLoginTrackService {
-    fun loginNoop()
-}

app/src/main/java/eu/kanade/tachiyomi/data/track/TrackManager.kt

@@ -4,7 +4,6 @@ import android.content.Context
 import eu.kanade.tachiyomi.data.track.anilist.Anilist
 import eu.kanade.tachiyomi.data.track.bangumi.Bangumi
 import eu.kanade.tachiyomi.data.track.kitsu.Kitsu
-import eu.kanade.tachiyomi.data.track.komga.Komga
 import eu.kanade.tachiyomi.data.track.mdlist.MdList
 import eu.kanade.tachiyomi.data.track.myanimelist.MyAnimeList
 import eu.kanade.tachiyomi.data.track.shikimori.Shikimori
@@ -17,10 +16,9 @@ class TrackManager(context: Context) {
         const val KITSU = 3
         const val SHIKIMORI = 4
         const val BANGUMI = 5
-        const val KOMGA = 6
 
         // SY --> Mangadex from Neko
-        const val MDLIST = 60
+        const val MDLIST = 6
         // SY <--
 
         // SY -->
@@ -46,9 +44,7 @@ class TrackManager(context: Context) {
 
     val bangumi = Bangumi(context, BANGUMI)
 
-    val komga = Komga(context, KOMGA)
+    val services = listOf(mdList, myAnimeList, aniList, kitsu, shikimori, bangumi)
-
-    val services = listOf(mdList, myAnimeList, aniList, kitsu, shikimori, bangumi, komga)
 
     fun getService(id: Int) = services.find { it.id == id }
 

app/src/main/java/eu/kanade/tachiyomi/data/track/TrackService.kt

@@ -46,6 +46,8 @@ abstract class TrackService(val id: Int) {
 
     abstract fun displayScore(track: Track): String
 
+    abstract suspend fun add(track: Track): Track
+
     abstract suspend fun update(track: Track): Track
 
     abstract suspend fun bind(track: Track): Track

app/src/main/java/eu/kanade/tachiyomi/data/track/UnattendedTrackService.kt

@@ -1,21 +0,0 @@
-package eu.kanade.tachiyomi.data.track
-
-import eu.kanade.tachiyomi.data.database.models.Manga
-import eu.kanade.tachiyomi.data.track.model.TrackSearch
-import eu.kanade.tachiyomi.source.Source
-
-/**
- * An Unattended Track Service will never prompt the user to match a manga with the remote.
- * It is expected that such Track Sercice can only work with specific sources and unique IDs.
- */
-interface UnattendedTrackService {
-    /**
-     * This TrackService will only work with the sources that are accepted by this filter function.
-     */
-    fun accept(source: Source): Boolean
-
-    /**
-     * match is similar to TrackService.search, but only return zero or one match.
-     */
-    suspend fun match(manga: Manga): TrackSearch?
-}

app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/Anilist.kt

@@ -35,8 +35,6 @@ class Anilist(private val context: Context, id: Int) : TrackService(id) {
 
     private val api by lazy { AnilistApi(client, interceptor) }
 
-    override val supportsReadingDates: Boolean = true
-
     private val scorePreference = preferences.anilistScoreType()
 
     init {
@@ -130,7 +128,7 @@ class Anilist(private val context: Context, id: Int) : TrackService(id) {
         }
     }
 
-    private suspend fun add(track: Track): Track {
+    override suspend fun add(track: Track): Track {
         return api.addLibManga(track)
     }
 

app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/AnilistApi.kt

@@ -2,18 +2,13 @@ package eu.kanade.tachiyomi.data.track.anilist
 
 import android.net.Uri
 import androidx.core.net.toUri
-import com.afollestad.date.dayOfMonth
-import com.afollestad.date.month
-import com.afollestad.date.year
 import eu.kanade.tachiyomi.data.database.models.Track
 import eu.kanade.tachiyomi.data.track.model.TrackSearch
 import eu.kanade.tachiyomi.network.POST
 import eu.kanade.tachiyomi.network.await
-import eu.kanade.tachiyomi.network.interceptor.RateLimitInterceptor
 import eu.kanade.tachiyomi.network.jsonMime
 import eu.kanade.tachiyomi.network.parseAs
 import eu.kanade.tachiyomi.util.lang.withIOContext
-import kotlinx.serialization.json.JsonNull
 import kotlinx.serialization.json.JsonObject
 import kotlinx.serialization.json.buildJsonObject
 import kotlinx.serialization.json.contentOrNull
@@ -28,18 +23,15 @@ import kotlinx.serialization.json.putJsonObject
 import okhttp3.OkHttpClient
 import okhttp3.RequestBody.Companion.toRequestBody
 import java.util.Calendar
-import java.util.concurrent.TimeUnit.MINUTES
 
 class AnilistApi(val client: OkHttpClient, interceptor: AnilistInterceptor) {
 
-    private val authClient = client.newBuilder()
+    private val authClient = client.newBuilder().addInterceptor(interceptor).build()
-        .addInterceptor(interceptor)
-        .addInterceptor(RateLimitInterceptor(85, 1, MINUTES))
-        .build()
 
     suspend fun addLibManga(track: Track): Track {
         return withIOContext {
-            val query = """
+            val query =
+                """
             |mutation AddManga(${'$'}mangaId: Int, ${'$'}progress: Int, ${'$'}status: MediaListStatus) {
                 |SaveMediaListEntry (mediaId: ${'$'}mangaId, progress: ${'$'}progress, status: ${'$'}status) { 
                 |   id 
@@ -73,15 +65,10 @@ class AnilistApi(val client: OkHttpClient, interceptor: AnilistInterceptor) {
 
     suspend fun updateLibManga(track: Track): Track {
         return withIOContext {
-            val query = """
+            val query =
-            |mutation UpdateManga(
+                """
-                |${'$'}listId: Int, ${'$'}progress: Int, ${'$'}status: MediaListStatus,
+            |mutation UpdateManga(${'$'}listId: Int, ${'$'}progress: Int, ${'$'}status: MediaListStatus, ${'$'}score: Int) {
-                |${'$'}score: Int, ${'$'}startedAt: FuzzyDateInput, ${'$'}completedAt: FuzzyDateInput
+                |SaveMediaListEntry (id: ${'$'}listId, progress: ${'$'}progress, status: ${'$'}status, scoreRaw: ${'$'}score) {
-            |) {
-                |SaveMediaListEntry(
-                    |id: ${'$'}listId, progress: ${'$'}progress, status: ${'$'}status,
-                    |scoreRaw: ${'$'}score, startedAt: ${'$'}startedAt, completedAt: ${'$'}completedAt
-                |) {
                     |id
                     |status
                     |progress
@@ -95,8 +82,6 @@ class AnilistApi(val client: OkHttpClient, interceptor: AnilistInterceptor) {
                     put("progress", track.last_chapter_read)
                     put("status", track.toAnilistStatus())
                     put("score", track.score.toInt())
-                    put("startedAt", createDate(track.started_reading_date))
-                    put("completedAt", createDate(track.finished_reading_date))
                 }
             }
             authClient.newCall(POST(apiUrl, body = payload.toString().toRequestBody(jsonMime)))
@@ -107,7 +92,8 @@ class AnilistApi(val client: OkHttpClient, interceptor: AnilistInterceptor) {
 
     suspend fun search(search: String): List<TrackSearch> {
         return withIOContext {
-            val query = """
+            val query =
+                """
             |query Search(${'$'}query: String) {
                 |Page (perPage: 50) {
                     |media(search: ${'$'}query, type: MANGA, format_not_in: [NOVEL]) {
@@ -157,7 +143,8 @@ class AnilistApi(val client: OkHttpClient, interceptor: AnilistInterceptor) {
 
     suspend fun findLibManga(track: Track, userid: Int): Track? {
         return withIOContext {
-            val query = """
+            val query =
+                """
             |query (${'$'}id: Int!, ${'$'}manga_id: Int!) {
                 |Page {
                     |mediaList(userId: ${'$'}id, type: MANGA, mediaId: ${'$'}manga_id) {
@@ -165,16 +152,6 @@ class AnilistApi(val client: OkHttpClient, interceptor: AnilistInterceptor) {
                         |status
                         |scoreRaw: score(format: POINT_100)
                         |progress
-                        |startedAt {
-                            |year
-                            |month
-                            |day
-                        |}
-                        |completedAt {
-                            |year
-                            |month
-                            |day
-                        |}
                         |media {
                             |id
                             |title {
@@ -232,7 +209,8 @@ class AnilistApi(val client: OkHttpClient, interceptor: AnilistInterceptor) {
 
     suspend fun getCurrentUser(): Pair<Int, String> {
         return withIOContext {
-            val query = """
+            val query =
+                """
             |query User {
                 |Viewer {
                     |id
@@ -265,6 +243,21 @@ class AnilistApi(val client: OkHttpClient, interceptor: AnilistInterceptor) {
     }
 
     private fun jsonToALManga(struct: JsonObject): ALManga {
+        val date = try {
+            val date = Calendar.getInstance()
+            date.set(
+                struct["startDate"]!!.jsonObject["year"]!!.jsonPrimitive.intOrNull ?: 0,
+                (
+                    struct["startDate"]!!.jsonObject["month"]!!.jsonPrimitive.intOrNull
+                        ?: 0
+                    ) - 1,
+                struct["startDate"]!!.jsonObject["day"]!!.jsonPrimitive.intOrNull ?: 0
+            )
+            date.timeInMillis
+        } catch (_: Exception) {
+            0L
+        }
+
         return ALManga(
             struct["id"]!!.jsonPrimitive.int,
             struct["title"]!!.jsonObject["romaji"]!!.jsonPrimitive.content,
@@ -272,7 +265,7 @@ class AnilistApi(val client: OkHttpClient, interceptor: AnilistInterceptor) {
             struct["description"]!!.jsonPrimitive.contentOrNull,
             struct["type"]!!.jsonPrimitive.content,
             struct["status"]!!.jsonPrimitive.contentOrNull ?: "",
-            parseDate(struct, "startDate"),
+            date,
             struct["chapters"]!!.jsonPrimitive.intOrNull ?: 0
         )
     }
@@ -283,44 +276,10 @@ class AnilistApi(val client: OkHttpClient, interceptor: AnilistInterceptor) {
             struct["status"]!!.jsonPrimitive.content,
             struct["scoreRaw"]!!.jsonPrimitive.int,
             struct["progress"]!!.jsonPrimitive.int,
-            parseDate(struct, "startedAt"),
-            parseDate(struct, "completedAt"),
             jsonToALManga(struct["media"]!!.jsonObject)
         )
     }
 
-    private fun parseDate(struct: JsonObject, dateKey: String): Long {
-        return try {
-            val date = Calendar.getInstance()
-            date.set(
-                struct[dateKey]!!.jsonObject["year"]!!.jsonPrimitive.int,
-                struct[dateKey]!!.jsonObject["month"]!!.jsonPrimitive.int - 1,
-                struct[dateKey]!!.jsonObject["day"]!!.jsonPrimitive.int
-            )
-            date.timeInMillis
-        } catch (_: Exception) {
-            0L
-        }
-    }
-
-    private fun createDate(dateValue: Long): JsonObject {
-        if (dateValue == 0L) {
-            return buildJsonObject {
-                put("year", JsonNull)
-                put("month", JsonNull)
-                put("day", JsonNull)
-            }
-        }
-
-        val calendar = Calendar.getInstance()
-        calendar.timeInMillis = dateValue
-        return buildJsonObject {
-            put("year", calendar.year)
-            put("month", calendar.month + 1)
-            put("day", calendar.dayOfMonth)
-        }
-    }
-
     companion object {
         private const val clientId = "385"
         private const val apiUrl = "https://graphql.anilist.co/"

app/src/main/java/eu/kanade/tachiyomi/data/track/anilist/AnilistModels.kt

@@ -44,8 +44,6 @@ data class ALUserManga(
     val list_status: String,
     val score_raw: Int,
     val chapters_read: Int,
-    val start_date_fuzzy: Long,
-    val completed_date_fuzzy: Long,
     val manga: ALManga
 ) {
 
@@ -53,8 +51,6 @@ data class ALUserManga(
         media_id = manga.media_id
         status = toTrackStatus()
         score = score_raw.toFloat()
-        started_reading_date = start_date_fuzzy
-        finished_reading_date = completed_date_fuzzy
         last_chapter_read = chapters_read
         library_id = this@ALUserManga.library_id
         total_chapters = manga.total_chapters

app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/Bangumi.kt

@@ -31,7 +31,7 @@ class Bangumi(private val context: Context, id: Int) : TrackService(id) {
         return track.score.toInt().toString()
     }
 
-    private suspend fun add(track: Track): Track {
+    override suspend fun add(track: Track): Track {
         return api.addLibManga(track)
     }
 
@@ -45,10 +45,8 @@ class Bangumi(private val context: Context, id: Int) : TrackService(id) {
         return if (remoteTrack != null && statusTrack != null) {
             track.copyPersonalFrom(remoteTrack)
             track.library_id = remoteTrack.library_id
-            track.status = statusTrack.status
+            track.status = remoteTrack.status
-            track.score = statusTrack.score
+            track.last_chapter_read = remoteTrack.last_chapter_read
-            track.last_chapter_read = statusTrack.last_chapter_read
-            track.total_chapters = remoteTrack.total_chapters
             refresh(track)
         } else {
             // Set default fields if it's not found in the list
@@ -68,6 +66,7 @@ class Bangumi(private val context: Context, id: Int) : TrackService(id) {
         track.copyPersonalFrom(remoteStatusTrack!!)
         api.findLibManga(track)?.let { remoteTrack ->
             track.total_chapters = remoteTrack.total_chapters
+            track.status = remoteTrack.status
         }
         return track
     }

app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/BangumiApi.kt

@@ -13,7 +13,6 @@ import eu.kanade.tachiyomi.util.lang.withIOContext
 import kotlinx.serialization.decodeFromString
 import kotlinx.serialization.json.Json
 import kotlinx.serialization.json.JsonObject
-import kotlinx.serialization.json.contentOrNull
 import kotlinx.serialization.json.int
 import kotlinx.serialization.json.jsonArray
 import kotlinx.serialization.json.jsonObject
@@ -47,7 +46,6 @@ class BangumiApi(private val client: OkHttpClient, interceptor: BangumiIntercept
         return withIOContext {
             // read status update
             val sbody = FormBody.Builder()
-                .add("rating", track.score.toInt().toString())
                 .add("status", track.toBangumiStatus())
                 .build()
             authClient.newCall(POST("$apiUrl/collection/${track.media_id}/update", body = sbody))
@@ -93,24 +91,12 @@ class BangumiApi(private val client: OkHttpClient, interceptor: BangumiIntercept
     }
 
     private fun jsonToSearch(obj: JsonObject): TrackSearch {
-        val coverUrl = if (obj["images"] is JsonObject) {
-            obj["images"]?.jsonObject?.get("common")?.jsonPrimitive?.contentOrNull ?: ""
-        } else {
-            // Sometimes JsonNull
-            ""
-        }
-        val totalChapters = if (obj["eps_count"] != null) {
-            obj["eps_count"]!!.jsonPrimitive.int
-        } else {
-            0
-        }
         return TrackSearch.create(TrackManager.BANGUMI).apply {
             media_id = obj["id"]!!.jsonPrimitive.int
             title = obj["name_cn"]!!.jsonPrimitive.content
-            cover_url = coverUrl
+            cover_url = obj["images"]!!.jsonObject["common"]!!.jsonPrimitive.content
             summary = obj["name"]!!.jsonPrimitive.content
             tracking_url = obj["url"]!!.jsonPrimitive.content
-            total_chapters = totalChapters
         }
     }
 
@@ -133,21 +119,14 @@ class BangumiApi(private val client: OkHttpClient, interceptor: BangumiIntercept
                 .build()
 
             // TODO: get user readed chapter here
-            var response = authClient.newCall(requestUserRead).await()
+            authClient.newCall(requestUserRead)
-            var responseBody = response.body?.string().orEmpty()
+                .await()
-            if (responseBody.isEmpty()) {
+                .parseAs<Collection>()
-                throw Exception("Null Response")
+                .let {
-            }
-            if (responseBody.contains("\"code\":400")) {
-                null
-            } else {
-                json.decodeFromString<Collection>(responseBody).let {
                     track.status = it.status?.id!!
                     track.last_chapter_read = it.ep_status!!
-                    track.score = it.rating!!
                     track
                 }
-            }
         }
     }
 

app/src/main/java/eu/kanade/tachiyomi/data/track/bangumi/Collection.kt

@@ -8,7 +8,7 @@ data class Collection(
     val comment: String? = "",
     val ep_status: Int? = 0,
     val lasttouch: Int? = 0,
-    val rating: Float? = 0f,
+    val rating: Int? = 0,
     val status: Status? = Status(),
     val tag: List<String?>? = listOf(),
     val user: User? = User(),

app/src/main/java/eu/kanade/tachiyomi/data/track/kitsu/Kitsu.kt

@@ -67,7 +67,7 @@ class Kitsu(private val context: Context, id: Int) : TrackService(id) {
         return df.format(track.score)
     }
 
-    private suspend fun add(track: Track): Track {
+    override suspend fun add(track: Track): Track {
         return api.addLibManga(track, getUserId())
     }
 

app/src/main/java/eu/kanade/tachiyomi/data/track/komga/Komga.kt

@@ -1,95 +0,0 @@
-package eu.kanade.tachiyomi.data.track.komga
-
-import android.content.Context
-import android.graphics.Color
-import androidx.annotation.StringRes
-import eu.kanade.tachiyomi.R
-import eu.kanade.tachiyomi.data.database.models.Manga
-import eu.kanade.tachiyomi.data.database.models.Track
-import eu.kanade.tachiyomi.data.track.NoLoginTrackService
-import eu.kanade.tachiyomi.data.track.TrackService
-import eu.kanade.tachiyomi.data.track.UnattendedTrackService
-import eu.kanade.tachiyomi.data.track.model.TrackSearch
-import eu.kanade.tachiyomi.source.Source
-import okhttp3.Dns
-import okhttp3.OkHttpClient
-
-class Komga(private val context: Context, id: Int) : TrackService(id), UnattendedTrackService, NoLoginTrackService {
-
-    companion object {
-        const val UNREAD = 1
-        const val READING = 2
-        const val COMPLETED = 3
-
-        const val ACCEPTED_SOURCE = "eu.kanade.tachiyomi.extension.all.komga.Komga"
-    }
-
-    override val client: OkHttpClient =
-        networkService.client.newBuilder()
-            .dns(Dns.SYSTEM) // don't use DNS over HTTPS as it breaks IP addressing
-            .build()
-
-    val api by lazy { KomgaApi(client) }
-
-    @StringRes
-    override fun nameRes() = R.string.tracker_komga
-
-    override fun getLogo() = R.drawable.ic_tracker_komga
-
-    override fun getLogoColor() = Color.rgb(51, 37, 50)
-
-    override fun getStatusList() = listOf(UNREAD, READING, COMPLETED)
-
-    override fun getStatus(status: Int): String = with(context) {
-        when (status) {
-            UNREAD -> getString(R.string.unread)
-            READING -> getString(R.string.currently_reading)
-            COMPLETED -> getString(R.string.completed)
-            else -> ""
-        }
-    }
-
-    override fun getCompletionStatus(): Int = COMPLETED
-
-    override fun getScoreList(): List<String> = emptyList()
-
-    override fun displayScore(track: Track): String = ""
-
-    override suspend fun update(track: Track): Track {
-        return api.updateProgress(track)
-    }
-
-    override suspend fun bind(track: Track): Track {
-        return track
-    }
-
-    override suspend fun search(query: String): List<TrackSearch> {
-        TODO("Not yet implemented: search")
-    }
-
-    override suspend fun refresh(track: Track): Track {
-        val remoteTrack = api.getTrackSearch(track.tracking_url)!!
-        track.copyPersonalFrom(remoteTrack)
-        track.total_chapters = remoteTrack.total_chapters
-        return track
-    }
-
-    override suspend fun login(username: String, password: String) {
-        saveCredentials("user", "pass")
-    }
-
-    // TrackService.isLogged works by checking that credentials are saved.
-    // By saving dummy, unused credentials, we can activate the tracker simply by login/logout
-    override fun loginNoop() {
-        saveCredentials("user", "pass")
-    }
-
-    override fun accept(source: Source): Boolean = source::class.qualifiedName == ACCEPTED_SOURCE
-
-    override suspend fun match(manga: Manga): TrackSearch? =
-        try {
-            api.getTrackSearch(manga.url)
-        } catch (e: Exception) {
-            null
-        }
-}

app/src/main/java/eu/kanade/tachiyomi/data/track/komga/KomgaApi.kt

@@ -1,84 +0,0 @@
-package eu.kanade.tachiyomi.data.track.komga
-
-import eu.kanade.tachiyomi.data.database.models.Track
-import eu.kanade.tachiyomi.data.track.TrackManager
-import eu.kanade.tachiyomi.data.track.model.TrackSearch
-import eu.kanade.tachiyomi.network.GET
-import eu.kanade.tachiyomi.network.await
-import eu.kanade.tachiyomi.network.parseAs
-import eu.kanade.tachiyomi.util.lang.withIOContext
-import kotlinx.serialization.encodeToString
-import kotlinx.serialization.json.Json
-import okhttp3.MediaType.Companion.toMediaType
-import okhttp3.OkHttpClient
-import okhttp3.Request
-import okhttp3.RequestBody.Companion.toRequestBody
-import timber.log.Timber
-import uy.kohesive.injekt.injectLazy
-
-const val READLIST_API = "/api/v1/readlists"
-
-class KomgaApi(private val client: OkHttpClient) {
-
-    private val json: Json by injectLazy()
-
-    suspend fun getTrackSearch(url: String): TrackSearch =
-        withIOContext {
-            try {
-                val track = if (url.contains(READLIST_API)) {
-                    client.newCall(GET(url))
-                        .await()
-                        .parseAs<ReadListDto>()
-                        .toTrack()
-                } else {
-                    client.newCall(GET(url))
-                        .await()
-                        .parseAs<SeriesDto>()
-                        .toTrack()
-                }
-
-                val progress = client
-                    .newCall(GET("$url/read-progress/tachiyomi"))
-                    .await()
-                    .parseAs<ReadProgressDto>()
-
-                track.apply {
-                    cover_url = "$url/thumbnail"
-                    tracking_url = url
-                    total_chapters = progress.booksCount
-                    status = when (progress.booksCount) {
-                        progress.booksUnreadCount -> Komga.UNREAD
-                        progress.booksReadCount -> Komga.COMPLETED
-                        else -> Komga.READING
-                    }
-                    last_chapter_read = progress.lastReadContinuousIndex
-                }
-            } catch (e: Exception) {
-                Timber.w(e, "Could not get item: $url")
-                throw e
-            }
-        }
-
-    suspend fun updateProgress(track: Track): Track {
-        val progress = ReadProgressUpdateDto(track.last_chapter_read)
-        val payload = json.encodeToString(progress)
-        client.newCall(
-            Request.Builder()
-                .url("${track.tracking_url}/read-progress/tachiyomi")
-                .put(payload.toRequestBody("application/json".toMediaType()))
-                .build()
-        )
-            .await()
-        return getTrackSearch(track.tracking_url)
-    }
-
-    private fun SeriesDto.toTrack(): TrackSearch = TrackSearch.create(TrackManager.KOMGA).also {
-        it.title = metadata.title
-        it.summary = metadata.summary
-        it.publishing_status = metadata.status
-    }
-
-    private fun ReadListDto.toTrack(): TrackSearch = TrackSearch.create(TrackManager.KOMGA).also {
-        it.title = name
-    }
-}

app/src/main/java/eu/kanade/tachiyomi/data/track/komga/KomgaModels.kt

@@ -1,83 +0,0 @@
-package eu.kanade.tachiyomi.data.track.komga
-
-import kotlinx.serialization.Serializable
-
-@Serializable
-data class SeriesDto(
-    val id: String,
-    val libraryId: String,
-    val name: String,
-    val created: String?,
-    val lastModified: String?,
-    val fileLastModified: String,
-    val booksCount: Int,
-    val booksReadCount: Int,
-    val booksUnreadCount: Int,
-    val booksInProgressCount: Int,
-    val metadata: SeriesMetadataDto,
-    val booksMetadata: BookMetadataAggregationDto
-)
-
-@Serializable
-data class SeriesMetadataDto(
-    val status: String,
-    val created: String?,
-    val lastModified: String?,
-    val title: String,
-    val titleSort: String,
-    val summary: String,
-    val summaryLock: Boolean,
-    val readingDirection: String,
-    val readingDirectionLock: Boolean,
-    val publisher: String,
-    val publisherLock: Boolean,
-    val ageRating: Int?,
-    val ageRatingLock: Boolean,
-    val language: String,
-    val languageLock: Boolean,
-    val genres: Set<String>,
-    val genresLock: Boolean,
-    val tags: Set<String>,
-    val tagsLock: Boolean
-)
-
-@Serializable
-data class BookMetadataAggregationDto(
-    val authors: List<AuthorDto> = emptyList(),
-    val releaseDate: String?,
-    val summary: String,
-    val summaryNumber: String,
-
-    val created: String,
-    val lastModified: String
-)
-
-@Serializable
-data class AuthorDto(
-    val name: String,
-    val role: String
-)
-
-@Serializable
-data class ReadProgressUpdateDto(
-    val lastBookRead: Int,
-)
-
-@Serializable
-data class ReadListDto(
-    val id: String,
-    val name: String,
-    val bookIds: List<String>,
-    val createdDate: String,
-    val lastModifiedDate: String,
-    val filtered: Boolean
-)
-
-@Serializable
-data class ReadProgressDto(
-    val booksCount: Int,
-    val booksReadCount: Int,
-    val booksUnreadCount: Int,
-    val booksInProgressCount: Int,
-    val lastReadContinuousIndex: Int,
-)

app/src/main/java/eu/kanade/tachiyomi/data/track/mdlist/MdList.kt

@@ -9,19 +9,17 @@ import eu.kanade.tachiyomi.data.database.models.Track
 import eu.kanade.tachiyomi.data.track.TrackManager
 import eu.kanade.tachiyomi.data.track.TrackService
 import eu.kanade.tachiyomi.data.track.model.TrackSearch
+import eu.kanade.tachiyomi.source.model.SManga
 import eu.kanade.tachiyomi.source.model.toMangaInfo
 import eu.kanade.tachiyomi.util.lang.awaitSingle
 import eu.kanade.tachiyomi.util.lang.runAsObservable
-import eu.kanade.tachiyomi.util.lang.withIOContext
 import exh.md.utils.FollowStatus
 import exh.md.utils.MdUtil
 import tachiyomi.source.model.MangaInfo
-import uy.kohesive.injekt.Injekt
-import uy.kohesive.injekt.api.get
 
 class MdList(private val context: Context, id: Int) : TrackService(id) {
 
-    private val mdex by lazy { MdUtil.getEnabledMangaDex(Injekt.get()) }
+    private val mdex by lazy { MdUtil.getEnabledMangaDex() }
 
     @StringRes
     override fun nameRes(): Int = R.string.mdlist
@@ -45,88 +43,83 @@ class MdList(private val context: Context, id: Int) : TrackService(id) {
 
     override fun displayScore(track: Track) = track.score.toInt().toString()
 
+    override suspend fun add(track: Track): Track = update(track)
+
     override suspend fun update(track: Track): Track {
-        return withIOContext {
+        val mdex = mdex ?: throw MangaDexNotFoundException()
-            val mdex = mdex ?: throw MangaDexNotFoundException()
 
-            val remoteTrack = mdex.fetchTrackingInfo(track.tracking_url)
+        val remoteTrack = mdex.fetchTrackingInfo(track.tracking_url)
-            val followStatus = FollowStatus.fromInt(track.status)
+        val followStatus = FollowStatus.fromInt(track.status)
 
-            // this updates the follow status in the metadata
+        // this updates the follow status in the metadata
-            // allow follow status to update
+        // allow follow status to update
-            if (remoteTrack.status != followStatus.int) {
+        if (remoteTrack.status != followStatus.int) {
-                if (mdex.updateFollowStatus(MdUtil.getMangaId(track.tracking_url), followStatus)) {
+            mdex.updateFollowStatus(MdUtil.getMangaId(track.tracking_url), followStatus)
-                    remoteTrack.status = followStatus.int
+            remoteTrack.status = followStatus.int
-                } else {
+            // db.insertFlatMetadataAsync(mangaMetadata.flatten()).await()
-                    track.status = remoteTrack.status
-                }
-            }
-
-            /*if (track.score.toInt() > 0) {
-                mdex.updateRating(track)
-            }
-
-            // mangadex wont update chapters if manga is not follows this prevents unneeded network call
-
-            if (followStatus != FollowStatus.UNFOLLOWED) {
-                if (track.total_chapters != 0 && track.last_chapter_read == track.total_chapters) {
-                    track.status = FollowStatus.COMPLETED.int
-                    mdex.updateFollowStatus(MdUtil.getMangaId(track.tracking_url), FollowStatus.COMPLETED)
-                }
-                if (followStatus == FollowStatus.PLAN_TO_READ && track.last_chapter_read > 0) {
-                    val newFollowStatus = FollowStatus.READING
-                    track.status = FollowStatus.READING.int
-                    mdex.updateFollowStatus(MdUtil.getMangaId(track.tracking_url), newFollowStatus)
-                    remoteTrack.status = newFollowStatus.int
-                }
-
-                mdex.updateReadingProgress(track)
-            } else if (track.last_chapter_read != 0) {
-                // When followStatus has been changed to unfollowed 0 out read chapters since dex does
-                track.last_chapter_read = 0
-            }*/
-            track
         }
+
+        if (track.score.toInt() > 0) {
+            mdex.updateRating(track)
+        }
+
+        // mangadex wont update chapters if manga is not follows this prevents unneeded network call
+
+        if (followStatus != FollowStatus.UNFOLLOWED) {
+            if (track.total_chapters != 0 && track.last_chapter_read == track.total_chapters) {
+                track.status = FollowStatus.COMPLETED.int
+                mdex.updateFollowStatus(MdUtil.getMangaId(track.tracking_url), FollowStatus.COMPLETED)
+            }
+            if (followStatus == FollowStatus.PLAN_TO_READ && track.last_chapter_read > 0) {
+                val newFollowStatus = FollowStatus.READING
+                track.status = FollowStatus.READING.int
+                mdex.updateFollowStatus(MdUtil.getMangaId(track.tracking_url), newFollowStatus)
+                remoteTrack.status = newFollowStatus.int
+                // db.insertFlatMetadataAsync(mangaMetadata.flatten()).await()
+            }
+
+            mdex.updateReadingProgress(track)
+        } else if (track.last_chapter_read != 0) {
+            // When followStatus has been changed to unfollowed 0 out read chapters since dex does
+            track.last_chapter_read = 0
+        }
+        return track
     }
 
     override fun getCompletionStatus(): Int = FollowStatus.COMPLETED.int
 
-    override suspend fun bind(track: Track): Track = update(refresh(track).also { if (it.status == FollowStatus.UNFOLLOWED.int) it.status = FollowStatus.READING.int })
+    override suspend fun bind(track: Track): Track = update(refresh(track))
 
     override suspend fun refresh(track: Track): Track {
-        return withIOContext {
+        val mdex = mdex ?: throw MangaDexNotFoundException()
-            val mdex = mdex ?: throw MangaDexNotFoundException()
+        val (remoteTrack, mangaMetadata) = mdex.getTrackingAndMangaInfo(track)
-            val (remoteTrack, mangaMetadata) = mdex.getTrackingAndMangaInfo(track)
+        track.copyPersonalFrom(remoteTrack)
-            track.copyPersonalFrom(remoteTrack)
+        if (track.total_chapters == 0 && mangaMetadata.status == SManga.COMPLETED) {
-            /*if (track.total_chapters == 0 && mangaMetadata.status == SManga.COMPLETED) {
+            track.total_chapters = mangaMetadata.maxChapterNumber ?: 0
-                track.total_chapters = mangaMetadata.maxChapterNumber ?: 0
-            }*/
-            track
         }
+        return track
     }
 
     fun createInitialTracker(dbManga: Manga, mdManga: Manga = dbManga): Track {
-        return Track.create(TrackManager.MDLIST).apply {
+        val track = Track.create(TrackManager.MDLIST)
-            manga_id = dbManga.id!!
+        track.manga_id = dbManga.id!!
-            status = FollowStatus.UNFOLLOWED.int
+        track.status = FollowStatus.UNFOLLOWED.int
-            tracking_url = MdUtil.baseUrl + mdManga.url
+        track.tracking_url = MdUtil.baseUrl + mdManga.url
-            title = mdManga.title
+        track.title = mdManga.title
-        }
+        return track
     }
 
     override suspend fun search(query: String): List<TrackSearch> {
-        return withIOContext {
+        val mdex = mdex ?: throw MangaDexNotFoundException()
-            val mdex = mdex ?: throw MangaDexNotFoundException()
+        return mdex.fetchSearchManga(0, query, mdex.getFilterList())
-            mdex.fetchSearchManga(0, query, mdex.getFilterList())
+            .flatMap { page ->
-                .flatMap { page ->
+                runAsObservable({
-                    runAsObservable({
+                    page.mangas.map {
-                        page.mangas.map {
+                        toTrackSearch(mdex.getMangaDetails(it.toMangaInfo()))
-                            toTrackSearch(mdex.getMangaDetails(it.toMangaInfo()))
+                    }
-                        }
+                })
-                    })
+            }
-                }
+            .awaitSingle()
-                .awaitSingle()
-        }
     }
 
     private fun toTrackSearch(mangaInfo: MangaInfo): TrackSearch = TrackSearch.create(TrackManager.MDLIST).apply {

app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeList.kt

@@ -66,7 +66,7 @@ class MyAnimeList(private val context: Context, id: Int) : TrackService(id) {
         return track.score.toInt().toString()
     }
 
-    private suspend fun add(track: Track): Track {
+    override suspend fun add(track: Track): Track {
         track.status = READING
         track.score = 0F
         return api.updateItem(track)

app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/MyAnimeListInterceptor.kt

@@ -11,6 +11,9 @@ class MyAnimeListInterceptor(private val myanimelist: MyAnimeList, private var t
     private val json: Json by injectLazy()
 
     private var oauth: OAuth? = null
+        set(value) {
+            field = value?.copy(expires_in = System.currentTimeMillis() + (value.expires_in * 1000))
+        }
 
     override fun intercept(chain: Interceptor.Chain): Response {
         val originalRequest = chain.request()
@@ -21,19 +24,21 @@ class MyAnimeListInterceptor(private val myanimelist: MyAnimeList, private var t
         if (oauth == null) {
             oauth = myanimelist.loadOAuth()
         }
-        // Refresh access token if expired
+        // Refresh access token if null or expired.
-        if (oauth != null && oauth!!.isExpired()) {
+        if (oauth!!.isExpired()) {
             chain.proceed(MyAnimeListApi.refreshTokenRequest(oauth!!.refresh_token)).use {
                 if (it.isSuccessful) {
                     setAuth(json.decodeFromString(it.body!!.string()))
                 }
             }
         }
+
+        // Throw on null auth.
         if (oauth == null) {
             throw Exception("No authentication token")
         }
 
-        // Add the authorization header to the original request
+        // Add the authorization header to the original request.
         val authRequest = originalRequest.newBuilder()
             .addHeader("Authorization", "Bearer ${oauth!!.access_token}")
             .build()

app/src/main/java/eu/kanade/tachiyomi/data/track/myanimelist/OAuth.kt

@@ -7,9 +7,8 @@ data class OAuth(
     val refresh_token: String,
     val access_token: String,
     val token_type: String,
-    val created_at: Long = System.currentTimeMillis(),
     val expires_in: Long
 ) {
 
-    fun isExpired() = System.currentTimeMillis() > created_at + (expires_in * 1000)
+    fun isExpired() = System.currentTimeMillis() > expires_in
 }

app/src/main/java/eu/kanade/tachiyomi/data/track/shikimori/Shikimori.kt

@@ -40,7 +40,7 @@ class Shikimori(private val context: Context, id: Int) : TrackService(id) {
         return track.score.toInt().toString()
     }
 
-    private suspend fun add(track: Track): Track {
+    override suspend fun add(track: Track): Track {
         return api.addLibManga(track, getUsername())
     }
 

app/src/main/java/eu/kanade/tachiyomi/data/updater/UpdaterJob.kt

@@ -1,6 +1,9 @@
 package eu.kanade.tachiyomi.data.updater
 
+import android.app.PendingIntent
 import android.content.Context
+import android.content.Intent
+import androidx.core.app.NotificationCompat
 import androidx.work.Constraints
 import androidx.work.ExistingPeriodicWorkPolicy
 import androidx.work.NetworkType
@@ -8,26 +11,52 @@ import androidx.work.PeriodicWorkRequestBuilder
 import androidx.work.WorkManager
 import androidx.work.Worker
 import androidx.work.WorkerParameters
+import eu.kanade.tachiyomi.R
+import eu.kanade.tachiyomi.data.notification.Notifications
 import eu.kanade.tachiyomi.data.updater.github.GithubUpdateChecker
+import eu.kanade.tachiyomi.util.system.notificationManager
 import kotlinx.coroutines.runBlocking
 import java.util.concurrent.TimeUnit
 
 class UpdaterJob(private val context: Context, workerParams: WorkerParameters) :
     Worker(context, workerParams) {
 
-    override fun doWork() = runBlocking {
+    override fun doWork(): Result {
-        try {
+        return runBlocking {
-            val result = GithubUpdateChecker().checkForUpdate()
+            try {
+                val result = GithubUpdateChecker().checkForUpdate()
 
-            if (result is UpdateResult.NewUpdate<*>) {
+                if (result is UpdateResult.NewUpdate<*>) {
-                UpdaterNotifier(context).promptUpdate(result.release.downloadLink)
+                    val url = result.release.downloadLink
+
+                    val intent = Intent(context, UpdaterService::class.java).apply {
+                        putExtra(UpdaterService.EXTRA_DOWNLOAD_URL, url)
+                    }
+
+                    NotificationCompat.Builder(context, Notifications.CHANNEL_COMMON).update {
+                        setContentTitle(context.getString(R.string.app_name))
+                        setContentText(context.getString(R.string.update_check_notification_update_available))
+                        setSmallIcon(android.R.drawable.stat_sys_download_done)
+                        // Download action
+                        addAction(
+                            android.R.drawable.stat_sys_download_done,
+                            context.getString(R.string.action_download),
+                            PendingIntent.getService(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT)
+                        )
+                    }
+                }
+                Result.success()
+            } catch (e: Exception) {
+                Result.failure()
             }
-            Result.success()
-        } catch (e: Exception) {
-            Result.failure()
         }
     }
 
+    fun NotificationCompat.Builder.update(block: NotificationCompat.Builder.() -> Unit) {
+        block()
+        context.notificationManager.notify(Notifications.ID_UPDATER, build())
+    }
+
     companion object {
         private const val TAG = "UpdateChecker"
 

app/src/main/java/eu/kanade/tachiyomi/data/updater/UpdaterNotifier.kt

@@ -1,8 +1,6 @@
 package eu.kanade.tachiyomi.data.updater
 
-import android.app.PendingIntent
 import android.content.Context
-import android.content.Intent
 import android.net.Uri
 import androidx.core.app.NotificationCompat
 import eu.kanade.tachiyomi.R
@@ -30,27 +28,6 @@ internal class UpdaterNotifier(private val context: Context) {
         context.notificationManager.notify(id, build())
     }
 
-    fun promptUpdate(url: String) {
-        val intent = Intent(context, UpdaterService::class.java).apply {
-            putExtra(UpdaterService.EXTRA_DOWNLOAD_URL, url)
-        }
-        val pendingIntent = PendingIntent.getService(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT)
-        with(notificationBuilder) {
-            setContentTitle(context.getString(R.string.app_name))
-            setContentText(context.getString(R.string.update_check_notification_update_available))
-            setSmallIcon(android.R.drawable.stat_sys_download_done)
-            setContentIntent(pendingIntent)
-
-            clearActions()
-            addAction(
-                android.R.drawable.stat_sys_download_done,
-                context.getString(R.string.action_download),
-                pendingIntent
-            )
-        }
-        notificationBuilder.show()
-    }
-
     /**
      * Call when apk download starts.
      *
@@ -86,20 +63,19 @@ internal class UpdaterNotifier(private val context: Context) {
      * @param uri path location of apk.
      */
     fun onDownloadFinished(uri: Uri) {
-        val installIntent = NotificationHandler.installApkPendingActivity(context, uri)
         with(notificationBuilder) {
             setContentText(context.getString(R.string.update_check_notification_download_complete))
             setSmallIcon(android.R.drawable.stat_sys_download_done)
             setOnlyAlertOnce(false)
             setProgress(0, 0, false)
-            setContentIntent(installIntent)
+            // Install action
-
+            setContentIntent(NotificationHandler.installApkPendingActivity(context, uri))
-            clearActions()
             addAction(
                 R.drawable.ic_system_update_alt_white_24dp,
                 context.getString(R.string.action_install),
-                installIntent
+                NotificationHandler.installApkPendingActivity(context, uri)
             )
+            // Cancel action
             addAction(
                 R.drawable.ic_close_24dp,
                 context.getString(R.string.action_cancel),
@@ -120,13 +96,13 @@ internal class UpdaterNotifier(private val context: Context) {
             setSmallIcon(android.R.drawable.stat_sys_warning)
             setOnlyAlertOnce(false)
             setProgress(0, 0, false)
-
+            // Retry action
-            clearActions()
             addAction(
                 R.drawable.ic_refresh_24dp,
                 context.getString(R.string.action_retry),
                 UpdaterService.downloadApkPendingService(context, url)
             )
+            // Cancel action
             addAction(
                 R.drawable.ic_close_24dp,
                 context.getString(R.string.action_cancel),

app/src/main/java/eu/kanade/tachiyomi/data/updater/github/GithubUpdateChecker.kt

@@ -32,8 +32,8 @@ class GithubUpdateChecker {
                 .parseAs<GithubRelease>()
                 .let {
                     // Check if latest version is different from current version
-                    if (/* SY --> */ isNewVersionSY(it.version) /* SY <-- */) {
+        			if (/* SY --> */ isNewVersionSY(it.version) /* SY <-- */) {
-                        GithubUpdateResult.NewUpdate(it)
+						GithubUpdateResult.NewUpdate(it)
                     } else {
                         GithubUpdateResult.NoNewUpdate()
                     }

app/src/main/java/eu/kanade/tachiyomi/extension/ExtensionManager.kt

@@ -3,6 +3,7 @@ package eu.kanade.tachiyomi.extension
 import android.content.Context
 import android.graphics.drawable.Drawable
 import androidx.core.content.ContextCompat
+import com.elvishew.xlog.XLog
 import com.jakewharton.rxrelay.BehaviorRelay
 import eu.kanade.tachiyomi.R
 import eu.kanade.tachiyomi.data.preference.PreferencesHelper
@@ -18,7 +19,6 @@ import eu.kanade.tachiyomi.source.Source
 import eu.kanade.tachiyomi.source.SourceManager
 import eu.kanade.tachiyomi.util.lang.launchNow
 import eu.kanade.tachiyomi.util.system.toast
-import exh.log.xLogD
 import exh.source.BlacklistedSources
 import exh.source.EH_SOURCE_ID
 import exh.source.EXH_SOURCE_ID
@@ -156,15 +156,15 @@ class ExtensionManager(
     // EXH -->
     private fun <T : Extension> Iterable<T>.filterNotBlacklisted(): List<T> {
         val blacklistEnabled = preferences.enableSourceBlacklist().get()
-        return filterNot { extension ->
+        return filter {
-            extension.isBlacklisted(blacklistEnabled)
+            if (it.isBlacklisted(blacklistEnabled)) {
-                .also {
+                XLog.tag("ExtensionManager").d("Removing blacklisted extension: (name: %s, pkgName: %s)!", it.name, it.pkgName)
-                    if (it) this@ExtensionManager.xLogD("Removing blacklisted extension: (name: %s, pkgName: %s)!", extension.name, extension.pkgName)
+                false
-                }
+            } else true
         }
     }
 
-    private fun Extension.isBlacklisted(blacklistEnabled: Boolean = preferences.enableSourceBlacklist().get()): Boolean {
+    fun Extension.isBlacklisted(blacklistEnabled: Boolean = preferences.enableSourceBlacklist().get()): Boolean {
         return pkgName in BlacklistedSources.BLACKLISTED_EXTENSIONS && blacklistEnabled
     }
     // EXH <--
@@ -333,7 +333,7 @@ class ExtensionManager(
     private fun registerNewExtension(extension: Extension.Installed) {
         // SY -->
         if (extension.isBlacklisted()) {
-            xLogD("Removing blacklisted extension: (name: String, pkgName: %s)!", extension.name, extension.pkgName)
+            XLog.tag("ExtensionManager").d("Removing blacklisted extension: (name: String, pkgName: %s)!", extension.name, extension.pkgName)
             return
         }
         // SY <--
@@ -351,7 +351,7 @@ class ExtensionManager(
     private fun registerUpdatedExtension(extension: Extension.Installed) {
         // SY -->
         if (extension.isBlacklisted()) {
-            xLogD("Removing blacklisted extension: (name: %s, pkgName: %s)!", extension.name, extension.pkgName)
+            XLog.tag("ExtensionManager").d("Removing blacklisted extension: (name: String, pkgName: %s)!", extension.name, extension.pkgName)
             return
         }
         // SY <--

app/src/main/java/eu/kanade/tachiyomi/extension/api/ExtensionGithubApi.kt

@@ -32,7 +32,7 @@ internal class ExtensionGithubApi {
                 .let { parseResponse(it) }
         } /* SY --> */ + preferences.extensionRepos().get().flatMap { repoPath ->
             val url = "$BASE_URL$repoPath/repo/"
-            networkService.client
+        	networkService.client
                 .newCall(GET("${url}index.min.json"))
                 .await()
                 .parseAs<JsonArray>()

app/src/main/java/eu/kanade/tachiyomi/extension/util/ExtensionLoader.kt

@@ -163,7 +163,7 @@ internal object ExtensionLoader {
                         else -> throw Exception("Unknown source class type! ${obj.javaClass}")
                     }
                 } catch (e: Throwable) {
-                    Timber.e(e, "Extension load error: $extName ($it)")
+                    Timber.e(e, "Extension load error: $extName.")
                     return LoadResult.Error(e)
                 }
             }

app/src/main/java/eu/kanade/tachiyomi/network/CloudflareInterceptor.kt

@@ -1,14 +1,14 @@
-package eu.kanade.tachiyomi.network.interceptor
+package eu.kanade.tachiyomi.network
 
 import android.annotation.SuppressLint
 import android.content.Context
+import android.os.Build
 import android.os.Handler
 import android.os.Looper
 import android.webkit.WebSettings
 import android.webkit.WebView
 import android.widget.Toast
 import eu.kanade.tachiyomi.R
-import eu.kanade.tachiyomi.network.NetworkHelper
 import eu.kanade.tachiyomi.source.online.HttpSource
 import eu.kanade.tachiyomi.util.lang.launchUI
 import eu.kanade.tachiyomi.util.system.WebViewClientCompat
@@ -114,7 +114,10 @@ class CloudflareInterceptor(private val context: Context) : Interceptor {
                         latch.countDown()
                     }
 
-                    if (url == origRequestUrl && !challengeFound) {
+                    // HTTP error codes are only received since M
+                    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M &&
+                        url == origRequestUrl && !challengeFound
+                    ) {
                         // The first request didn't return the challenge, abort.
                         latch.countDown()
                     }
@@ -153,7 +156,6 @@ class CloudflareInterceptor(private val context: Context) : Interceptor {
 
             webView?.stopLoading()
             webView?.destroy()
-            webView = null
         }
 
         // Throw exception if we failed to bypass Cloudflare
@@ -169,6 +171,6 @@ class CloudflareInterceptor(private val context: Context) : Interceptor {
 
     companion object {
         private val SERVER_CHECK = arrayOf("cloudflare-nginx", "cloudflare")
-        private val COOKIE_NAMES = listOf("cf_clearance")
+        private val COOKIE_NAMES = listOf("__cfduid", "cf_clearance")
     }
 }

app/src/main/java/eu/kanade/tachiyomi/network/DohProviders.kt

@@ -1,40 +0,0 @@
-package eu.kanade.tachiyomi.network
-
-import okhttp3.HttpUrl.Companion.toHttpUrl
-import okhttp3.OkHttpClient
-import okhttp3.dnsoverhttps.DnsOverHttps
-import java.net.InetAddress
-
-/**
- * Based on https://github.com/square/okhttp/blob/ef5d0c83f7bbd3a0c0534e7ca23cbc4ee7550f3b/okhttp-dnsoverhttps/src/test/java/okhttp3/dnsoverhttps/DohProviders.java
- */
-
-const val PREF_DOH_CLOUDFLARE = 1
-const val PREF_DOH_GOOGLE = 2
-
-fun OkHttpClient.Builder.dohCloudflare() = dns(
-    DnsOverHttps.Builder().client(build())
-        .url("https://cloudflare-dns.com/dns-query".toHttpUrl())
-        .bootstrapDnsHosts(
-            InetAddress.getByName("162.159.36.1"),
-            InetAddress.getByName("162.159.46.1"),
-            InetAddress.getByName("1.1.1.1"),
-            InetAddress.getByName("1.0.0.1"),
-            InetAddress.getByName("162.159.132.53"),
-            InetAddress.getByName("2606:4700:4700::1111"),
-            InetAddress.getByName("2606:4700:4700::1001"),
-            InetAddress.getByName("2606:4700:4700::0064"),
-            InetAddress.getByName("2606:4700:4700::6400")
-        )
-        .build()
-)
-
-fun OkHttpClient.Builder.dohGoogle() = dns(
-    DnsOverHttps.Builder().client(build())
-        .url("https://dns.google/dns-query".toHttpUrl())
-        .bootstrapDnsHosts(
-            InetAddress.getByName("8.8.4.4"),
-            InetAddress.getByName("8.8.8.8")
-        )
-        .build()
-)

app/src/main/java/eu/kanade/tachiyomi/network/NetworkHelper.kt

@@ -1,16 +1,16 @@
 package eu.kanade.tachiyomi.network
 
 import android.content.Context
-import coil.util.CoilUtils
 import eu.kanade.tachiyomi.BuildConfig
 import eu.kanade.tachiyomi.data.preference.PreferencesHelper
-import eu.kanade.tachiyomi.network.interceptor.CloudflareInterceptor
-import eu.kanade.tachiyomi.network.interceptor.UserAgentInterceptor
 import okhttp3.Cache
+import okhttp3.HttpUrl.Companion.toHttpUrl
 import okhttp3.OkHttpClient
+import okhttp3.dnsoverhttps.DnsOverHttps
 import okhttp3.logging.HttpLoggingInterceptor
 import uy.kohesive.injekt.injectLazy
 import java.io.File
+import java.net.InetAddress
 import java.util.concurrent.TimeUnit
 
 /* SY --> */ open /* SY <-- */ class NetworkHelper(context: Context) {
@@ -21,34 +21,46 @@ import java.util.concurrent.TimeUnit
 
     private val cacheSize = 5L * 1024 * 1024 // 5 MiB
 
-    /* SY --> */ open /* SY <-- */val cookieManager = AndroidCookieJar()
+    /* SY --> */ open /* SY <-- */ val cookieManager = AndroidCookieJar()
 
-    private val baseClientBuilder: OkHttpClient.Builder
+    /* SY --> */ open /* SY <-- */ val client by lazy {
-        get() {
+        val builder = OkHttpClient.Builder()
-            val builder = OkHttpClient.Builder()
+            .cookieJar(cookieManager)
-                .cookieJar(cookieManager)
+            .cache(Cache(cacheDir, cacheSize))
-                .connectTimeout(30, TimeUnit.SECONDS)
+            .connectTimeout(30, TimeUnit.SECONDS)
-                .readTimeout(30, TimeUnit.SECONDS)
+            .readTimeout(30, TimeUnit.SECONDS)
-                .addInterceptor(UserAgentInterceptor())
+            .addInterceptor(UserAgentInterceptor())
 
-            if (BuildConfig.DEBUG) {
+        if (BuildConfig.DEBUG) {
-                val httpLoggingInterceptor = HttpLoggingInterceptor().apply {
+            val httpLoggingInterceptor = HttpLoggingInterceptor().apply {
-                    level = HttpLoggingInterceptor.Level.HEADERS
+                level = HttpLoggingInterceptor.Level.HEADERS
-                }
-                builder.addInterceptor(httpLoggingInterceptor)
             }
-
+            builder.addInterceptor(httpLoggingInterceptor)
-            when (preferences.dohProvider()) {
-                PREF_DOH_CLOUDFLARE -> builder.dohCloudflare()
-                PREF_DOH_GOOGLE -> builder.dohGoogle()
-            }
-
-            return builder
         }
 
-    /* SY --> */ open /* SY <-- */val client by lazy { baseClientBuilder.cache(Cache(cacheDir, cacheSize)).build() }
+        if (preferences.enableDoh()) {
+            builder.dns(
+                DnsOverHttps.Builder().client(builder.build())
+                    .url("https://cloudflare-dns.com/dns-query".toHttpUrl())
+                    .bootstrapDnsHosts(
+                        listOf(
+                            InetAddress.getByName("162.159.36.1"),
+                            InetAddress.getByName("162.159.46.1"),
+                            InetAddress.getByName("1.1.1.1"),
+                            InetAddress.getByName("1.0.0.1"),
+                            InetAddress.getByName("162.159.132.53"),
+                            InetAddress.getByName("2606:4700:4700::1111"),
+                            InetAddress.getByName("2606:4700:4700::1001"),
+                            InetAddress.getByName("2606:4700:4700::0064"),
+                            InetAddress.getByName("2606:4700:4700::6400")
+                        )
+                    )
+                    .build()
+            )
+        }
 
-    val coilClient by lazy { baseClientBuilder.cache(CoilUtils.createDefaultCache(context)).build() }
+        builder.build()
+    }
 
     /* SY --> */ open /* SY <-- */val cloudflareClient by lazy {
         client.newBuilder()

app/src/main/java/eu/kanade/tachiyomi/network/OkHttpExtensions.kt

@@ -9,7 +9,6 @@ import okhttp3.MediaType.Companion.toMediaType
 import okhttp3.OkHttpClient
 import okhttp3.Request
 import okhttp3.Response
-import okhttp3.internal.closeQuietly
 import rx.Observable
 import rx.Producer
 import rx.Subscription
@@ -71,9 +70,7 @@ suspend fun Call.await(): Response {
                         return
                     }
 
-                    continuation.resume(response) {
+                    continuation.resume(response)
-                        response.body?.closeQuietly()
-                    }
                 }
 
                 override fun onFailure(call: Call, e: IOException) {

app/src/main/java/eu/kanade/tachiyomi/network/UserAgentInterceptor.kt

@@ -1,4 +1,4 @@
-package eu.kanade.tachiyomi.network.interceptor
+package eu.kanade.tachiyomi.network
 
 import eu.kanade.tachiyomi.source.online.HttpSource
 import okhttp3.Interceptor

app/src/main/java/eu/kanade/tachiyomi/network/interceptor/RateLimitInterceptor.kt

@@ -1,58 +0,0 @@
-package eu.kanade.tachiyomi.network.interceptor
-
-import android.os.SystemClock
-import okhttp3.Interceptor
-import okhttp3.Response
-import java.util.concurrent.TimeUnit
-
-/**
- * An OkHttp interceptor that handles rate limiting.
- *
- * Examples:
- *
- * permits = 5,  period = 1, unit = seconds  =>  5 requests per second
- * permits = 10, period = 2, unit = minutes  =>  10 requests per 2 minutes
- *
- * @param permits {Int}   Number of requests allowed within a period of units.
- * @param period {Long}   The limiting duration. Defaults to 1.
- * @param unit {TimeUnit} The unit of time for the period. Defaults to seconds.
- */
-class RateLimitInterceptor(
-    private val permits: Int,
-    private val period: Long = 1,
-    private val unit: TimeUnit = TimeUnit.SECONDS
-) : Interceptor {
-
-    private val requestQueue = ArrayList<Long>(permits)
-    private val rateLimitMillis = unit.toMillis(period)
-
-    override fun intercept(chain: Interceptor.Chain): Response {
-        synchronized(requestQueue) {
-            val now = SystemClock.elapsedRealtime()
-            val waitTime = if (requestQueue.size < permits) {
-                0
-            } else {
-                val oldestReq = requestQueue[0]
-                val newestReq = requestQueue[permits - 1]
-
-                if (newestReq - oldestReq > rateLimitMillis) {
-                    0
-                } else {
-                    oldestReq + rateLimitMillis - now // Remaining time
-                }
-            }
-
-            if (requestQueue.size == permits) {
-                requestQueue.removeAt(0)
-            }
-            if (waitTime > 0) {
-                requestQueue.add(now + waitTime)
-                Thread.sleep(waitTime) // Sleep inside synchronized to pause queued requests
-            } else {
-                requestQueue.add(now)
-            }
-        }
-
-        return chain.proceed(chain.request())
-    }
-}

app/src/main/java/eu/kanade/tachiyomi/network/interceptor/SpecificHostRateLimitInterceptor.kt

@@ -1,65 +0,0 @@
-package eu.kanade.tachiyomi.network.interceptor
-
-import android.os.SystemClock
-import okhttp3.HttpUrl
-import okhttp3.Interceptor
-import okhttp3.Response
-import java.util.concurrent.TimeUnit
-
-/**
- * An OkHttp interceptor that handles given url host's rate limiting.
- *
- * Examples:
- *
- * httpUrl = "api.manga.com".toHttpUrlOrNull(), permits = 5, period = 1, unit = seconds  =>  5 requests per second to api.manga.com
- * httpUrl = "imagecdn.manga.com".toHttpUrlOrNull(), permits = 10, period = 2, unit = minutes  =>  10 requests per 2 minutes to imagecdn.manga.com
- *
- * @param httpUrl {HttpUrl} The url host that this interceptor should handle. Will get url's host by using HttpUrl.host()
- * @param permits {Int}   Number of requests allowed within a period of units.
- * @param period {Long}   The limiting duration. Defaults to 1.
- * @param unit {TimeUnit} The unit of time for the period. Defaults to seconds.
- */
-class SpecificHostRateLimitInterceptor(
-    private val httpUrl: HttpUrl,
-    private val permits: Int,
-    private val period: Long = 1,
-    private val unit: TimeUnit = TimeUnit.SECONDS
-) : Interceptor {
-
-    private val requestQueue = ArrayList<Long>(permits)
-    private val rateLimitMillis = unit.toMillis(period)
-    private val host = httpUrl.host
-
-    override fun intercept(chain: Interceptor.Chain): Response {
-        if (chain.request().url.host != host) {
-            return chain.proceed(chain.request())
-        }
-        synchronized(requestQueue) {
-            val now = SystemClock.elapsedRealtime()
-            val waitTime = if (requestQueue.size < permits) {
-                0
-            } else {
-                val oldestReq = requestQueue[0]
-                val newestReq = requestQueue[permits - 1]
-
-                if (newestReq - oldestReq > rateLimitMillis) {
-                    0
-                } else {
-                    oldestReq + rateLimitMillis - now // Remaining time
-                }
-            }
-
-            if (requestQueue.size == permits) {
-                requestQueue.removeAt(0)
-            }
-            if (waitTime > 0) {
-                requestQueue.add(now + waitTime)
-                Thread.sleep(waitTime) // Sleep inside synchronized to pause queued requests
-            } else {
-                requestQueue.add(now)
-            }
-        }
-
-        return chain.proceed(chain.request())
-    }
-}

app/src/main/java/eu/kanade/tachiyomi/source/LocalSource.kt

@@ -33,11 +33,13 @@ import java.util.zip.ZipFile
 class LocalSource(private val context: Context) : CatalogueSource {
     companion object {
         const val ID = 0L
-        const val HELP_URL = "https://tachiyomi.org/help/guides/local-manga/"
+        const val HELP_URL = "https://tachiyomi.org/help/guides/reading-local-manga/"
 
         private const val COVER_NAME = "cover.jpg"
         private val SUPPORTED_ARCHIVE_TYPES = setOf("zip", "rar", "cbr", "cbz", "epub")
 
+        private val POPULAR_FILTERS = FilterList(OrderBy())
+        private val LATEST_FILTERS = FilterList(OrderBy().apply { state = Filter.Sort.Selection(1, false) })
         private val LATEST_THRESHOLD = TimeUnit.MILLISECONDS.convert(7, TimeUnit.DAYS)
 
         fun updateCover(context: Context, manga: SManga, input: InputStream): File? {
@@ -62,12 +64,6 @@ class LocalSource(private val context: Context) : CatalogueSource {
             val c = context.getString(R.string.app_name) + File.separator + "local"
             return DiskUtil.getExternalStorages(context).map { File(it.absolutePath, c) }
         }
-
-        // SY -->
-        val json = Json {
-            prettyPrint = true
-        }
-        // SY <--
     }
 
     override val id = ID
@@ -155,16 +151,19 @@ class LocalSource(private val context: Context) : CatalogueSource {
 
     // SY -->
     fun updateMangaInfo(manga: SManga) {
-        val directory = getBaseDirectories(context).map { File(it, manga.url) }.find {
+        val directory = getBaseDirectories(context).mapNotNull { File(it, manga.url) }.find {
             it.exists()
         } ?: return
+        val json = Json {
+            prettyPrint = true
+        }
         val existingFileName = directory.listFiles()?.find { it.extension == "json" }?.name
         val file = File(directory, existingFileName ?: "info.json")
         file.writeText(json.encodeToString(manga.toJson()))
     }
 
     private fun SManga.toJson(): MangaJson {
-        return MangaJson(title, author, artist, description, genre?.split(", "), status)
+        return MangaJson(title, author, artist, description, genre?.split(", ")?.toTypedArray())
     }
 
     @Serializable
@@ -173,8 +172,7 @@ class LocalSource(private val context: Context) : CatalogueSource {
         val author: String?,
         val artist: String?,
         val description: String?,
-        val genre: List<String>?,
+        val genre: Array<String>?
-        val status: Int
     ) {
 
         override fun equals(other: Any?): Boolean {
@@ -246,10 +244,12 @@ class LocalSource(private val context: Context) : CatalogueSource {
                     ChapterRecognition.parseChapterNumber(this, manga)
                 }
             }
-            .sortedWith { c1, c2 ->
+            .sortedWith(
-                val c = c2.chapter_number.compareTo(c1.chapter_number)
+                Comparator { c1, c2 ->
-                if (c == 0) c2.name.compareToCaseInsensitiveNaturalOrder(c1.name) else c
+                    val c = c2.chapter_number.compareTo(c1.chapter_number)
-            }
+                    if (c == 0) c2.name.compareToCaseInsensitiveNaturalOrder(c1.name) else c
+                }
+            )
             .toList()
 
         return Observable.just(chapters)
@@ -294,7 +294,7 @@ class LocalSource(private val context: Context) : CatalogueSource {
     }
 
     private fun isSupportedFile(extension: String): Boolean {
-        return extension.toLowerCase(Locale.ROOT) in SUPPORTED_ARCHIVE_TYPES
+        return extension.toLowerCase() in SUPPORTED_ARCHIVE_TYPES
     }
 
     fun getFormat(chapter: SChapter): Format {
@@ -306,7 +306,7 @@ class LocalSource(private val context: Context) : CatalogueSource {
 
             return getFormat(chapFile)
         }
-        throw Exception(context.getString(R.string.chapter_not_found))
+        throw Exception("Chapter not found")
     }
 
     private fun getFormat(file: File): Format {
@@ -320,7 +320,7 @@ class LocalSource(private val context: Context) : CatalogueSource {
         } else if (extension.equals("epub", true)) {
             Format.Epub(file)
         } else {
-            throw Exception(context.getString(R.string.local_invalid_format))
+            throw Exception("Invalid chapter format")
         }
     }
 
@@ -363,16 +363,9 @@ class LocalSource(private val context: Context) : CatalogueSource {
         }
     }
 
-    override fun getFilterList() = POPULAR_FILTERS
+    private class OrderBy : Filter.Sort("Order by", arrayOf("Title", "Date"), Selection(0, true))
 
-    private val POPULAR_FILTERS = FilterList(OrderBy(context))
+    override fun getFilterList() = FilterList(OrderBy())
-    private val LATEST_FILTERS = FilterList(OrderBy(context).apply { state = Filter.Sort.Selection(1, false) })
-
-    private class OrderBy(context: Context) : Filter.Sort(
-        context.getString(R.string.local_filter_order_by),
-        arrayOf(context.getString(R.string.title), context.getString(R.string.date)),
-        Selection(0, true)
-    )
 
     sealed class Format {
         data class Directory(val file: File) : Format()