From 01dc277877506f68ed057d1793d721b85b80c506 Mon Sep 17 00:00:00 2001 From: NGB-Was-Taken <76197326+NGB-Was-Taken@users.noreply.github.com> Date: Sun, 16 Nov 2025 20:10:40 +0545 Subject: [PATCH] Replace topbar in ReaderAppBars with ReaderTopBar --- .../reader/appbars/ReaderAppBars.kt | 47 ++++--------------- .../reader/appbars/ReaderTopBar.kt | 19 +++----- 2 files changed, 17 insertions(+), 49 deletions(-) diff --git a/app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderAppBars.kt b/app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderAppBars.kt index 1245df4b6..f4903fd04 100644 --- a/app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderAppBars.kt +++ b/app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderAppBars.kt @@ -33,7 +33,6 @@ import androidx.compose.ui.platform.LocalLayoutDirection import androidx.compose.ui.unit.IntOffset import androidx.compose.ui.unit.LayoutDirection import androidx.compose.ui.unit.dp -import eu.kanade.presentation.components.AppBar import eu.kanade.presentation.reader.components.ChapterNavigator import eu.kanade.tachiyomi.ui.reader.setting.ReaderOrientation import eu.kanade.tachiyomi.ui.reader.setting.ReadingMode @@ -206,41 +205,15 @@ fun ReaderAppBars( ) + fadeOut(animationSpec = readerBarsFadeAnimationSpec), ) { // SY --> - Column(modifierWithInsetsPadding) { + Column { // SY <-- - // TODO: Use ReaderTopBar - AppBar( - modifier = /*SY --> */ Modifier /*SY <-- */ + ReaderTopBar( + modifier = Modifier + .background(backgroundColor) .clickable(onClick = onClickTopAppBar), - backgroundColor = backgroundColor, - title = mangaTitle, - subtitle = chapterTitle, + mangaTitle = mangaTitle, + chapterTitle = chapterTitle, navigateUp = navigateUp, - /* SY --> actions = { - AppBarActions( - listOfNotNull( - AppBar.Action( - title = stringResource( - if (bookmarked) MR.strings.action_remove_bookmark else MR.strings.action_bookmark - ), - icon = if (bookmarked) Icons.Outlined.Bookmark else Icons.Outlined.BookmarkBorder, - onClick = onToggleBookmarked, - ), - onOpenInWebView?.let { - AppBar.OverflowAction( - title = stringResource(MR.strings.action_open_in_web_view), - onClick = it, - ) - }, - onShare?.let { - AppBar.OverflowAction( - title = stringResource(MR.strings.action_share), - onClick = it, - ) - }, - ), - ) - }, SY <-- */ ) // SY --> ExhUtils( @@ -258,8 +231,8 @@ fun ReaderAppBars( onClickBoostPage = onClickBoostPage, onClickBoostPageHelp = onClickBoostPageHelp, ) - // SY <-- } + // SY <-- } Spacer(modifier = Modifier.weight(1f)) @@ -276,10 +249,10 @@ fun ReaderAppBars( ) + fadeOut(animationSpec = readerBarsFadeAnimationSpec), ) { Column( - modifier = modifierWithInsetsPadding, verticalArrangement = Arrangement.spacedBy(MaterialTheme.padding.small), ) { - if (navBarType == NavBarType.Bottom) { + // SY --> + if (navBarType == NavBarType.Bottom) { // <-- SY ChapterNavigator( isRtl = isRtl, onNextChapter = onNextChapter, @@ -315,7 +288,7 @@ fun ReaderAppBars( onClickShare = onShare, onClickPageLayout = onClickPageLayout, onClickShiftPage = onClickShiftPage, - // <-- SY + // SY <-- modifier = Modifier .fillMaxWidth() .background(backgroundColor) diff --git a/app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderTopBar.kt b/app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderTopBar.kt index 9d783af7b..5ed6145de 100644 --- a/app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderTopBar.kt +++ b/app/src/main/java/eu/kanade/presentation/reader/appbars/ReaderTopBar.kt @@ -1,27 +1,20 @@ package eu.kanade.presentation.reader.appbars -import androidx.compose.material.icons.Icons -import androidx.compose.material.icons.outlined.Bookmark -import androidx.compose.material.icons.outlined.BookmarkBorder import androidx.compose.runtime.Composable import androidx.compose.ui.Modifier import androidx.compose.ui.graphics.Color import eu.kanade.presentation.components.AppBar -import eu.kanade.presentation.components.AppBarActions -import kotlinx.collections.immutable.persistentListOf -import tachiyomi.i18n.MR -import tachiyomi.presentation.core.i18n.stringResource @Composable fun ReaderTopBar( mangaTitle: String?, chapterTitle: String?, navigateUp: () -> Unit, - bookmarked: Boolean, - onToggleBookmarked: () -> Unit, - onOpenInWebView: (() -> Unit)?, - onOpenInBrowser: (() -> Unit)?, - onShare: (() -> Unit)?, + //bookmarked: Boolean, + //onToggleBookmarked: () -> Unit, + //onOpenInWebView: (() -> Unit)?, + //onOpenInBrowser: (() -> Unit)?, + //onShare: (() -> Unit)?, modifier: Modifier = Modifier, ) { AppBar( @@ -30,6 +23,7 @@ fun ReaderTopBar( title = mangaTitle, subtitle = chapterTitle, navigateUp = navigateUp, + /* SY -> actions = { AppBarActions( actions = persistentListOf().builder() @@ -79,5 +73,6 @@ fun ReaderTopBar( .build(), ) }, + <- SY */ ) }